> I agree about the new implementation file.

With one exception though: avrdude.c is just too generic a
name.  That name should probably be the name of the main
(CLI) file (rather than main.c).

My suggestion is to name it util.c or such.

avrdude.h should simply combine the exported interfaces
(by libavrdude.a) from all the existing header files.  The
current header file structure is a nuisance for anyone who
wants to use the library.  If there are library-internal
interfaces that are not supposed to be exported (so they
could be easily changed between library versions), they could
go into a second header file that is only used to build the
library itself, but not going to be installed even in case
we once install the library itself.

command line was 'cppcheck --enable=all .'

cppcheck version is 'Cppcheck 1.49'

'Our' usleep is the old posix usleep (except on Windows were we have a replacement in ppiwin.c).

But: POSIX.1-2001 declares this function obsolete; use       nanosleep(2) instead.  POSIX.1-2008 removes the specification of usleep(). (see https://www.kernel.org/doc/man-pages/online/pages/man3/usleep.3.html)

So we better replace all occurrences of usleep by an own wrapper microsleep. To use nanosleep we have check it in the configure file.

I would put this wrapper in a new C-file (avrdude.c?, as we have an avrdude.h defining a usleep for Windows.) I also would move the implementations of usleep and gettimeofday from ppiwin.c to this new file as they are used not only by the parallel port programmers.

When running cppcheck the following findings are reported:

[avr.c:94]: (information) The scope of the variable 'r' can be reduced
[avrftdi.c:368]: (information) The scope of the variable 'n' can be reduced
[avrftdi.c:404]: (style) Variable 'vid' is assigned a value that is never used
[avrftdi.c:404]: (style) Variable 'pid' is assigned a value that is never used
[avrftdi.c:404]: (style) Variable 'interface' is assigned a value that is never used
[avrftdi.c:404]: (style) Variable 'snfound' is assigned a value that is never used
[avrftdi.c:405]: (style) Unused variable: serial
[avrftdi.c:405]: (style) Variable 'foundsn' is assigned a value that is never used
[avrftdi.c:406]: (style) Unused variable: devlist
[avrftdi.c:407]: (style) Unused variable: devlist_ptr
[avrftdi.c:408]: (style) Unused variable: found_dev
[avrpart.c:335]: (information) The scope of the variable 'i' can be reduced
[avrpart.c:335]: (information) The scope of the variable 'j' can be reduced
[bitbang.c:499]: (information) The scope of the variable 'i' can be reduced
[bitbang.c:535]: (information) The scope of the variable 'tries' can be reduced
[bitbang.c:536]: (information) The scope of the variable 'i' can be reduced
[config_gram.c:1952]: (error) Memory leak: yyptr
[config_gram.c]: (information) Interrupted checking because of too many #ifdef configurations.
[jtagmkI.c:706]: (information) The scope of the variable 'b' can be reduced
[jtagmkII.c:486]: (style) Variable 'checksum' is assigned a value that is never used
[jtagmkII.c:2561]: (style) Variable 'config0' is assigned a value that is never used
[jtagmkII.c:2561]: (style) Variable 'config1' is assigned a value that is never used
[jtagmkII.c:2470]: (information) The scope of the variable 'clk' can be reduced
[jtagmkII.c:2561]: (information) The scope of the variable 'config1' can be reduced
[lexer.c:377]: (style) struct or union member 'yy_trans_info::yy_verify' is never used
[lexer.c:378]: (style) struct or union member 'yy_trans_info::yy_nxt' is never used
[lexer.c]: (information) Interrupted checking because of too many #ifdef configurations.
[par.c:49]: (style) struct or union member 'ppipins_t::pin' is never used
[ser_posix.c:197]: (style) Found obsolete function 'gethostbyname'. It is recommended that new applications use the 'getaddrinfo' function
[ser_win32.c:231]: (information) The scope of the variable 'c' can be reduced
[ser_win32.c:285]: (information) The scope of the variable 'c' can be reduced
[stk500.c:751]: (style) Variable 'flash' is assigned a value that is never used
[stk500.c:413]: (information) The scope of the variable 'rc' can be reduced
[stk500.c:992]: (information) The scope of the variable 'fosc' can be reduced
[stk500.c:996]: (information) The scope of the variable 'idx' can be reduced
[stk500v2.c:1721]: (style) Variable 'hiaddr' is assigned a value that is never used
[stk500v2.c:1854]: (style) Variable 'hiaddr' is assigned a value that is never used
[stk500v2.c:2205]: (information) The scope of the variable 'fosc' can be reduced
[stk500v2.c:2210]: (information) The scope of the variable 'idx' can be reduced
[term.c:210]: (style) Variable 'i' is assigned a value that is never used
[term.c:527]: (information) The scope of the variable 'i' can be reduced
[update.c:39]: (information) The scope of the variable 'c' can be reduced
[update.c:207]: (information) The scope of the variable 'vsize' can be reduced
[usb_libusb.c:389]: (information) The scope of the variable 'i' can be reduced
[wiring.c:154]: (information) The scope of the variable 'timetosnooze' can be reduced

Also there are a lot of findings "(style) Found obsolete function 'usleep'. It is recommended that new applications use the 'nanosleep' or 'setitimer' function", which I filtered out.

Some errors were already removed in svn revision 1035.