bugRAPP - Raster Processing Primitives - Bugs: bug #38645, Some morphology functions in...

 
 

bug #38645: Some morphology functions in compute/generic/rc_morph_bin.c is dead code, tuned in vain

Submitted by:  Hans-Peter Nilsson <hpataxis>
Submitted on:  Tue 02 Apr 2013 01:52:53 AM UTC  
 
Category: NoneSeverity: 2 - Minor
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 02 Apr 2013 02:04:08 AM UTC, comment #1:

This was discovered by hacking a rapptune.h to force SIMD wherever possible, in order to debug a back-end implementing all of the HAL backend vector API, i.e. by making rapptune.h contain only RC_IMPL_SIMD for all functions except those where a linker error showed that there was no vectorized version. Later on (i.e. recently) I observed that the mentioned functions also didn't have any vector implementations, thus should have caused linker errors.

(This handmade forcing of SIMD and unroll factor should be possible through configuration options, but that'd be another report.)

Hans-Peter Nilsson <hpataxis>
Project Administrator
Tue 02 Apr 2013 01:52:53 AM UTC, original submission:

The various rc_morph_hmt_golay_* functions in compute/generic/rc_morph_bin.c, benchmarked (for unrolling; there are no vectorized versions presently) in compute/tune/benchmark/rc_benchmark.c, appears to be dead code. It's not used internally and there are no "driver" functions, with which to access them through the API.

Since this is undocumented dead code, adding just compile and tune-time and unreachable code in the compiled library, it should be removed.

Alternatively, this should all be documented with accessor functions and test-cases added.

The same goes for
rc_morph_erode_square_3x3_bin and rc_morph_dilate_square_3x3_bin, which appear to be special cases that are just not called from driver/rapp_morph_bin.c.

Hans-Peter Nilsson <hpataxis>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hpataxis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 02 Apr 2013 02:19:50 AM UTChpataxisSeverity3 - Normal=>2 - Minor

    Back to the top


    Powered by Savane 3.1-cleanup