bugAVR Downloader/UploaDEr - Bugs: bug #40108, [PATCH] Fix avrftdi verification...

 
 

You are not allowed to post comments on this tracker with your current authentification level.

bug #40108: [PATCH] Fix avrftdi verification error after flash write

Submitted by:  Nemui Trinomius <nemuisan>
Submitted on:  Thu 26 Sep 2013 03:22:18 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalItem Group: None
Status: NonePrivacy: Public
Assigned to: Hannes Weisbach <hweisbach>Originator Name: Nemui
Open/Closed: Open

Wed 11 Dec 2013 04:49:07 AM UTC, comment #2:

Dear hweisbach,
Sorry for my late reply.

I tested your patch and got work well.
Please see attached report for detail.
(file #29858)

Nemui Trinomius <nemuisan>
Thu 26 Sep 2013 10:28:56 AM UTC, comment #1:

Thank you for reporting this.

Can you supply a log with -vvvvv as parameters to avrdude as well as the binary you are programming?
I am not accepting this patch as-is because (more or less) randomly resetting programmers is usually not the solution to the problem. In fact, the code is commented with a TODO, which already states what has to be done: /* TODO sync write */.
This means the flush part of write_flush() has to be called.

I've attached a patch (against r1248) implementing this TODO. Could you please try it and report back if they work (apply with -p1)?

(file #29223)

Hannes Weisbach <hweisbach>
Project MemberIn charge of this item.
Thu 26 Sep 2013 03:22:18 AM UTC, original submission:

When write flash below sector size,usually polling byte cannot found.
In this case,verify flash after flash write always fail.

Tested with ATmega1284p(has 256byte sector size).
202byte(<256byte) binary fail,but over 256byte binaries was Ok.

Attached patch fixes this problem to re-initialize avrftdi when polling byte cannot be found.

Nemui Trinomius <nemuisan>

 

Attached Files
file #29858:  avrftdi_testing_report.7z added by nemuisan (18kB - application/x-7z-compressed)
file #29223:  avrftdi_sync.patch added by hweisbach (3kB - application/octet-stream)
file #29218:  avrdude_avrftdi_fix.patch added by nemuisan (1kB - application/octet-stream)
file #29219:  failure_orig_dude.log added by nemuisan (4kB - application/octet-stream)
file #29220:  success_patched_dude.log added by nemuisan (4kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by hweisbach (Updated the item)
  • -unavailable- added by nemuisan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 11 Dec 2013 04:47:16 AM UTCnemuisanAttached File-=>Added avrftdi_testing_report.7z, #29858
    Thu 26 Sep 2013 10:28:56 AM UTChweisbachAttached File-=>Added avrftdi_sync.patch, #29223
      Assigned toNone=>hweisbach
    Thu 26 Sep 2013 03:22:18 AM UTCnemuisanAttached File-=>Added avrdude_avrftdi_fix.patch, #29218
      Attached File-=>Added failure_orig_dude.log, #29219
      Attached File-=>Added success_patched_dude.log, #29220

    Back to the top


    Powered by Savane 3.1-cleanup