bugGPSD - Bugs: bug #44267, Unused return values of...

 
 

bug #44267: Unused return values of nmea_send() and snarfline()

Submitter:  Zbigniew Chyla <zchyla_nokia>
Submitted:  Mon 16 Feb 2015 01:16:26 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Wont Fix
Privacy:  Public Assigned to:  esr
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 16 Feb 2015 03:01:19 AM UTC, comment #1: 

The return value is intended for uniformity with other driver-level write functions, and might become useful in the future.

Your attention to such details is appreciated, however; please keep auditing the code for what you think are bad smells.  I am, as you have seen, generally willing to accept that kind of patch.

Eric S. Raymond <esr>
Group administrator
Mon 16 Feb 2015 01:16:26 AM UTC, original submission:  

Both nmea_send() and snarfline() return values that are never used. All callers ignore them and use casts to void to make code checkers happy. It decreases code readability, so I suggest removing unused return values. See attached patches for details.

Zbigniew Chyla <zchyla_nokia>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by esr (Posted a comment)
  • -email is unavailable- added by zchyla_nokia (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-13 esr Open/ClosedOpen Closed
    2015-02-16 esr StatusNone Wont Fix
        Assigned toNone esr
    2015-02-16 zchyla_nokia Attached File- Added 0001-Remove-unused-return-value-from-nmea_send.patch, #33095
        Attached File- Added 0002-Remove-unused-return-value-from-snarfline.patch, #33096

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code