bugQuilt - Bugs: bug #49693, Rename after forced push leaves...

 
 

bug #49693: Rename after forced push leaves dangling marker

Submitted by:  Jean Delvare <khali>
Submitted on:  Thu 24 Nov 2016 09:50:55 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Nov 2016 09:53:11 AM UTC, comment #1:

I guess this should be done in function rename_in_db(), to make sure we cover all present and future situations.

Jean Delvare <khali>
Project Administrator
Thu 24 Nov 2016 09:50:55 AM UTC, original submission:

If you force-push a patch that does not apply cleanly, quilt tells you it needs to be refreshed, and creates a marker to remember this under .pc/. If you rename the patch before refreshing it, quilt will forget about this. So it will let you continue even if the patch was not refreshed, and it will never delete the marker.

We need to rename the marker when a patch which needs to be refreshed is renamed. Same is probably needed for the fork command as well, as it's essentially a rename with a backup.

The test suite should cover this scenario.

Jean Delvare <khali>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by khali (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup1