The FreeType Project - Bugs: bug #54852, HarfBuzz deprecation of...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54852: HarfBuzz deprecation of hb_ot_tags_from_script breaks afshaper.c compilation
Submitter: | Dominik Röttsches <drott> | ||
Submitted: | Wed 17 Oct 2018 08:38:00 AM UTC | ||
Severity: | 3 - Normal | Item Group: | None |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Planned Release: | None |
Thu 01 Nov 2018 03:45:31 PM UTC, comment #4: |
bungeman <bungeman> |
Fri 19 Oct 2018 08:58:03 PM UTC, comment #3: is HB_OT_MAX_TAGS_PER_SCRIPT a frozen value? I am worried about that change which breaks harfbuzz or freetype or both, when the compiled-time header is not the same as a runtime versions. (i.e. you build freetype, then upgrade harfbuzz, or vice versa). |
Hin-Tak Leung <htl10> |
Wed 17 Oct 2018 05:19:13 PM UTC, comment #2: You can also do:
|
Behdad Esfahbod <behdad> |
Wed 17 Oct 2018 08:39:01 AM UTC, comment #1: Behdad, perhaps you can take a comment on whether the attached patch makes sense.
|
Dominik Röttsches <drott> |
Wed 17 Oct 2018 08:38:00 AM UTC, original submission:
HarfBuzz is deprecating hb_ot_tags_from_script in
|
Dominik Röttsches <drott> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-10-17 | drott | Attached File | - | Added ft_afshaper_hb_ot_tags.patch, #45217 | |
Carbon-Copy | - | Added -email is unavailable- |
Powered by Savane 3.13-3230.
Corresponding source code
The actual value of HB_OT_MAX_TAGS_PER_SCRIPT shouldn't matter much, if it changes the worst that can happen is that you miss one of the possible tags. If you're concerned about possibly missing a tag then check if the returned count is greater than when it was passed in, reserve some more space, and call again. See documentation at [1]. Note that the documentation uses the term 'tags retrieved' to mean all possible tags (not capped by the original count passed in).
[1] https://github.com/harfbuzz/harfbuzz/blob/07ec792212063851ee41eae33792d3d90d31e6a1/src/hb-ot-tag.cc#L323