The FreeType Project - Bugs: bug #55235, CMake update build scripts to...
You are not allowed to post comments on this tracker with your current authentication level.
bug #55235: CMake update build scripts to support all features
Submitter: | rim <rim> | ||
Submitted: | Mon 17 Dec 2018 02:50:38 AM UTC | ||
Severity: | 3 - Normal | Item Group: | None |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Planned Release: | None |
Jump to the original submission
Tue 02 Jun 2020 02:31:33 AM UTC, comment #30: |
rim <rim> |
Mon 11 Nov 2019 06:15:00 AM UTC, comment #29:
|
Werner LEMBERG <wl> |
Mon 11 Nov 2019 12:09:25 AM UTC, comment #28:
|
rim <rim> |
Thu 07 Nov 2019 11:41:48 PM UTC, comment #27: Pushed the change for compiling builds/unix/ftsystem.c on UNIX instead of the generic one. Is there anything here left to incorporate? |
Nikolaus Waxweiler <morksig> |
Fri 12 Jul 2019 01:40:25 AM UTC, comment #26: This is how libtool works. Its virtue is that it works on most Unix platforms and knows about native compiler options for building libraries, which wasn’t trivial back in the days.
|
Alexei Podtelezhnikov <podtelez> |
Thu 11 Jul 2019 10:34:09 PM UTC, comment #25: I started a branch at http://git.savannah.gnu.org/cgit/freetype/freetype2.git/log/?h=cmakelists-updates to update the CMakeLists.txt file.
|
Nikolaus Waxweiler <morksig> |
Tue 02 Jul 2019 10:22:17 PM UTC, comment #24: For reference, some discussion took place on the mailing list: https://lists.nongnu.org/archive/html/freetype-devel/2019-06/msg00109.html
|
Nikolaus Waxweiler <morksig> |
Wed 26 Jun 2019 07:01:49 AM UTC, comment #23: Thanks to all of you for taking care of this issue! |
Werner LEMBERG <wl> |
Tue 25 Jun 2019 08:58:25 PM UTC, comment #22: https://github.com/onqtam/awesome-cmake
|
Nikolaus Waxweiler <morksig> |
Wed 19 Jun 2019 10:43:16 PM UTC, comment #21:
|
Nikolaus Waxweiler <morksig> |
Wed 19 Jun 2019 08:44:40 PM UTC, comment #20: "Is this a CMake bug?" - I do not remember, but I remember that BZip2 does not work like all other staff, and this is the best solution that I found.
|
rim <rim> |
Wed 19 Jun 2019 07:39:16 AM UTC, comment #19: "What about the opposite? A user removes the comment by hand and cmake fails to find it. Cmake should put the cheese moment back." - Build system should not care about all things that user can do after dist unpacked, it only build unmodified sources.
|
rim <rim> |
Mon 17 Jun 2019 04:15:52 AM UTC, comment #18: Re: #16
|
Alexei Podtelezhnikov <podtelez> |
Sun 16 Jun 2019 05:55:32 PM UTC, comment #17: So I finally took the time to look at the proposed changes and I am unhappy with them, they increase the complexity of the build definition without a clear benefit.
|
Nikolaus Waxweiler <morksig> |
Sun 16 Jun 2019 05:40:36 PM UTC, comment #16: Umm... when would that happen and is it a valid use case to mess with the build system output outside the build system? |
Nikolaus Waxweiler <morksig> |
Sun 16 Jun 2019 04:35:48 PM UTC, comment #15: What about the opposite? A user removes the comment by hand and cmake fails to find it. Cmake should put the cheese moment back.
|
Alexei Podtelezhnikov <podtelez> |
Sun 16 Jun 2019 02:50:34 PM UTC, comment #14: I have not tested this patch, my comment was referring to the existing CMakeLists.txt file in git master.
|
Nikolaus Waxweiler <morksig> |
Thu 13 Jun 2019 09:52:47 PM UTC, comment #13: Not all, ~half.
|
rim <rim> |
Thu 13 Jun 2019 09:16:10 PM UTC, comment #12: It is too hard to read a diff that rewrites the whole file. Please attached the actual file. |
Alexei Podtelezhnikov <podtelez> |
Thu 13 Jun 2019 08:28:57 PM UTC, comment #11: Add options:
|
rim <rim> |
Thu 13 Jun 2019 02:28:28 AM UTC, comment #10: Nikolaus, are you sure that you use latest attached patch?
|
rim <rim> |
Wed 12 Jun 2019 09:15:57 PM UTC, comment #9: It should also be able to put the comment back if the package is not found. This is what configure does. |
Alexei Podtelezhnikov <podtelez> |
Wed 12 Jun 2019 08:50:28 PM UTC, comment #8: Err, fix what exactly?
|
Nikolaus Waxweiler <morksig> |
Wed 05 Jun 2019 02:51:33 PM UTC, comment #7: It is imperative to stay aligned between cmake and autoconf/make procedures because FreeType requires ultra-portability. This is to say that we do not optimize for a particular system or distribution, we are stay agnostic. Each distribution can do it's own tricks and compilation flags but FreeType won't distribute them. So please stay conservative: no c11 or gcc-specific features please.
|
Alexei Podtelezhnikov <podtelez> |
Wed 05 Jun 2019 12:50:53 PM UTC, comment #6: Reattached after accidentally deleting. |
Alexei Podtelezhnikov <podtelez> |
Tue 04 Jun 2019 09:23:17 PM UTC, comment #5: I remove most of CFLAGS and hardening things.
|
rim <rim> |
Sat 30 Mar 2019 05:01:16 PM UTC, comment #4: I had a cursory look at the patch, what is the reason you enable all the `-f` features? I understand that hardening is desirable in general, but the flags aren't used for the default build system and tend to be distro-specific. This would result in a different build from what the default build system would produce. I am not sure that's a good thing. I suppose enabling `-fwrapv` might benefit a number-crunching library such as FreeType, but that has to be discussed with Werner.
|
Nikolaus Waxweiler <morksig> |
Sun 30 Dec 2018 03:21:11 AM UTC, comment #3: Remove -fsanitize=safe-stack die to brokes some apps
|
rim <rim> |
Fri 28 Dec 2018 11:10:27 PM UTC, comment #2: 1. Ok, reformat done.
|
rim <rim> |
Mon 17 Dec 2018 06:57:35 AM UTC, comment #1: Thanks for your contribution. However, there are very serious problems with your patch.
|
Werner LEMBERG <wl> |
Mon 17 Dec 2018 02:50:38 AM UTC, original submission:
I have done update CMake files, now they can be used as main build system, at least for FreeBSD.
|
rim <rim> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-11-11 | rim | Attached File | - | Added 0001-PATCH-Update-CMake-build-scripts.patch, #47833 | |
2019-11-10 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #47832 | |
2019-06-13 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #47095 | |
2019-06-05 | podtelez | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #47038 | |
2019-06-05 | podtelez | Attached File | #47035 | Removed | |
2019-06-05 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #47035 | |
2019-06-04 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #47030 | |
2019-03-30 | wl | Summary | CMake update build scripts to support all futures | CMake update build scripts to support all features | |
2018-12-30 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #45783 | |
2018-12-28 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #45763 | |
2018-12-17 | rim | Attached File | - | Added 0001-Update-CMake-build-scripts.patch, #45678 |
Powered by Savane 3.13-cf05.
Corresponding source code
комментарий №29:
I will not split this in to series of small patches:
1. This patch do all that I need - solve my problems
2. I have no motivation to play game: "redo all your work one more time" - it is hard to decompile this to something small that easy to read.