GNU nano - Bugs: bug #56488, the status bar reports the wrong...
You are not allowed to post comments on this tracker with your current authentication level.
bug #56488: the status bar reports the wrong file when there is a bad included file
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Thu 13 Jun 2019 11:45:33 AM UTC | ||
Severity: | 2 - Minor | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Jump to the original submission
Sun 18 Aug 2019 09:11:23 AM UTC, comment #9: |
Benno Schulenberg <bens> |
Sun 18 Aug 2019 09:01:55 AM UTC, comment #8: Ah, okay. But the check is better placed in parse_includes(); and empty syntax at the end of an include file is already caught.
|
Benno Schulenberg <bens> |
Sat 17 Aug 2019 05:51:45 PM UTC, comment #7: Oops, I transposed the lines, it should be:
|
Brand Huntsman <brand> |
Sat 17 Aug 2019 11:57:28 AM UTC, comment #6: Thanks for the updated patch. After improving the commit message, pushed to master, commit 82f5fed4.
|
Benno Schulenberg <bens> |
Wed 14 Aug 2019 09:41:35 PM UTC, comment #5: Saving and restoring nanorc and lineno in parse_one_include() works and replaces the first patch. The second and third patches are still needed.
|
Brand Huntsman <brand> |
Wed 14 Aug 2019 11:41:25 AM UTC, comment #4: Thanks for the patches. But using the reproduction recipe, it now says on the status bar: "[ Mistakes in '/home/ben/Sources/NANO/syntax/folder.nanorc' ]". But... there aren't actually any mistakes in folder.nanorc, the mistake is in the include statement that includes this folder.nanorc.
|
Benno Schulenberg <bens> |
Tue 09 Jul 2019 03:02:10 AM UTC, comment #3: The empty syntax check also needs to be performed before changing nanorc to an include file. Second patch.
|
Brand Huntsman <brand> |
Mon 08 Jul 2019 07:23:36 PM UTC, comment #2: (I'm away on vacation. Will get to this and the other things in about three weeks.) |
Benno Schulenberg <bens> |
Sat 29 Jun 2019 11:10:10 AM UTC, comment #1: is_good_file() calls jot_error() which sets rcfile_with_errors to the current string in the nanorc global. Problem is that parse_one_include() calls is_good_file() before it updates the nanorc global. |
Brand Huntsman <brand> |
Thu 13 Jun 2019 11:45:33 AM UTC, original submission:
To reproduce, have in your ~/.nanorc file an include statement with a globbing pattern: include /some/directory/*.nanorc. Then create in that directory:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2019-08-26 | bens | Open/Closed | Open | Closed | |
2019-08-17 | bens | Status | None | Fixed | |
Assigned to | None | bens | |||
2019-08-14 | brand | Attached File | - | Added 0001-restore-nanorc-and-lineno-after-parsing-an-include-file.patch, #47346 | |
2019-07-09 | brand | Attached File | - | Added 0002-rcfile-check-for-empty-syntax-before-parsing-an-include-file.patch, #47173 | |
Attached File | - | Added 0003-rcfile-show-lineno-for-syntax-instead-of-where-the-empty-syntax-check-is-performed.patch, #47174 | |||
2019-06-29 | brand | Attached File | - | Added set-nanorc-before-calling-is_good_file.patch, #47144 |
Powered by Savane 3.13-02a9.
Corresponding source code
s/; and/; an/