bugXlog - Bugs: bug #57922, xlog uses G_CONST_RETURN...

 
 

bug #57922: xlog uses G_CONST_RETURN (deprecated in 2.30)

Submitter:  Greg Troxel <gdt>
Submitted:  Fri 28 Feb 2020 05:56:00 PM UTC
   
 
Category:  General Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  andystewart
Open/Closed:  Closed Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 17 Feb 2021 02:02:57 AM UTC, comment #3: 


This change is available in xlog 2.0.21beta2.

Andy Stewart <andystewart>
Group administrator
Mon 15 Feb 2021 11:21:53 PM UTC, comment #2: 

Hi Greg,

This has been fixed, including the removal of the commented out line in log.c.  It will be available in either xlog 2.0.21betaN or 2.0.21.

Thanks for bringing this to my attention.

73,

Andy
KB1OIQ

Andy Stewart <andystewart>
Group administrator
Thu 04 Feb 2021 02:47:04 PM UTC, comment #1: 

G_CONST_RETURN no longer appears in the source code, so this bug can probably be closed.

(There is still a commented-out version of it in log.c, which should probably be deleted.)

Greg Troxel <gdt>
Fri 28 Feb 2020 05:56:00 PM UTC, original submission:  

Fix is as suggested in the glib header:

+--- src/log.c.orig     2015-04-19 20:39:29.000000000 +0000
++++ src/log.c
+@@ -455,7 +455,7 @@ savelog (gpointer arg, gchar * logfile,
+ {
+       LOGDB *lp;
+       gint i, j, k, pid, exported;
+-      G_CONST_RETURN gchar *label;
++      const gchar *label;
+       gchar *pathstr;
+       item_t *sorteditems;
+       gint fields[QSO_FIELDS], widths[QSO_FIELDS];

Greg Troxel <gdt>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andystewart (Posted a comment)
  • -email is unavailable- added by gdt (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-02-17 andystewart Open/ClosedOpen Closed
    2021-02-15 andystewart StatusNone Fixed
        Assigned toNone andystewart

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code