bugThe FreeType Project - Bugs: bug #58355, LCD filtering code move,...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58355: LCD filtering code move, 652f886319327 breaks compilation in Chromium

Submitter:  Dominik Röttsches <drott>
Submitted:  Tue 12 May 2020 10:50:13 AM UTC
   
 
Severity:  3 - Normal Item Group:  None
Status:  Works For Me Privacy:  Public
Assigned to:  podtelez Open/Closed:  Closed
Planned Release:  None

Jump to the original submission

Wed 16 Dec 2020 03:11:06 PM UTC, comment #6: 

I plan to move the filtering code inside the smooth module shortly and the relevant data from FT_LibraryRec to FT_RendererRec. It should not be disruptive but the internal structures will be changed.

Alexei Podtelezhnikov <podtelez>
Group Member
Wed 16 Dec 2020 01:25:24 PM UTC, comment #5: 

I think we can close this now.

Dominik Röttsches <drott>
Tue 12 May 2020 04:49:38 PM UTC, comment #4: 

I will keep it "Open" but "Works For Me" as an outlet for anyone with custom ftmodule.h.

Alexei Podtelezhnikov <podtelez>
Group Member
Tue 12 May 2020 01:23:51 PM UTC, comment #3: 

Looks like the bots turn green - feel free to close this.

Dominik Röttsches <drott>
Tue 12 May 2020 11:21:14 AM UTC, comment #2: 

I think it is matter of generating new ftmodules.h, which is done by ./configure.

Alexei Podtelezhnikov <podtelez>
Group Member
Tue 12 May 2020 11:18:54 AM UTC, comment #1: 

Looks like I just needed to edit the local version of ftmodule.h to reflect the upstream change. I expect it to build now.

https://chromium-review.googlesource.com/c/chromium/src/+/2195769

Dominik Röttsches <drott>
Tue 12 May 2020 10:50:13 AM UTC, original submission:  

The FreeType roll containing

https://chromium-review.googlesource.com/c/chromium/src/+/2194976

https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=652f88631932713309b6fa2cf12669699e3fc8e6

breaks the build in Chromium.

[14389/78215] LINK ./generate_fontconfig_caches
FAILED: generate_fontconfig_caches
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now -Wl,-z,defs -Wl,--as-needed -fuse-ld=lld -Wl,--color-diagnostics -m64 -Werror -Wl,-O2 -Wl,--gc-sections -rdynamic -nostdlib++ --sysroot=../../build/linux/debian_sid_amd64-sysroot -L../../build/linux/debian_sid_amd64-sysroot/usr/local/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/lib/x86_64-linux-gnu -L../../build/linux/debian_sid_amd64-sysroot/usr/lib/x86_64-linux-gnu -fprofile-instr-generate -pie -Wl,--disable-new-dtags -o "./generate_fontconfig_caches" -Wl,--start-group @"./generate_fontconfig_caches.rsp"  -Wl,--end-group  -ldl -lpthread -lrt -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lglib-2.0 -luuid
ld.lld: error: undefined symbol: ft_smooth_lcd_renderer_class

>>> referenced by ftinit.c
>>>               obj/third_party/freetype/freetype_source/ftinit.o:(FT_Add_Default_Modules)


ld.lld: error: undefined symbol: ft_smooth_lcdv_renderer_class

>>> referenced by ftinit.c
>>>               obj/third_party/freetype/freetype_source/ftinit.o:(FT_Add_Default_Modules)


Alexei, I'd be happy if you have any ideas how to address this - I'll try to take a look as well.


Dominik Röttsches <drott>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by podtelez (Posted a comment)
  • -email is unavailable- added by drott (Submitted the item)
  • -email is unavailable- added by drott
  • -email is unavailable- added by drott
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-12-16 podtelez Open/ClosedOpen Closed
    2020-05-12 podtelez StatusNone Works For Me
        Assigned toNone podtelez
    2020-05-12 drott Carbon-Copy- Added -email is unavailable-
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code