bugm17n - Bugs: bug #65420, bashism in configure.ac

 
 

bug #65420: bashism in configure.ac

Submitter:  Eli Schwartz <eschwartz>
Submitted:  Wed 06 Mar 2024 04:02:16 AM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  mike_fabian
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 16 Sep 2024 01:27:17 PM UTC, comment #2: 

https://git.savannah.nongnu.org/cgit/m17n/m17n-lib.git/commit/?id=d99ea8917d24d8feda112f5155e9f0ef4e73e09d

 Mike FABIAN <mike_fabian>
Group Member
Mon 16 Sep 2024 01:26:22 PM UTC, comment #1: 

Thank you very much!

I pushed your fix to master and it will be in the next release.

Mike FABIAN <mike_fabian>
Group Member
Wed 06 Mar 2024 04:02:16 AM UTC, original submission:  

While building the software on Gentoo with a custom lint, I detected abnormal code in the generated configure script. It comes from the following line:

if test "x$HAVE_LIBTHAI" == "xyes"; then


The warning:

./configure: 22449: test: xno: unexpected operator


The double equals is a bashism, and a poor one at that as it exists solely to be confusing and accomplish nothing. Remove it from the POSIX sh configure script via the attached patch.

 Eli Schwartz <eschwartz>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #55789:  0001-configure.ac-fix-incorrect-bashism.patch added by eschwartz (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mike_fabian (Posted a comment)
  • -email is unavailable- added by eschwartz (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2024-09-16 mike_fabian StatusNone Fixed
        Assigned toNone mike_fabian
        Open/ClosedOpen Closed
    2024-03-06 eschwartz Attached File- Added 0001-configure.ac-fix-incorrect-bashism.patch, #55789

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.13-8a8d.
    Corresponding source code