bugAVR C Runtime Library - Bugs: bug #11505, inp()/outp() comments in...

 
 

bug #11505: inp()/outp() comments in ./include/avr/sfr_defs.h outdated

Submitted by:  Mudiaga Obada <obada>
Submitted on:  Wed 05 Jan 2005 09:41:45 PM UTC  
 
Category:  Documentation Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Percent Complete:  100%
Assigned to:  Eric Weddington <arcanum> Open/Closed:  Closed
Release:  None Fixed Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 07 Jan 2005 07:47:37 PM UTC, comment #4: 

Fixed on 1.2 branch. Bug closed.

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Fri 07 Jan 2005 07:26:07 PM UTC, comment #3: 

Fixed on 1.2 branch. Bug closed.

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Fri 07 Jan 2005 07:04:11 PM UTC, comment #2: 

Fixed on HEAD. Will fix on 1.2 branch....

Eric Weddington <arcanum>
Project AdministratorIn charge of this item.
Wed 05 Jan 2005 09:54:09 PM UTC, comment #1: 

Ok, i see what

#if _SFR_IO_REG_P(SPMCR)
out _SFR_IO_ADDR(SPMCR), r24
#else
sts _SFR_MEM_ADDR(SPMCR), r24
#endif

has to do with __SFR_OFFSET. Please ignore that part of the previous message.

Mudiaga Obada <obada>
Wed 05 Jan 2005 09:41:45 PM UTC, original submission:  

It seems like the documentation in ./include/avr/sfr_defs.h was left in there after inX()/outX() support was removed.

The following should be removed:

<quote>
   The old inp()/outp() macros are still supported, but not recommended to use
   in new code.  The order of outp() arguments is confusing. </quote>

Also the lines

#if _SFR_IO_REG_P(SPMCR)
out _SFR_IO_ADDR(SPMCR), r24
#else
sts _SFR_MEM_ADDR(SPMCR), r24
#endif

look stray, since i can't tell from their (stand alone) context what they are there for. Also, the comments that follow it looks strage to me...

For my oppinion (which i know comes rather late), no longer having inX()/outX() and cbi()/sbi() support is unfortunate. There's lot of existing code that uses it, and it can be really inconvinient - especially for those new to gcc/avr-libc.

Mudiaga Obada <obada>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

 

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-01-07 arcanum Percent Complete80% => 100%
    Open/ClosedOpen => Closed
2005-01-07 arcanum Percent Complete0% => 80%
    Assigned toNone => arcanum

Back to the top


Powered by Savane 3.5