bugmldonkey, a multi-networks file-sharing client - Bugs: bug #13891, Sancho is not showing when a file...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #13891: Sancho is not showing when a file has been downloaded before

Submitter:  None
Submitted:  Sat 23 Jul 2005 09:35:20 AM UTC
   
 
Category:  Core Severity:  3 - Normal
Item Group:  Program malfunction Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release:  2.6.0 Release: 
Operating System:  Linux Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86

Jump to the original submission

Thu 01 Sep 2005 04:38:24 PM UTC, comment #12: 

Reported to be solved with patch #4376

spiralvoice <spiralvoice>
Group administrator
Tue 26 Jul 2005 11:43:57 PM UTC, comment #11: 

The whole donkeyIndexer stuff is disabled in 2.6 branch:

for example:
( TODO RESULT  let other_names = DonkeyIndexer.find_names md4 in )

I have to contact b8_bavard, the main dev and ask him whats the
status of it.

spiralvoice <spiralvoice>
Group administrator
Tue 26 Jul 2005 10:41:46 PM UTC, comment #10: 

This is still a bug. The r.result_done boolean is never set to true.

This is also used in the web interface to show the "ALREADY DOWNLOADED" string. (see driverInteractive)

It used to be done in

donkeyIndexer.index_result_no_filter

by checking to see if result_md4 was in old_files and setting it true.

But this is not used anymore, so the r.result_done is always false.

Anonymous
Mon 25 Jul 2005 03:26:36 PM UTC, comment #9: 

"Each branch has its pro and cons, there is no wrong or right. "

Yeah. Sorry if it looked i was talking about all the branch. I was thinking about the "keep_cancelled_in_old_files" option when I said that.

About adding another option called "keep_downloaded_in_old_files", I think that is the approach that will make everyone happy.



Anonymous
Mon 25 Jul 2005 03:09:10 PM UTC, comment #8: 

"Sorry, went back to mulus. Seems to be working better for me at this point of development (not just for this issue). "
No problem.

"No matter how long have you been walking on the wrong path, come back and pick the right one."
Each branch has its pro and cons, there is no wrong or right.
Even more, I think there is never a right path, there are always
alternatives, but this is too philosophical for MLDonkey bug tracker ;-)

"Suppose you change the code so commited files always go to oldfiles"
I don´t want to let MLDonkey keep a record of all files I download.

The only change would be a new option: keep_downloaded_in_old_files.

"always use the force_download command to do it (assuming it was not removed from the 2.6 branch). "
Its there and alive.

spiralvoice <spiralvoice>
Group administrator
Mon 25 Jul 2005 11:50:35 AM UTC, comment #7: 

Sorry, went back to mulus. Seems to be working better for me at this point of development (not just for this issue).

About the incorrect code, I dont know who put it there or when, but I would fix it anyway. No matter how long have you been walking on the wrong path, come back and pick the right one.

Suppose you change the code so commited files always go to oldfiles, and cancelled files only go to oldfiles if keep_cancelled_in_old_files is enabled.
Think about the possible situations:

1) You have it "enabled" now.
Current behavior: Both commited and cancelled files are added to oldfiles
New behavior: The same.

2) You have it "disabled" now.
Current behavior: No files are added to oldfiles.
New behavior: Commited files are always added to oldfiles, cancelled files will not be added to oldfiles.

In the first case there is no difference.
In the second case, there is a difference, but its really not much problem. Most people will never want to download the same file twice, and if they really need to (because they deleted it by mistake or whatever), they can always use the force_download command to do it (assuming it was not removed from the 2.6 branch).




Anonymous
Mon 25 Jul 2005 09:49:07 AM UTC, comment #6: 

"add to the oldfiles the ones cancelled"
I know, but when looking where keep_cancelled_in_old_files is used
came across this code in donkeyInteractive.ml:

  file_ops.op_file_commit <- (fun file new_name ->
      if !!keep_cancelled_in_old_files
          && not (List.mem file.file_md4 !!old_files) then
        old_files =:= file.file_md4 :: !!old_files;

So old_files is also filled with committed files, I don´t by whom
and when this was changed but it seems to be implemented.
Please test this behaviour, if it works for you I will change the
description of this option, changing the option name without
resetting the option for all users is not possible IMHO.

spiralvoice <spiralvoice>
Group administrator
Sun 24 Jul 2005 09:29:41 PM UTC, comment #5: 

In previous mldonkey releases, the keep_cancelled_in_old_files option just made the core to add to the oldfiles the ones cancelled, even if they were not downloaded.

If you changed that behavior on purpose, i recommend you change the name of that option to something that reflects what it does now, or at least document it.


Anonymous
Sun 24 Jul 2005 09:17:45 PM UTC, comment #4: 

"ED2K-keep_cancelled_in_old_files was not enabled"
"old_files = [] thing and its empty"
its not a bug, its a feature, you have to enable ED2K-keep_cancelled_in_old_files,
otherwise information about downloaded files is not saved, without
that thr core is not able to show "when a file has been downloaded before"

spiralvoice <spiralvoice>
Group administrator
Sun 24 Jul 2005 07:59:18 PM UTC, comment #3: 

ED2K-keep_cancelled_in_old_files was not enabled, but the file I searched for was just downloaded and commited.

I took a look at the  old_files = [] thing and its empty, but the core has not stopped since I downloaded this. Does it write the ini's only at shutdown?


Anonymous
Sun 24 Jul 2005 05:18:48 PM UTC, comment #2: 

Do you have ED2K-keep_cancelled_in_old_files enabled?

Are there entries here in donkey.ini:

        ( The files that were downloaded )
 old_files = []

spiralvoice <spiralvoice>
Group administrator
Sat 23 Jul 2005 09:37:09 AM UTC, comment #1: 

Forgot to say I'm using sancho 0.9.4-44 (latest at this time).

Anonymous
Sat 23 Jul 2005 09:35:20 AM UTC, original submission:  

Hello,

There is some kind of bug with the core that makes sancho not display in the "search" window when a file has been downloaded before. The previously downloaded files should be green.

NOTE: Sent this bug to sancho's development team before, but they said this is a core problem, since it works as expected with knocker's core releases.


If you need any more info, you can contact me here:

metralla at redleader.dyndns.org


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-01 spiralvoice StatusPostponed Fixed
    Open/ClosedOpen Closed
2005-07-27 bogeyman Carbon-Copy- Added bogeyman
2005-07-26 spiralvoice StatusWont Fix Postponed
    Open/ClosedClosed Open
2005-07-26 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker
2005-07-24 spiralvoice StatusNone Wont Fix
2005-07-24 spiralvoice Carbon-Copy- Added -email is unavailable-

Back to the top

Powered by Savane 3.15-64aa.
Corresponding source code