bugutil-vserver - Bugs: bug #14026, vdlimit performs vc_add_limit()...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14026: vdlimit performs vc_add_limit() before validation

Submitter:  Kevin Pendleton <kevinp>
Submitted:  Wed 03 Aug 2005 11:09:59 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  Crash Status:  Fixed
Privacy:  Public Assigned to:  ensc
Open/Closed:  Closed Component Version:  alpha
Release:  208

Sat 29 Oct 2005 03:09:52 PM UTC, comment #1: 
Enrico Scholz <ensc>
Group administrator
Wed 03 Aug 2005 11:09:59 PM UTC, original submission:  

When executing an invalid command such as:

/usr/sbin/vdlimit --xid 300 --set space_total=2000000 --set space_used=3020400 --set inodes_total=2000000 --set inodes_used=3 --set reserved=5 /vservers/test/

vdlimit reports the following error:

vdlimit: vc_set_dlimit(): Invalid argument

But vdlimit has already performed vc_add_limit() and sets the values at 0, causing disk space problems on the vserver.

The validation of the values needs to be performed before executing vc_add_limit(), so that invalid results can not be set.

Also, more detailed error messages may also help.  In this example, the error might include the information that space_used can not be larger then the space_total.

(Note: The invalid results were obtained by dynamically assigning the space_used based off of current usages.)

Kevin Pendleton <kevinp>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-10-29 ensc StatusNone Fixed
    Assigned toNone ensc
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.14-8aba.
Corresponding source code