bugConcurrent Versions System - Bugs: bug #14435, Stack overflow on commit

 
 

bug #14435: Stack overflow on commit

Submitted by:  None
Submitted on:  Tue 06 Sep 2005 08:05:27 AM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release: 
Fixed Release:  1.11.21 Fixed Feature Release:  1.12.13

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 07 Sep 2005 09:30:49 AM UTC, comment #4:

Yes, revised patch works ok.
Thanks.

Anonymous
Tue 06 Sep 2005 06:13:18 PM UTC, comment #3:

The patch passes sanity.sh testing.

Mark D. Baushke <mdb>
Project Administrator
Tue 06 Sep 2005 10:10:53 AM UTC, comment #2:

A slightly revised patch is attached. It is against the
cvs1-11-x-branch. It removes the recursive version of the
code and cleans up the indenting sytle for the code.

I would be interested to learn if this still works with
your reported test case.

Mark D. Baushke <mdb>
Project Administrator
Tue 06 Sep 2005 08:07:23 AM UTC, comment #1:

Sorry, sample file too large, so attach only chanhed sources

Anonymous
Tue 06 Sep 2005 08:05:27 AM UTC, original submission:

The project I'm developing uses automated source backup into CVS. CVS runs under QNX/Neutrino and communication with it is via CVS protocol. After each change to source file it is automatically commited. Everything works fine until system tries to commit file revision No. 8152, then CVS fails.
I debugged CVS a bit and found that it is because of recursivness of RCS_putdtree function, as stack overflow occures when it goes too deep.

Attached sample file on which CVS failes and changed RCS_putdtree function to correct this. New version is in #else section of RCS_RECURSIVE define.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #3452:  rcs.c-1-11-x-branch.diff added by mdb (3KiB - text/x-patch - Unified diff for cvs 1.11.x stable branch)
file #3451:  rcs.zip added by None (1KiB - application/x-zip-compressed)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-06 mdb Fixed Feature ReleaseNone => 1.12.13
2005-09-06 mdb StatusNone => Fixed
    Open/ClosedOpen => Closed
    Fixed ReleaseNone => 1.11.21
2005-09-06 mdb Attached File- => Added rcs.c-1-11-x-branch.diff, #2919
2005-09-06 None Attached File- => Added rcs.zip , #2918

Back to the top


Powered by Savane 3.3