bugConcurrent Versions System - Bugs: bug #14448, a call to make_bufs_from_fds in...

 
 

bug #14448: a call to make_bufs_from_fds in kerberos4-client.c misses root argument

Submitted by:  None
Submitted on:  Tue 06 Sep 2005 03:12:52 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: ClosedRelease: 1.12.12 (&earlier?)
Fixed Release: NoneFixed Feature Release: 1.12.13

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 06 Sep 2005 03:44:25 PM UTC, comment #1:

Thanks for the patch! I've checked it in:

2005-09-06 Derek Price <derek@ximbiot.com>

Close <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14448>.
* kerberos-client.c (start_kerberos4_server): Pass new root arg to
make_bufs_from_fds.
(Patch from <Manuel.Guijarro.AT.cern.ch>.)

Derek Robert Price <dprice>
Project Administrator
Tue 06 Sep 2005 03:12:52 PM UTC, original submission:

Hi,

When compiling cvs-1.12.12 in Scientific Linux CERN Release 3.0.5 (SL) -kernel 2.4.21-32.0.1.EL.cern-, compilation fails with:
.....
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../lib -I../diff -I../zlib
-I/usr/kerberos4/include -I/usr/heimdal/include -Ino/include -g -O2 -MT
zlib.o -MD -MP -MF ".deps/zlib.Tpo" -c -o zlib.o zlib.c; \
then mv -f ".deps/zlib.Tpo" ".deps/zlib.Po"; else rm -f ".deps/zlib.Tpo";
exit 1; fi
if gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../lib -I../lib -I../diff -I../zlib
-I/usr/kerberos4/include -I/usr/heimdal/include -Ino/include -g -O2 -MT
kerberos4-client.o -MD -MP -MF ".deps/kerberos4-client.Tpo" -c -o
kerberos4-client.o kerberos4-client.c; \
then mv -f ".deps/kerberos4-client.Tpo" ".deps/kerberos4-client.Po"; else
rm -f ".deps/kerberos4-client.Tpo"; exit 1; fi
kerberos4-client.c: In function `start_kerberos4_server':
kerberos4-client.c:86: warning: passing arg 6 of `krb_sendauth' discards
qualifiers from pointer target type
kerberos4-client.c:98: warning: passing arg 4 of `make_bufs_from_fds' from
incompatible pointer type
kerberos4-client.c:98: warning: passing arg 6 of `make_bufs_from_fds'
makes pointer from integer without a cast
kerberos4-client.c:98: too few arguments to function `make_bufs_from_fds'
make[2]: *** [kerberos4-client.o] Error 1
make[2]: Leaving directory
`/afs/cern.ch/user/m/manuel/sand/quattor_linux/cvs/cvs-1.12.12/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/afs/cern.ch/user/m/manuel/sand/quattor_linux/cvs/cvs-1.12.12'
make: *** [all] Error 2
[root@lxcvs05 cvs-1.12.12]#

...The error is due to the fact that kerberos4-client.c misses root argument when calling function make_bufs_from_fds:

% diff cvs-1.12.12/src/kerberos4-client.c \ cvs-1.12.12/src/kerberos4-client.c.orig
98c98
< make_bufs_from_fds (s, s, 0, root, to_server_p, from_server_p, 1);
---

> make_bufs_from_fds (s, s, 0, to_server_p, from_server_p, 1);

%
Cheers: Manuel.Guijarro.AT.cern.ch

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 4 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 06 Sep 2005 03:44:25 PM UTCdpriceStatusNone=>Fixed
  Open/ClosedOpen=>Closed
  Release=>1.12.12 (&earlier?)
  Fixed Feature ReleaseNone=>1.12.13

Back to the top


Powered by Savane 3.1-cleanup1