bugmldonkey, a multi-networks file-sharing client - Bugs: bug #14735, mlgui abort trap...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #14735: mlgui abort trap "g_source_remove: assertion `tag > 0' failed"

Submitter:  Thomas Klausner <tk>
Submitted:  Thu 06 Oct 2005 12:09:33 PM UTC
   
 
Category:  GUI GTK2 Severity:  3 - Normal
Item Group:  Segmentation Fault Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release:  2.6.4 Release:  2.6.4
Operating System:  NetBSD Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86

Jump to the original submission

Sat 26 Nov 2005 10:17:06 AM UTC, comment #7: 

I tracked the g_source_remove warning down to a bug in uim, an input method.
The patch fixing the core dump has already been committed, so please close this bug report. Thanks.

Thomas Klausner <tk>
Wed 26 Oct 2005 10:47:33 AM UTC, comment #6: 

Don't look too hard for now -- I checked and found that I get the same warning with gtk-demo(!) itself. I'll file a bug report with the GTK people.

Since the abort() is fixed, you can close this bug report (if the two patches get committed). Thanks!

Thomas Klausner <tk>
Tue 25 Oct 2005 01:42:06 PM UTC, comment #5: 

I'm still wondering why and where we call g_source_remove with a wrong id (assertion `tag > 0' failed). I have to check again.

For the problem rergarding the mlgui window closing, please see bug #14751 and task #4694.

For the dottiness of the availability bars, you can fill a new bug report. but right now, i don't understand why you have such a display...

su_blanc <su_blanc>
Group Member
Tue 25 Oct 2005 12:53:44 PM UTC, comment #4: 

I recompiled mlgui against lablgtk2-20050701, with the lablgtk2 and the mldonkey patches applied, and the core dumps are gone.

I still have
(mlgui:6192): GLib-CRITICAL **: g_source_remove: assertion `tag > 0' failed
when I switch to "uploads", but I didn't see any segfaults again.

Do you want to track this down, or do you think it's not important?

Two remaining problems:
. when I close the mlgui window, the application doesn't quit. When I then press CTRL-C, I get: "2005/10/25 14:51:40 Exception poll failed: Interrupted system call in Select.loop" and it doesn't quit either. kill -9 works.
. the dottiness in the availability I reported in this PR.
Should I file separate PRs for these two?

Thomas Klausner <tk>
Tue 25 Oct 2005 09:55:08 AM UTC, comment #3: 

can you uninstall your lablgtk2 and build the last CVS snapshot  http://wwwfun.kurims.kyoto-u.ac.jp/soft/olabl/dist/lablgtk2-20050701.tar.gz
applying the following patch to src/ml_gdkpixbuf.h before.

and then re-build the mldonkey newgui2

Index: src/ml_gdkpixbuf.h
===================================================================
RCS file: /staff2/garrigue/repos/lablgtk/src/ml_gdkpixbuf.h,v
retrieving revision 1.5
diff -u -r1.5 ml_gdkpixbuf.h
--- src/ml_gdkpixbuf.h 3 May 2005 20:50:21 -0000 1.5
+++ src/ml_gdkpixbuf.h 3 Oct 2005 11:03:50 -0000
@@ -2,5 +2,5 @@
 
 #define GdkPixbuf_val(val)       (check_cast(GDK_PIXBUF, val))
 value Val_GdkPixbuf_ (GdkPixbuf *, gboolean);
-#define Val_GdkPixbuf(p)         Val_GdkPixbuf_(p, FALSE)
-#define Val_GdkPixbuf_new(p)     Val_GdkPixbuf_(p, TRUE)
+#define Val_GdkPixbuf(p)         Val_GdkPixbuf_(p, TRUE)
+#define Val_GdkPixbuf_new(p)     Val_GdkPixbuf_(p, FALSE)


su_blanc <su_blanc>
Group Member
Tue 25 Oct 2005 01:11:04 AM UTC, comment #2: 

I tried CVS from an hour ago with the patch, and I got a similar core dump quite quickly:
In callback for signal toggled, uncaught exception: Glib.Critical("GLib", "g_source_remove: assertion `tag > 0' failed")

(process:7580): GLib-CRITICAL (recursed) **: g_source_remove: assertion `tag > 0' failed
aborting...
Abort trap (core dumped)

Not sure how I got that result exactly, but
in particular, I can make mlgui abort in the following way:
1 start mlgui
2 click on "downloads"
3 click on "uploads"
In callback for signal toggled, uncaught exception: Glib.Critical("GLib", "g_source_remove: assertion `tag > 0' failed")

(process:28090): GLib-GObject-CRITICAL (recursed) **: g_object_unref: assertion `object->ref_count > 0' failed
aborting...
Abort trap (core dumped)

Choosing "uploads" before "downloads" is no problem, only the other way round (choosing "uploads" directly after "downloads").

Perhaps unrelated:
I also noticed that mlgui is very CPU hungry during startup, and that the availability bars in "downloads" look dotty -- I'll attach a picture. Also, where's the "autosize" right-click option gone?

Thomas Klausner <tk>
Mon 24 Oct 2005 03:52:32 PM UTC, comment #1: 

It looks like Glib is complaining while we do a 'Timeout.remove id' on a widget destroyed...
That's the only place, i can see, where g_source_remove could be called.
can you apply the patch attached to the last CVS version and tell me if it works?

su_blanc <su_blanc>
Group Member
Thu 06 Oct 2005 12:09:33 PM UTC, original submission:  

When I compile the newgui using lablgtk2-2.4.0 under NetBSD, mlgui is very unstable -- as soon as I try to look at "Downloads" or "Uploads", it aborts. Here's stdout from a run:

2005/10/06 13:29:11 Starting MLDonkey 2.6.4 ...
2005/10/06 13:29:11 Language DE, locale ISO8859-1
2005/10/06 13:29:11 MLDonkey is working in /home/user/.mldonkey
2005/10/06 13:29:11 [DNS] Resolving [XXXXX.XXX] ...
Registered protocol IRC
Use encoding ISO8859-1
Use encoding WINDOWS-1252
Use encoding ISO-8859-15
Use encoding IBM850
Use encoding ISO-8859-1
Use encoding UCS-2
char_width : 7 digit_width : 8
2005/10/06 13:29:14 [DNS] Resolving [localhost] ...
In callback for signal clicked, uncaught exception: Glib.Critical("GLib", "g_source_remove: assertion `tag > 0' failed")

(process:5157): GLib-GObject-CRITICAL (recursed) **: g_object_unref: assertion `object->ref_count >
0' failed
aborting...
Abort trap (core dumped)


For comparison, when compiled with newgui1 and lablgtk-1.2.7, it looks like this:
2005/10/06 14:07:38 Starting MLDonkey 2.6.4 ...
2005/10/06 14:07:38 Language DE, locale ISO8859-1
2005/10/06 14:07:38 MLDonkey is working in /home/user/.mldonkey
2005/10/06 14:07:38 [DNS] Resolving [XXXXXX.XXX] ...
Registered protocol IRC
Message not sent since not connected
Message not sent since not connected
Message not sent since not connected
Unknown action:  menu_save_file
2005/10/06 14:07:51 [DNS] Resolving [localhost] ...
Using protocol 34 for communications
LABEL: [Complex Search]
LABEL: [MP3 Search]
LABEL: [Movie Search]
LABEL: [Album Search]
Message not sent since not connected
Message not sent since not connected
Message not sent since not connected
Message not sent since not connected

Thomas Klausner <tk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #2814:  mlgui2.png added by tk (102KiB - image/png - picture showing the "availability" dottiness)
file #2811:  g_source_remove.patch added by su_blanc (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-26 spiralvoice StatusNone Fixed
    Open/ClosedOpen Closed
2005-10-25 tk Attached File- Added mlgui2.png, #3062
2005-10-24 su_blanc Attached File- Added g_source_remove.patch, #3059
2005-10-09 spiralvoice CategoryGUI GUI GTK2

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code