bugmldonkey, a multi-networks file-sharing client - Bugs: bug #15504, Too many open files for directory...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #15504: Too many open files for directory incoming/files

Submitted by:  Elliot <ellmout>
Submitted on:  Sun 22 Jan 2006 04:39:59 PM UTC  
 
Category:  Core Severity:  3 - Normal
Item Group:  Program malfunction Status:  Fixed
Assigned to:  None Open/Closed:  Closed
Release:  2.7.3 Release:  2.7.3
Operating System:  Linux Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86

( Jump to the original submission)

Tue 04 Apr 2006 11:54:47 AM UTC, comment #12: 

Please check if this bug still is in current CVS version.
You should find a tarball of current CVS in files section of
this project: http://download.berlios.de/pub/mldonkey/spiralvoice/

spiralvoice <spiralvoice>
Project Administrator
Mon 03 Apr 2006 02:16:16 AM UTC, comment #11: 

Patch #5004 could be worth a try, too

pango <mlpango>
Project Member
Wed 22 Mar 2006 08:29:14 PM UTC, comment #10: 

Please test current CVS:

2006/03/06
4950: Close unneeded file descriptors

spiralvoice <spiralvoice>
Project Administrator
Sat 28 Jan 2006 09:09:09 PM UTC, comment #9: 

Removed patch, have to investigate further

spiralvoice <spiralvoice>
Project Administrator
Sat 28 Jan 2006 11:25:52 AM UTC, comment #8: 

What about this patch?
Without it after starting MLDonkey keeps 50 useless fds open of
shared files, with this patch no fd is open for a shared file.

spiralvoice <spiralvoice>
Project Administrator
Sat 28 Jan 2006 10:14:58 AM UTC, comment #7: 

My patch is useless, yes.
But calling Unix32.file_exists creates a file descriptor in Unix32
by using

Unix32.file_exists s =
  try
    exists (create_ro s)

Unix32.create_ro filename = create_diskfile filename false

which is not closed by file_exists

spiralvoice <spiralvoice>
Project Administrator
Sat 28 Jan 2006 01:23:04 AM UTC, comment #6: 

That unix32_exists.patch does nothing; Sys.file_exists is not supposed to open a file descriptor (it uses stat(), see http://camlcvs.inria.fr/cgi-bin/cvsweb/ocaml/byterun/sys.c?rev=HEAD), so you'll just be closing already closed descriptors (which is a noop, thanks to Unix32 for testing that).

@Elliot : mldonkey manages a fixed size pool of descriptors for local files; When the pool is fully used and a descriptor is needed the oldest opened one is automatically closed and reused (FIFO policy). So there's no upper limit to the number of files that can be shared, just efficiency dropping slowly (as more open() and close() will be done).

That bug means that either the number of descriptors needed to computed wrongly from the start, or that there's a descriptors leak somewhere...

pango <mlpango>
Project Member
Fri 27 Jan 2006 10:39:07 AM UTC, comment #5: 

And if you have problems rehashing all your files try this patch:
http://ftp.berlios.de/pub/mldonkey/pango/prevent_reshare_overlaps.patch

spiralvoice <spiralvoice>
Project Administrator
Fri 27 Jan 2006 10:09:29 AM UTC, comment #4: 

Please put all your shared files back into shared dirs and try
the attached patch.

spiralvoice <spiralvoice>
Project Administrator
Mon 23 Jan 2006 12:35:55 AM UTC, comment #3: 

MLDonkey should not open all shared files at once;-)

spiralvoice <spiralvoice>
Project Administrator
Mon 23 Jan 2006 12:04:50 AM UTC, comment #2: 

Toooo much :P
I move some files outside the incoming dir and my Mldonkey is now working perfectly :-)

Maybe a features can check that ?
Like "max_open_files" or "max_share_files"

Elliot <ellmout>
Mon 23 Jan 2006 12:00:36 AM UTC, comment #1: 

How many files do you share?

spiralvoice <spiralvoice>
Project Administrator
Sun 22 Jan 2006 04:39:59 PM UTC, original submission:  

in my mlnet.log :

2006/01/22 16:06:10 incoming/files/tmp_fkaujyy_mld.tmp: Too many open files for directory incoming/files
2006/01/22 16:06:10 [cCO] Options correctly saved
2006/01/22 16:06:10 [cCO] Sources correctly saved
2006/01/22 16:06:10 [cCO] Options backup as .tar.gz correctly saved
2006/01/22 16:06:10 Core stopped

My sysinfo :

MLNet Multi-Network p2p client version 2.7.3.CVS
SCM version info: 2006-01-21 12:55:03
Networks: Global Shares  FileTP  BitTorrent  Donkey
Ocaml version: 3.09.1
Build on: Linux i686 2.6.14.3 (little endian) (Warning: glibc version mismatch, 2.3.6 present on your system, MlDonkey was compiled with 2.3.5)
Configure arguments: /usr/local/share/config.site /usr/local/etc/config.site
Features: threads zlib-1.2.3 bzip2-1.0.3 gd(jpg/png-1.2.8) iconv no-check-bounds

Enabled Networks:  Donkey Overnet Kademlia BitTorrent FileTP
Server usage: enabled
This product includes GeoLite data created by MaxMind, available from http://maxmind.com/
IP blocking enabled: 93832 ranges loaded - optimized to 81770
System info: Linux home.ellmout.net 2.6.14.3 #1 Fri Dec 9 14:07:24 CET 2005 i686
Uptime: 17m 46s - Language: EN - locale: ANSI_X3.4-1968 - UTC offset: +0000
 max_string_length: 16777211 - word_size: 32 - max_array_length: 4194303
 max file descriptors: 1024 - max useable file size: 2^63-1 bits (do the maths ;-p)

Mldonkey works perfectly during 1 or ~2 hours.

I Got this before

2006/01/22 16:04:08 [cShared]: ./incoming/files/ADOBE PHOTOSHOP CS2 RETAIL FRANCAIS PAR D7G6.ISO will not be shared (exception open failed on incoming/files/ADOBE PHOTOSHOP CS2 RETAIL FRANCAIS PAR \
D7G6.ISO: Too many open files)
2006/01/22 16:04:08 [cShared]: ./incoming/files/Desperate.Housewives.S02E11.HDTV.XviD-XOR.avi will not be shared (exception open failed on ./incoming/files/Desperate.Housewives.S02E11.HDTV.XviD-XOR\
.avi: Too many open files)
2006/01/22 16:04:08 [cShared]: ./incoming/files/Album Complet - Manu Chao - Radio Bemba Sound System - Rippe Par Skizo.rar will not be shared (exception open failed on ./incoming/files/Album Comple\
t - Manu Chao - Radio Bemba Sound System - Rippe Par Skizo.rar: Too many open files)
2006/01/22 16:04:08 [cShared]: ./incoming/files/XP Codec Pack 1.2.2.exe will not be shared (exception open failed on ./incoming/files/XP Codec Pack 1.2.2.exe: Too many open files)
2006/01/22 16:04:08 [cShared]: ./incoming/files/VIDiOSuite.exe will not be shared (exception open failed on ./incoming/files/VIDiOSuite.exe: Too many open files)
2006/01/22 16:04:08 [cShared]: ./incoming/files/Kaspersky.Antivirus.Personal.Pro.v5.0.388-FR.zip will not be shared (exception open failed on ./incoming/files/Kaspersky.Antivirus.Personal.Pro.v5.0.\
388-FR.zip: Too many open files)

Elliot <ellmout>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-05-30 spiralvoice StatusNone => Fixed
    Open/ClosedOpen => Closed
2006-01-28 spiralvoice Attached File#3324 => Removed
2006-01-28 spiralvoice Attached File- => Added unix32_exists.patch, #3324
2006-01-28 spiralvoice Attached File#3321 => Removed
2006-01-27 spiralvoice Attached File- => Added unix32_exists.patch, #3321

Back to the top


Powered by Savane 3.5