mldonkey, a multi-networks file-sharing client - Bugs: bug #15959, Assertion fails at startup - all...
You are not allowed to post comments on this tracker with your current authentication level.
bug #15959: Assertion fails at startup - all files lost
Submitter: | Sakari Aaltonen <sakari> | ||
Submitted: | Thu 02 Mar 2006 04:41:47 PM UTC | ||
Category: | Core | Severity: | 5 - Blocker |
Item Group: | Program malfunction | Status: | None |
Assigned to: | None | Open/Closed: | Closed |
Release: | None | Release: | 2.7.3 |
Operating System: | Linux | Binaries Origin: | CVS / Self compiled |
CPU type: | Intel x86 |
Jump to the original submission
Tue 16 May 2006 10:17:50 PM UTC, comment #7: |
spiralvoice <spiralvoice> |
Sat 13 May 2006 07:14:21 PM UTC, comment #6: Forget part of my last entry, please. I must have been cinfused myself when reading "files.ini".
|
Jonas Eckerman <jonas_e_se> |
Wed 10 May 2006 08:28:44 PM UTC, comment #5: Some checking in files.ini seems to indicate that mlnet is confusing two different torrents. More below.
|
Jonas Eckerman <jonas_e_se> |
Wed 10 May 2006 11:29:24 AM UTC, comment #4: Please try the attached patch, it improves the error message
|
spiralvoice <spiralvoice> |
Tue 09 May 2006 07:41:20 PM UTC, comment #3: I had the exact same problem as Sakari with 2.7.3. After upgrading to 2.7.5, the only thing that differs is the characters numbers. The error message now looks like this:
|
Jonas Eckerman <jonas_e_se> |
Wed 22 Mar 2006 08:17:32 PM UTC, comment #2: did you use the "merge" command for some downloads? |
spiralvoice <spiralvoice> |
Thu 02 Mar 2006 04:49:04 PM UTC, comment #1: It seems I cannot attach <files.ini> because, even when compressed, it is over 512K.
|
Sakari Aaltonen <sakari> |
Thu 02 Mar 2006 04:41:47 PM UTC, original submission:
I killed mldonkey for a while to burn a CD-R. I had some 12 files downloading, some of them a week old. When I restarted mldonkey,
|
Sakari Aaltonen <sakari> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-05-18 | spiralvoice | Reassign Item | From group mldonkey, a multi-networks file-sharing client, bugs tracker | To group mldonkey, a multi-networks file-sharing client, patch tracker | |
2006-05-17 | spiralvoice | Severity | 3 - Normal | 5 - Blocker | |
2006-05-10 | jonas_e_se | Attached File | - | Added testresult.txt, #9940 | |
2006-05-10 | spiralvoice | Attached File | - | Added swarming_assert_verbose.patch, #9937 |
Powered by Savane 3.13-bb6a.
Corresponding source code
"It would be better if the second torrent-file got another local name instead of overwriting the one thatäs allready in use."
I could reproduce the error using your good description, thanks.
Trying to fix this is not that easy, inside the .torrent file
is a hard-coded filename which is used by MLDonkey.
Renaming the .torrent file makes this out-of-sync.
Another idea was to put the .torrent into torrents/downloads/<file_id>/file.torrent.
file_id as seen in files.ini is a SHA1 hash of the text content
of the torrent file. Your two .torrent files differ for example
that one .torrent has one file more inside so different file_id
values were produced.
This solution produces the problem that the built-in tracker will
get confused when asked for Dag Vag - Almanacka (1983).torrent:
./torrents/downloads/X34OR7VZKJDR3SL2QXT2BN2H2VXW4VYZ/Dag Vag - Almanacka (1983).torrent
./torrents/downloads/CNJUFHE26BBFTAG3Y4CBWHMDF6AHTCMH/Dag Vag - Almanacka (1983).torrent
This scenario will avoid overwriting a .torrent file in your case.
But the MLDonkey tracker will not know which file to use.
After thinking about it the easiest solution would be to disallow
starting a new BT download when the .torrent file has the same
name than a currently working download, or maybe even also
seeded torrents. As this does happen seldomly (otherwise more
users would have experienced your bug) and its easy to code
without unwanted side-effects I would code this unless you or
others have a better idea to fix this bug.