bugmldonkey, a multi-networks file-sharing client - Bugs: bug #17085, Fix HDD space checks on CFS mounts

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #17085: Fix HDD space checks on CFS mounts

Submitted by:  Samuel Mimram <smimram>
Submitted on:  Tue 11 Jul 2006 07:14:54 PM UTC  
 
Category:  Core Severity:  3 - Normal
Item Group:  Feature request Status:  None
Assigned to:  None Open/Closed:  Closed
Release:  Release:  2.7.7
Operating System:  None Binaries Origin:  Debian package
CPU type:  None

Wed 12 Jul 2006 11:46:29 PM UTC, comment #3: 

Yes, I forgot the patch, here it is...
Please report if it fixes the bug, the patch can then go to CVS.

spiralvoice <spiralvoice>
Project Administrator
Wed 12 Jul 2006 10:29:15 PM UTC, comment #2: 

Thanks a lot spiralvoice for your patch I'll integrate it in the Debian package. Apparently you forgot to attach the other patch, didn't you?

Samuel Mimram <smimram>
Wed 12 Jul 2006 04:44:55 PM UTC, comment #1: 

The hdd_space_check-patch has been introduced 2006/03/19,
this is the first bug report of this kind.
I set up a CFS partition here following
http://gentoo-wiki.com/HOWTO_Encrypt_Your_Home_Directory_Using_CFS#Introduction_to_CFS
and could reproduce the bug. Because of the sensitivity of
MLDonkeys ini file saving procedure IMHO its not a good idea
to create an option to disable DriverInteractive.hdd_check ().

Here is a patch which is a work-around for the CFS-freespace problem:

diff -a -x Root -x Repository -x Tag -x Entries -x Entries.Log -x .svn -x '*.rej' -x '*.orig' -N -r -u ./src/daemon/driver/driv
--- ./src/daemon/driver/driverInteractive.ml    2006-06-27 23:20:28.000000000 +0200
+++ ./src/daemon/driver/driverInteractive.ml    2006-07-12 18:39:02.000000000 +0200
@@ -93,6 +93,7 @@
   let dir_full dir mb =
     match Unix32.diskfree dir with
     | None -> false
+    | Some v when ((Unix32.filesystem dir = "NFS_SUPER_MAGIC") && v = zero) -> false
     | Some v -> v < megabytes mb
   in

CFS filesystems report themselves as NFS_SUPER_MAGIC, if the
freespace is reported as zero on such a partition its ignored
in the future during hdd_space_check. Attached you will find
a patch including the patch above + a cosmetic patch for
unix32 module to prevent a Division_by_zero error in debug_disk command.

spiralvoice <spiralvoice>
Project Administrator
Tue 11 Jul 2006 07:14:54 PM UTC, original submission:  

Hi,

With the last upstream update, checks for minimum free space in the
core/temp directory were introduced. These checks use hard-coded minimum values and they cannot be switched off.

This causes mldonkey-server to refuse to run on filesystems which do not report the free space correctly, e.g. the cryptographic filesystem CFS.

Surely this is actually a bug in the filesystems, but mldonkey should be able to work around it by not enforcing min-free checks.

More info about the Debian bug report can be found at
http://bugs.debian.org/377865

Samuel Mimram <smimram>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by smimram
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-07-14 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker => To group mldonkey, a multi-networks file-sharing client, patch tracker
    2006-07-14 spiralvoice Summaryhdd_free checks cannot be switched off => Fix HDD space checks on CFS mounts
    2006-07-12 spiralvoice Attached File- => Added cfs.patch, #10338
    2006-07-11 smimram Carbon-Copy- => Added 377865@bugs.debian.org

    Back to the top


    Powered by Savane 3.5