bugmldonkey, a multi-networks file-sharing client - Bugs: bug #3296, [enhancement] why not use relative...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #3296: [enhancement] why not use relative refs in HTML output?

Submitter:  Invalid User ID <#18297>
Submitted:  Mon 21 Apr 2003 08:28:14 PM UTC
   
 
Category:  HTTP interface Severity:  3 - Normal
Item Group:  Feature request Status:  None
Assigned to:  None Open/Closed:  Closed
Release:  None Release:  2.04rc1-0
Operating System:  Linux Binaries Origin:  Binary from Savannah
CPU type:  None

Jump to the original submission

Thu 26 May 2005 03:37:08 PM UTC, comment #7: 

That patch doesn't fix this.

Amorphous <amorphous>
Thu 19 May 2005 01:01:04 AM UTC, comment #6: 

Patch #4031 should solve this.

spiralvoice <spiralvoice>
Group administrator
Thu 19 May 2005 12:21:20 AM UTC, comment #5: 

fix fix fix ...

Anonymous
Thu 29 Apr 2004 04:29:16 PM UTC, comment #4: 

Reopened because fixing this would enable the html_mods interface to be used in a frame.

spiralvoice <spiralvoice>
Group administrator
Wed 25 Feb 2004 01:15:32 AM UTC, comment #3: 

Here is some more information about Apache redirection:
http://mldonkey.berlios.de/modules.php?name=Wiki&pagename=ApacheRedirection

spiralvoice <spiralvoice>
Group administrator
Fri 16 May 2003 06:06:48 PM UTC, comment #2: 

Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the first RewriteRule.

Invalid User ID <#18297>
Tue 22 Apr 2003 07:42:29 AM UTC, comment #1: 

Im all for relative links but in the meantime, I use the following rewrite rules to not have to ProxyPass all URLs myself. This will make mldonkey available in /mldonkey on your apache.

RewriteCond      %{REQUEST_URI}           /mldonkey/.*
RewriteRule      .*/(.* ) http://www.my.dom:4080/$1 [P] [L]
# Rewrite the relative URI's mldonkey generates to use the /mldonkey/ prefix so the
# above rewrite rule can catch it.
RewriteCond      %{HTTP_REFERER}   .*apache.my.dom/mldonkey.*
RewriteRule      .*/(.*) http://apache.my.dom/mldonkey/$1 [R]

Invalid User ID <#18310>
Mon 21 Apr 2003 08:28:14 PM UTC, original submission:  

Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be sufficient to access the mldonkey web interface. As it is, the start frame contains requests to path-absolute URLs like e.g. /commands.html, so the following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP requests anyway from any relative path it sees in HTML, you wouldn't even have to change the HTTP request parsing code. Just drop the leading slashes from the output ;-)

Invalid User ID <#18297>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 10 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-07-08 spiralvoice Reassign ItemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, task tracker
2005-05-26 amorphous Open/ClosedClosed Open
2005-05-26 amorphous StatusFixed None
2005-05-19 spiralvoice StatusNone Fixed
    Open/ClosedOpen Closed
2005-03-16 amorphous Item GroupNone Feature request
2004-04-29 spiralvoice StatusWont Fix None
    Open/ClosedClosed Open
2004-02-25 spiralvoice StatusNone Wont Fix
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code