bugmldonkey, a multi-networks file-sharing client - Bugs: bug #9817, Friends filelist is reasked too...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9817: Friends filelist is reasked too often

Submitter:  spiralvoice <spiralvoice>
Submitted:  Fri 30 Jul 2004 02:56:17 AM UTC
   
 
Category:  eDonkey-Plugin Severity:  4 - Important
Item Group:  Program malfunction Status:  Wont Fix
Assigned to:  None Open/Closed:  Closed
Release:  2-5-16 Release: 
Operating System:  None Binaries Origin:  CVS / Self compiled
CPU type:  None

Thu 19 May 2005 02:05:09 PM UTC, comment #4: 

Problem was not present in 2.5.30.15

spiralvoice <spiralvoice>
Group administrator
Tue 10 Aug 2004 08:40:30 AM UTC, comment #3: 

client_last_filereqs is not used anymore, so it won't even be saved in friends.ini in 2.5.27. Indeed, client_next_view_files could be saved, but from my point of view, it is better to always have a view of your friends files, and not wait for 6 hours after a restart if you had just asked before the stop. Anyway, I will try to reproduce the bug at home tonight.

mldonkey admin <mldonkey>
Group administrator
Mon 09 Aug 2004 03:39:00 PM UTC, comment #2: 

Please have a look at donkeyClient.ml, in line 650 this should happen:
    c.client_last_filereqs <- last_time ();

client_last_filereqs is saved in friends.ini, but is IMHO always zero. Correct me if I am wrong but I think a whole code segment is commented out in donkeyClient.ml, from line 676-710, so client_last_filereqs is never filled with a value.

The other part dealing with that is in donkeyComplexOptions.ml, and also commented out:

(* Is it really useful ? I don't think so. It is only used when restarting
the client several times, which is not that current...

  (try
     let last_filereqs =
       (min (get_value "client_last_filereqs" value_to_float)
          (BasicSocket.last_time ())) in
       l.client_last_filereqs <- last_filereqs
   with _ -> ()); *)

spiralvoice <spiralvoice>
Group administrator
Mon 09 Aug 2004 02:46:53 PM UTC, comment #1: 

I will try to reproduce this bug, but I'm not completely convinced by the explanation: friends are supposed to be kept in a list corresponding to the option, and thus, the "client" structure is never removed, even when converted to source and should be used when converted back from source, so that the field client_next_view_files should be kept from one connection to the other.

mldonkey admin <mldonkey>
Group administrator
Fri 30 Jul 2004 02:56:17 AM UTC, original submission:  

Core does not look at our self-proposed time limit of six hours.
Pango wrote about it:
"the problem was that client_next_view_files was discarded when the client was converted to source, so the timer couldn't be remembered between connections.
So fixing it will have a memory cost (adding that timer to sources), hopefully acceptable."
More information about it:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=2689

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-05-19 spiralvoice StatusNone Wont Fix
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code