grep - Patches: patch #3644, --initial-tab and 3 newly...
You are not allowed to post comments on this tracker with your current authentication level.
patch #3644: --initial-tab and 3 newly colorized items
Submitter: | None | ||
Submitted: | Fri 14 Jan 2005 10:43:27 AM UTC | ||
Category: | None | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | charles_levert | Originator Email: | -email is unavailable- |
Open/Closed: | Closed |
Jump to the original submission
Tue 21 Jun 2005 04:34:09 PM UTC, comment #21: |
Charles Levert <charles_levert> |
Thu 24 Feb 2005 09:04:39 AM UTC, comment #20: This latest patch (charles2a0.patch) is a trimmed down version that relies on the following hierarchy of smaller patches to have already been applied:
|
Charles Levert <charles_levert> |
Wed 23 Feb 2005 05:09:49 AM UTC, comment #19: This latest patch (charles1ux.patch) adds the modifications to -o/--only-matching that I proposed on the bug-grep mailing list:
|
Charles Levert <charles_levert> |
Tue 22 Feb 2005 08:40:10 PM UTC, comment #18: This latest patch (charles1tx.patch) is now based on cvs version 1.93 (latest) of src/grep.c. It changes the following in this file in function prline(), in chunks of code that the patch already touched anyway.
|
Charles Levert <charles_levert> |
Mon 21 Feb 2005 03:13:52 PM UTC, comment #17: This latest patch (charles1sx.patch) contains an obvious simplification over the previous one for the empty "mt" capability case. This is actually a big improvement, since it completely skips the costly calls to (*execute)(), as well as to xmalloc() and tolower() if match_icase, in this eventuality.
|
Charles Levert <charles_levert> |
Mon 21 Feb 2005 02:16:37 PM UTC, comment #16: Hi, Juri. I am glad to see that the patch finds useful applications that use it for its structuring properties.
|
Charles Levert <charles_levert> |
Mon 21 Feb 2005 10:42:30 AM UTC, comment #15: Hi, Charles. Half year ago I modified GNU Emacs grep.el to use grep color markers to get the exact positions of grep matches for highlighting them in Emacs. I just tried your latest patch, and it works very well. But since now it prints more control sequences, it doesn't work nicely with grep.el. I have already tried to adjust grep.el to work with your changes, and I see no problems with your patch. I even managed to use fn, nu, ml and cl to get more precise positions of file names and line numbers, defined not by heuristic rules used currently in grep.el, but by exact positions reported via color marker by your patch.
|
Juri Linkov <jurta> |
Sun 20 Feb 2005 02:31:24 AM UTC, comment #14: This latest patch (charles1qx.patch) adds two GREP_COLORS capabilities: "ml" and "cx" for whole matching lines and for context lines, respectively. Both default to the empty string, such that a "\33[m" (SGR reset) will be output at the beginning of those lines. It is thus up to the user/packager/distributor to define them to something else as part of a whole consistent color theme (including default foreground and background terminal colors). This is because it is too difficult to come up with good generic settings for these, because of their nature.
|
Charles Levert <charles_levert> |
Fri 18 Feb 2005 02:36:16 PM UTC, comment #13: I will take a look at this. Before going any further, should we carry the discussion there (bug #12019), or should that bug be closed in favor of centralizing all discussions about colorizing here (patch #3644)?
|
Charles Levert <charles_levert> |
Fri 18 Feb 2005 01:28:34 PM UTC, comment #12: Charles, are you willing to enhance the patch to implement the wish expressed in bug #12019?
|
Stepan Kasal <kasal> |
Fri 28 Jan 2005 12:28:29 AM UTC, comment #11: This latest patch (charles1ox.patch) replaces the "cl" boolean capability with the opposite-semantics "ne" (no EL) boolean capability, thereby changing the default behavior (now to print an EL to Right ("\33[K") with every SGR_END).
|
Charles Levert <charles_levert> |
Thu 27 Jan 2005 11:00:42 AM UTC, comment #10: Charles, thank you for the demonstration script, it indeed explains why \e[m\e[K is needed after each match.
|
Stepan Kasal <kasal> |
Wed 26 Jan 2005 08:00:37 PM UTC, comment #9: I have attached the "sgreol.sh" script to help anyone study and understand the back_color_erase issue with SGR (the "\33[m" stuff) first identified in bug #11022. This is what justifies the "cl" capability for GREP_COLORS.
|
Charles Levert <charles_levert> |
Mon 24 Jan 2005 04:34:04 AM UTC, comment #8:
|
Charles Levert <charles_levert> |
Mon 17 Jan 2005 05:52:53 PM UTC, comment #7:
|
Charles Levert <charles_levert> |
Mon 17 Jan 2005 08:15:03 AM UTC, comment #6:
|
Charles Levert <charles_levert> |
Sat 15 Jan 2005 11:21:19 PM UTC, comment #5:
|
Charles Levert <charles_levert> |
Sat 15 Jan 2005 01:17:47 PM UTC, comment #4:
|
Charles Levert <charles_levert> |
Sat 15 Jan 2005 01:15:43 PM UTC, comment #3:
|
Charles Levert <charles_levert> |
Sat 15 Jan 2005 01:44:45 AM UTC, comment #2:
|
Charles Levert <charles_levert> |
Fri 14 Jan 2005 01:47:28 PM UTC, comment #1:
|
Charles Levert <charles_levert> |
Fri 14 Jan 2005 10:43:27 AM UTC, original submission:
option (both invocations are
"--color" is in effect.
|
Anonymous |
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 25 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-06-21 | charles_levert | Status | None | Done | |
Assigned to | None | charles_levert | |||
Open/Closed | Open | Closed | |||
2005-06-13 | julianfoad | Dependencies | Removed dependency from patch #3801 | - | |
2005-04-28 | charles_levert | Dependencies | - | patch #3801 is dependent | |
2005-04-28 | charles_levert | Dependencies | - | bugs #11022 is dependent | |
2005-04-12 | julianfoad | Dependencies | - | Depends on patch #3771 | |
Dependencies | - | Depends on patch #3770 | |||
Dependencies | - | Depends on patch #3769 | |||
Dependencies | - | Depends on patch #3768 | |||
Dependencies | - | Depends on patch #3767 | |||
2005-02-24 | charles_levert | Attached File | - | Added charles2a0.patch, #4231 | |
2005-02-23 | charles_levert | Attached File | - | Added charles1ux.patch, #4220 | |
2005-02-22 | charles_levert | Attached File | - | Added charles1tx.patch, #4219 | |
2005-02-21 | charles_levert | Attached File | - | Added charles1sx.patch, #4214 | |
2005-02-21 | charles_levert | Attached File | - | Added charles1rx.patch, #4213 | |
2005-02-20 | charles_levert | Attached File | - | Added charles1qx.patch, #4203 | |
2005-02-18 | kasal | Dependencies | - | bugs #12019 is dependent | |
2005-01-28 | charles_levert | Attached File | - | Added charles1ox.patch, #4102 | |
2005-01-26 | charles_levert | Attached File | - | Added sgreol.sh, #4097 | |
2005-01-24 | charles_levert | Attached File | - | Added charles1mx.patch, #4084 | |
2005-01-17 | charles_levert | Attached File | - | Added charles1kx.patch, #4051 | |
2005-01-17 | charles_levert | Attached File | - | Added charles1jx.patch, #4048 | |
2005-01-15 | charles_levert | Attached File | - | Added charles1ix.patch, #4044 | |
2005-01-15 | charles_levert | Attached File | - | Added grep.1.diff.charles1hx, #4042 |
Powered by Savane 3.13-caa5.
Corresponding source code
Reworked version part of CVS commit of revisions 1.106, 1.107, 1.108, 1.109, and 1.110 of "src/grep.c". Also revisions 1.53 and 1.54 of "doc/grep.texi" and revisions 1.30 and 1.31 of "doc/grep.1".
Only patch #3767 was not really integrated into this.