patchMHonArc - Patches: patch #5730, Small bug/type fix

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5730: Small bug/type fix

Submitter:  None
Submitted:  Thu 08 Feb 2007 10:31:20 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed

Discussion locked!

Mon 03 Jan 2011 06:46:03 AM UTC, comment #2: 

Fixes commited into repository.  Item being tracked
under bug #32032.

Earl Hood <ehood>
Group administrator
Sun 11 Feb 2007 03:09:52 PM UTC, comment #1: 

Hi, I found another problem with MHonArc 2.6.16.

The following lines are quoted from mhdb.pl:
----------------------------------------------------------------------
unless ($readmail::TextDefCharset ne 'us-ascii') {
    print_var($db,'readmail::TextDefCharset',
  \$readmail::TextDefCharset);
}
----------------------------------------------------------------------
With this logic, charsets other than 'us-ascii' are never saved in
the database file as the value of 'readmail::TextDefCharset'. This
doesn't make sense.

I noticed that the operator 'ne' on the first line was formerly 'eq'
and changed at:
http://www.mhonarc.org/cgi-bin/viewcvs.cgi/mhonarc/MHonArc/lib/mhdb.pl.diff?r1=2.39&r2=2.40
about a year ago.

My guess is that this change from 'eq' to 'ne' was just an unintentional
accident and is still ment to be 'eq'. Isn't it?

Regards,

Anonymous
Thu 08 Feb 2007 10:31:20 AM UTC, original submission:  

Hi, thank you for nice program.

Following is a patch for MHonArc 2.6.16. It fixes a bug that
some of the TextEncode related resources are not saved in the
database file. It also corrects minor typos in comments and
documents.

Regards,

* lib/mhdb.pl~ Wed Dec 21 06:28:15 2005
--- lib/mhdb.pl Thu Feb  8 08:36:14 2007
*************
* 113,121 **
      print_var($db,'readmail::TextEncode',
      \$readmail::TextEncode);
      print_var($db,'readmail::TextEncoderFunc',
!     \$readmail::TextEncode);
!     print_var($db,'readmail::TextEncodeSrc',
!     \$readmail::TextEncode);
  }
  unless ($IsDefault{'MIMEDECODERS'} && !$SaveMIMEDecoders) {
      print_var($db,'SaveMIMEDecoders', \$_true);
--- 113,121 ----
      print_var($db,'readmail::TextEncode',
      \$readmail::TextEncode);
      print_var($db,'readmail::TextEncoderFunc',
!     \$readmail::TextEncoderFunc);
!     print_var($db,'readmail::TextEncoderSrc',
!     \$readmail::TextEncoderSrc);
  }
  unless ($IsDefault{'MIMEDECODERS'} && !$SaveMIMEDecoders) {
      print_var($db,'SaveMIMEDecoders', \$_true);
* lib/readmail.pl~ Wed Dec 21 05:54:50 2005
--- lib/readmail.pl Thu Feb  8 08:37:07 2007
*************
* 244,253 **
      unless defined($TextEncode);
  ##  Text encoding function.
  $TextEncoderFunc = undef
!     unless defined($TextEncodingFunc);
  ##  Text encoding function source file.
  $TextEncoderSrc = undef
!     unless defined($TextEncodingSrc);
 
  ##  Prefilter function
  $TextPreFilter  = undef
--- 244,253 ----
      unless defined($TextEncode);
  ##  Text encoding function.
  $TextEncoderFunc = undef
!     unless defined($TextEncoderFunc);
  ##  Text encoding function source file.
  $TextEncoderSrc = undef
!     unless defined($TextEncoderSrc);
 
  ##  Prefilter function
  $TextPreFilter  = undef
*************
* 450,456 **
  ## MAILread_body() parses a MIME message body.
  ## Usage:
  ##   ($data, @files) =
! ##       MAILread_body($fields_hash_ref, $body_date_ref);
  ##
  ## Parameters:
  ##   $fields_hash_ref
--- 450,456 ----
  ## MAILread_body() parses a MIME message body.
  ## Usage:
  ##   ($data, @files) =
! ##       MAILread_body($fields_hash_ref, $body_data_ref);
  ##
  ## Parameters:
  ##   $fields_hash_ref
* examples/mhasiteinit.pl~ Thu Jun  2 11:12:30 2005
--- examples/mhasiteinit.pl Thu Feb  8 08:20:24 2007
*************
* 32,38 **
  ##---------------------------------------------------------------------------
  ##  The following are callback functions that you can register
  ##  for all instances of mhonarc.  See the Application Programming
! ##  Interface appendix of the documentation for a complate list
  ##  of available callbacks and how they are invoked.
 
  #require 'head_routine.pl'; # make sure source of routine is loaded
--- 32,38 ----
  ##---------------------------------------------------------------------------
  ##  The following are callback functions that you can register
  ##  for all instances of mhonarc.  See the Application Programming
! ##  Interface appendix of the documentation for a complete list
  ##  of available callbacks and how they are invoked.
 
  #require 'head_routine.pl'; # make sure source of routine is loaded
* guides/performance.html~ Sat Jun 10 11:42:58 2006
--- guides/performance.html Thu Feb  8 19:13:33 2007
*************
* 278,284 **
  <h3><a name="mimefilters">Don't use certain MIMEFILTERS filters options</a></h3>
 
  <p>
! <a href="../resource/mimefilters.html">MIMEFILTERS</a> is used to
  register filters for media-types.  Many of the filters provided with
  MHonArc support a myriad of options to customize their behavior.
  However, some of these options increase processing overhead.  The
--- 278,284 ----
  <h3><a name="mimefilters">Don't use certain MIMEFILTERS filters options</a></h3>
 
  <p>
! <a href="../resources/mimefilters.html">MIMEFILTERS</a> is used to
  register filters for media-types.  Many of the filters provided with
  MHonArc support a myriad of options to customize their behavior.
  However, some of these options increase processing overhead.  The
*************
* 378,384 **
  required when an archive is first created versus when it is updated.
  </p>
  <p>If you specify resource settings every time,
! disable <a href="../resources/saversource.html">SAVERESOURCES</a>
  to avoid the unnecessary saving of resource settings to the
  <a href="../resources/dbfile.html">database</a>.
  </p>
--- 378,384 ----
  required when an archive is first created versus when it is updated.
  </p>
  <p>If you specify resource settings every time,
! disable <a href="../resources/saveresources.html">SAVERESOURCES</a>
  to avoid the unnecessary saving of resource settings to the
  <a href="../resources/dbfile.html">database</a>.
  </p>

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ehood (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-01-03 ehood StatusNone Done
        Open/ClosedOpen Closed
        Discussion LockNone Locked

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code