patchAVR Downloader/UploaDEr - Patches: patch #6188, avrdude should make 10...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6188: avrdude should make 10 synchronization attempts instead of just one

Submitter:  None
Submitted:  Thu 06 Sep 2007 02:33:23 AM UTC
   
 
Category:  None Priority:  7 - High
Status:  Duplicate Privacy:  Public
Assigned to:  None Originator Email:  -email is unavailable-
Open/Closed:  Closed

Thu 06 Sep 2007 05:10:58 AM UTC, comment #1: 

Duplicate for patch #5708.

Sorry for not yet processing your original request.  There was
no deliberate decision to not have it, otherwise, the original
patch tracker item would have been closed (including a comment
about the reasoning).  It was simply lack of time, and version
5.4 was due for other reasons, so it was prepared just with the
state CVS was in by that time.

Btw.:

> To comply with GPL license we had to publish our changed
> version of avrdude code on SourceForge


Well, that's not strictly necessary to do it that way.  GPL
only requires that you give your changes away under the same
conditions as the original software upon request, and that
you are explaining this right to those you are giving your
modified version to.  There has been a GPL long before the
invention of sourceforge.net and savannah.nongnu.org. ;-)
So you are fully compliant as long as you grant everyone
the right to get the sources, and it's considered OK to get
them just the patch needed -- so simply refering to the
original patch tracker item (that contains a downloadable
version of the patch) will/would do as well.

Joerg Wunsch <joerg_wunsch>
Group administrator
Thu 06 Sep 2007 02:33:23 AM UTC, original submission:  

We have suggested the following patch (original number 5708) well before the release of version 5.4 of avrdude and it wasn't included in it. We are sure that you have good reasons for your decision, but we'd like to ask you to reconsider. To comply with GPL license we had to publish our changed version of avrdude code on SourceForge (https://sourceforge.net/projects/avrdude5-3-1) and after about a week 21 downloads were made, indicating people's interest. We feel a bit ridiculous having to publish separately what mostly is your code with a tiny change, and for this reason we submit the proposed patch again.

The bootloader we've developed is active during 30 milliseconds after reset. During that window of time it needs to synchronize with avrdude. To achieve that, it outputs a character that causes
stk500_getsync() to fail, thus causing avrdude to make another
synchronization attempt and then the handshake occurs. To make that possible we need more than one synchronization attempt.

Our scenario:
1)avrdude runs and tries to sync with STK500 programmer (bootloader)
2)device reset, bootloader runs and outputs a NULL character
3)avrdude fails synchronizing and makes another attempt
4)synchronization succeeds

We don't see any negative effects of this patch on existing STK500 users.





Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #13885:  stk500.c added by None (29KiB - text/plain - See change in function stk500_getsync in file stk500.c and in diff.txt file attached )
file #13886:  diff.txt added by None (801B - text/plain - See change in function stk500_getsync in file stk500.c and in diff.txt file attached )
file #13887:  stk500_orig.c added by None (28KiB - text/plain - See change in function stk500_getsync in file stk500.c and in diff.txt file attached )

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-09-06 joerg_wunsch StatusNone Duplicate
        Open/ClosedOpen Closed
    2007-09-06 None Attached File- Added stk500.c, #13885
        Attached File- Added diff.txt, #13886
        Attached File- Added stk500_orig.c, #13887

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code