Mon 19 Nov 2007 06:45:48 AM UTC, comment #4:
OK, looked at the points in the diff, some responses:
> 1) Makefile: changes needed to compile on Gentoo linux
Not nessecary, just pass the right CFLAGS to make:
make CFLAGS="-I/usr/include/lzx_compress"
> 2) hhm.c line 152: window size according to
> http://www.speakeasy.org/~russotto/chm/chmformat.html
Ah, why the change from 15 to 16 and from 1 to 2 though?
> 7) line 700: 0 value crashes xchm, 1 seems to work OK
Known bug in chmlib, not sure of the correct fix yet, nor what that field is supposed to be for. Have asked the chmlib author to fix it.
The rest seem to be for creating the internal files. I'd prefer to do that in a development branch. I'll be moving my CHM related projects from CVS to git to make this easier. That will happen sometime this week.
> 3) hhm.c line 214: added buffer slot to allow adding a "file"
> which is actually in memory, not on disk
Looks useful for the development branch.
> 4) line 341: added 0 for new slot in item_t structs
Should use NULL for pointers, btw.
> 12) line 1329: new functions for in-memory "files"
Don't need to copy stuff from chmspec to the source code, it is enough to just link to the appropriate section in chmspec.
|