patchHTML Help Maker - Patches: patch #6268, I've managed to construct a valid...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6268: I've managed to construct a valid chm file

Submitted by:  Wayne Richards <wrichards>
Submitted on:  Wed 14 Nov 2007 04:59:17 PM UTC  
 
Category: NonePriority: 5 - Normal
Status: In ProgressPrivacy: Public
Assigned to: Paul Wise <pabs>Open/Closed: Open

Mon 03 Dec 2007 05:24:37 AM UTC, comment #5:

I've converted the hhm CVS repository to git (sorry I took so long), as git is a distributed version control system, this will make it easier to collaborate on this. More git info at http://git.or.cz/

Paul Wise <pabs>
Project AdministratorIn charge of this item.
Mon 19 Nov 2007 06:45:48 AM UTC, comment #4:

OK, looked at the points in the diff, some responses:

> 1) Makefile: changes needed to compile on Gentoo linux


Not nessecary, just pass the right CFLAGS to make:

make CFLAGS="-I/usr/include/lzx_compress"

> 2) hhm.c line 152: window size according to
> http://www.speakeasy.org/~russotto/chm/chmformat.html


Ah, why the change from 15 to 16 and from 1 to 2 though?

> 7) line 700: 0 value crashes xchm, 1 seems to work OK


Known bug in chmlib, not sure of the correct fix yet, nor what that field is supposed to be for. Have asked the chmlib author to fix it.

The rest seem to be for creating the internal files. I'd prefer to do that in a development branch. I'll be moving my CHM related projects from CVS to git to make this easier. That will happen sometime this week.

> 3) hhm.c line 214: added buffer slot to allow adding a "file"
> which is actually in memory, not on disk


Looks useful for the development branch.

> 4) line 341: added 0 for new slot in item_t structs


Should use NULL for pointers, btw.

> 12) line 1329: new functions for in-memory "files"


Don't need to copy stuff from chmspec to the source code, it is enough to just link to the appropriate section in chmspec.

Paul Wise <pabs>
Project AdministratorIn charge of this item.
Fri 16 Nov 2007 02:06:14 AM UTC, comment #3:

By annotate, I just mean explain why the patches are needed. You can do that by either putting a comment here, or adding a line or two to the top of the patch files.

Paul Wise <pabs>
Project AdministratorIn charge of this item.
Fri 16 Nov 2007 01:06:22 AM UTC, comment #2:

I have to apologize, Paul--I'm a complete rookie when it comes to
using diff & patch. I couldn't figure out how to annotate the
diffs. Does this mean hand-editing the diff file? If so, I need
some guidance on making changes which don't throw patch off.

Wayne

Wayne Richards <wrichards>
Thu 15 Nov 2007 03:28:19 AM UTC, comment #1:

Please do the following:

  • update to the current cvs
  • rediff with the unified format (using diff -u)
  • split the patch out into individual patches for each issue you found, and annotate the patches with information about what they are for
Paul Wise <pabs>
Project AdministratorIn charge of this item.
Wed 14 Nov 2007 04:59:17 PM UTC, original submission:

With some tweaks (see hhm.diff) and some pre-packaged internal files (see test.tar.gz), I was able to produce a working chm file. Using the already-formated internal files (#STRINGS, #TOPICS, ...), I'm able to break the problem into smaller pieces. For example, "/#IDXHDR" was originally part of the test dir, but is now inserted by hhm.

I'd love to get chm output & hhp input going if you'd like some help.

Wayne

Wayne Richards <wrichards>

 

Attached Files
file #14419:  hhm.diff added by wrichards (11KiB - text/plain - unified format, with some comments at the top)
file #14392:  hhm.diff added by wrichards (11KiB - text/x-diff)
file #14393:  test.tar.gz added by wrichards (5KiB - application/x-tgz)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pabs (Posted a comment)
  • -unavailable- added by wrichards (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 03 Dec 2007 05:24:37 AM UTCpabsStatusNone=>In Progress
    Fri 16 Nov 2007 09:14:08 PM UTCwrichardsAttached File-=>Added hhm.diff, #14419
    Thu 15 Nov 2007 03:28:19 AM UTCpabsAssigned toNone=>pabs
    Wed 14 Nov 2007 04:59:17 PM UTCwrichardsAttached File-=>Added hhm.diff, #14392
      Attached File-=>Added test.tar.gz, #14393

    Back to the top


    Powered by Savane 3.1-cleanup1