patchGNU Autoconf Archive - Patches: patch #7042, AX_CHECK_ICU should set...

 
 

patch #7042: AX_CHECK_ICU should set ICU_CPPFLAGS

Submitter:  Neil Mayhew <neil_mayhew>
Submitted:  Tue 22 Dec 2009 01:09:46 AM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 25 Dec 2009 06:27:12 PM UTC, comment #1: 

Hi Neil,

thank you for submitting this patch. It has been applied (after some minor updating) to the Archive in commit 09e08cefc797ae3dfdfbdb7685d2373f02d186f8.

Take care,
Peter

Peter Simons <simons>
Group administrator
Tue 22 Dec 2009 01:09:46 AM UTC, original submission:  

This macro uses the icu-config utility which treats CPPFLAGS separately from CFLAGS and CXXFLAGS. Clients should be able to obtain the value of CPPFLAGS, which is not currently possible. This patch fixes that.

Note that this behavior is slightly different from PKG_CHECK_MODULES, since the underlying pkg-config doesn't distinguish between CFLAGS and CPPFLAGS. Using CFLAGS instead of CPPFLAGS with icu-config leads to problems, such as header files not found, and compilation errors since icu has its own slightly quirky ideas about what kind of strict warnings should be used, even though these are not required for using the ICU headers.

Clients should typically use ICU_CPPFLAGS rather than ICU_CFLAGS or ICU_CXXFLAGS if they just want to be able to find headers.

Neil Mayhew <neil_mayhew>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #19334:  ac_check_icu.m4.patch added by neil_mayhew (917B - application/octet-stream - Implement ICU_CPPFLAGS)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by simons (Author of ax_check_icu)
  • -email is unavailable- added by neil_mayhew (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-12-27 simons Open/ClosedOpen Closed
    2009-12-25 simons StatusNone Done
        Assigned toNone simons
        Carbon-Copy- Added akos maroy <darkeye@tyrell.hu>
    2009-12-22 neil_mayhew Attached File- Added ac_check_icu.m4.patch, #19334

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code