patchGNU Autoconf Archive - Patches: patch #7048, Autoconf macro file for the Google...

 
 

patch #7048: Autoconf macro file for the Google V8 javascript engine

Submitter:  None
Submitted:  Wed 23 Dec 2009 11:48:04 PM UTC
   
 
Priority:  5 - Normal Status:  Postponed
Assigned to:  simons Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 05 Jan 2010 01:05:11 PM UTC, comment #2: 

When the points brought up in the review have been addressed, please re-open this entry (or submit a new one) as you see fit.

Peter Simons <simons>
Group administrator
Sun 27 Dec 2009 11:05:44 AM UTC, comment #1: 

Hi Graham,

thank you very much for making the result of your efforts available to everyone as free software.

There are a few minor issues that should be addressed before AX_LIB_V8 is included in the Autoconf Archive distribution. Peter Johansson pointed out that Autoconf 2.65 generates a number of warnings when processing your macro with '-Wall' enabled. He wrote:

----------------------------------------------------------------------

Most of [the warnings] are about obsolete macros such as AC_HELP_STRING and AC_TRY_COMPILE. IMHO it would be nice if new macros gave no warnings. Many people are checking the archive to learn how to write macros.

The use of AC_TRY_RUN is more serious. The modern version, AC_RUN_IFELSE, takes a fifth argument about what to do when cross-compiling. Here, the fifth argument is left empty, which implies configure will halt with an error message when cross-compiling. I wonder if that is on purpose.

These are the warnings I get with -Wall:

configure.ac:5: warning: The macro `AC_HELP_STRING' is obsolete.
configure.ac:5: You should run autoupdate.
../../lib/autoconf/general.m4:209: AC_HELP_STRING is expanded from...
v8.m4:28: AX_LIB_V8 is expanded from...
configure.ac:5: the top level
configure.ac:5: warning: The macro `AC_TRY_COMPILE' is obsolete.
configure.ac:5: You should run autoupdate.
../../lib/autoconf/general.m4:2581: AC_TRY_COMPILE is expanded from...
configure.ac:5: warning: The macro `AC_TRY_LINK' is obsolete.
configure.ac:5: You should run autoupdate.
../../lib/autoconf/general.m4:2654: AC_TRY_LINK is expanded from...
configure.ac:5: warning: The macro `AC_TRY_RUN' is obsolete.
configure.ac:5: You should run autoupdate.
../../lib/autoconf/general.m4:2731: AC_TRY_RUN is expanded from...
configure.ac:5: warning: AC_RUN_IFELSE called without default to allow
cross compiling
../../lib/autoconf/general.m4:2715: AC_RUN_IFELSE is expanded from...

----------------------------------------------------------------------

Also, it appears that AX_LIB_V8 includes a lot of intelligence concerned with comparing version numbers. Is it possible that this code could be simplified a lot by re-using AX_COMPARE_VERSION?

Take care,
Peter

Peter Simons <simons>
Group administrator
Wed 23 Dec 2009 11:48:04 PM UTC, original submission:  

Attached file is an m4 file for using the Google V8 engine with your projects. To use the macro, simply insert
AX_LIB_V8
into your configure.ac.

Optionally you can specify the minimum required version (defaults to 2.0.5.2 - current version as of writing the macro), and some code to execute on success or failure:
AX_LIB_V8([version], [on success], [on failure])

If successful, the values V8_CPPFLAGS and V8_LDFLAGS will be set as required, and the HAVE_V8 value will be defined.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #19347:  v8.m4 added by None (4KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-05 simons StatusIn Progress Postponed
        Open/ClosedOpen Closed
    2009-12-24 simons StatusNone In Progress
        Assigned toNone simons
    2009-12-23 None Attached File- Added v8.m4, #19347

    Back to the top

    Powered by Savane 3.13-0329.
    Corresponding source code