patchAVR Downloader/UploaDEr - Patches: patch #7792, Extends libelf header checks to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7792: Extends libelf header checks to libelf/libelf.h

Submitter:  Hannes Weisbach <hweisbach>
Submitted:  Wed 13 Jun 2012 08:40:33 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  joerg_wunsch Open/Closed:  Closed

Mon 03 Sep 2012 12:13:57 PM UTC, comment #1: 

I've already committed that some time ago.

Joerg Wunsch <joerg_wunsch>
Group administrator
Wed 13 Jun 2012 08:40:33 PM UTC, original submission:  

Using MacPorts under OS X 10.6.8 (and I believe this applies to any version of OS X), the header files for the libelf package are installed in $prefix/libelf/libelf.h. So the configure script checks first, if it can link against libelf, which succeeds, since the library is located in $prefix/lib. After that, configure checks for libelf.h - which is not found.
My patch adds looking for libelf.h and libelf/libelf.h. fileio.c, the only file which includes libelf.h was edited accordingly to include either libelf.h or libelf/libelf.h - which ever was found.
I should say, I have no experience with autoconf and I may have taken the wrong approach here. Maybe an autoconf-wiz knows how to handle this situation appropriately.

The only remaining problem is, that code depending on HAVE_LIBELF requires actually HAVE_LIBELF_H, because it uses declarations (types, functions) from that file. I admit, having the library but not the header file might be a rare corner case, but I thought I should mention it anyway.

Best regards,
Hannes

Hannes Weisbach <hweisbach>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #26021:  libelf_h.patch added by hweisbach (722B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by hweisbach (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-09-03 joerg_wunsch StatusNone Done
        Assigned toNone joerg_wunsch
        Open/ClosedOpen Closed
    2012-06-13 hweisbach Attached File- Added libelf_h.patch, #26021

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code