patchGNU Octave - Patches: patch #8997, Add function to export profiles as...

 
 

patch #8997: Add function to export profiles as HTML

Submitter:  Daniel Kraft <domob>
Submitted:  Mon 09 May 2016 06:28:18 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 02 Jun 2016 04:59:00 PM UTC, comment #7: 

I added a bit more to the docs about Octave coding guidelines in this cset (http://hg.savannah.gnu.org/hgweb/octave/rev/adf3473323a7).

Rik <rik5>
Group administrator
Thu 02 Jun 2016 02:59:35 PM UTC, comment #6: 

We're trying to document our standards more, but I fear that the information is still too hard to find.  The bit about '#' and '##' for comments is in Appendix C : Tips and Standards.  The rest of the coding tips for Octave m-files are in Appendix D.5.

Rik <rik5>
Group administrator
Thu 02 Jun 2016 02:56:49 PM UTC, comment #5: 

Hi Daniel. The Octave coding conventions are derived from the GNU coding standards (https://www.gnu.org/prep/standards/), probably with a few of our own adaptations and conventions thrown in. Looks like many of the things Rik fixed are project conventions (like using print_usage only for number of arguments, always leading error messages with the name of the function). I can't say these are well documented, I've probably "absorbed" most of them just by reviewing other Octave functions and getting a hang of the common idioms and patterns used.

Mike Miller <mtmiller>
Group Member
Thu 02 Jun 2016 11:46:57 AM UTC, comment #4: 

Thanks Rik!  Is there a document describing these stylistic guidelines?  I only found a page in the manual, but that is rather short and does not include any information about the things you changed at all (as far as I have seen).

Daniel Kraft <domob>
Wed 01 Jun 2016 06:38:17 PM UTC, comment #3: 

I pushed Daniel's profexport.m function here (http://hg.savannah.gnu.org/hgweb/octave/rev/807a86834a62).  I also massaged it to follow Octave coding conventions in a subsequent cset (http://hg.savannah.gnu.org/hgweb/octave/rev/973c16f1c9fc).

Closing report.

Rik <rik5>
Group administrator
Tue 31 May 2016 10:15:56 PM UTC, comment #2: 

Yes, Jordi was going to look at adding Daniel.

Rik <rik5>
Group administrator
Tue 31 May 2016 10:03:54 PM UTC, comment #1: 

Can't Daniel become a GNU Octave group member to push the patch himself?

http://octave.1599824.n4.nabble.com/Patch-Create-scripts-directory-for-profiler-files-tp4676774p4677021.html

Kai Torben Ohlhus <siko1056>
Group Member
Mon 09 May 2016 06:28:18 PM UTC, original submission:  

This patch (which depends on https://savannah.gnu.org/patch/?8991) adds a new function "profexport".  This allows to export profiler data as HTML, which can then be explored in a browser.

The form is very rough, but this can be iterated on in the future.  It would even be possible to add diagrams or other fancy stuff, and this could be used to display profiler data in the Qt UI.

Daniel Kraft <domob>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37116:  patch-profexport.diff added by domob (15KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by siko1056 (Posted a comment)
  • -email is unavailable- added by siko1056 (Daniel Kraft as new group member?)
  • -email is unavailable- added by siko1056 (Daniel Kraft as new group member?)
  • -email is unavailable- added by siko1056 (Daniel Kraft as new group member?)
  • -email is unavailable- added by domob (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-02-26 mtmiller Carbon-CopyRemoved 80942 -
    2016-06-01 rik5 StatusNone Done
        Open/ClosedOpen Closed
    2016-05-31 siko1056 Carbon-Copy- Added jwe
        Carbon-Copy- Added jordigh
        Carbon-Copy- Added rik5
    2016-05-09 domob Attached File- Added patch-profexport.diff, #37116

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code