dmidecode - Patches: patch #9642, ThinkPad-specific patches
You are not allowed to post comments on this tracker with your current authentication level.
patch #9642: ThinkPad-specific patches
Submitter: | Joe <c0d3st0rm> | ||
Submitted: | Sat 26 May 2018 10:52:02 PM UTC | ||
Category: | None | Priority: | 4 |
Status: | Done | Privacy: | Public |
Assigned to: | khali | Open/Closed: | Closed |
Sun 02 Sep 2018 08:40:04 PM UTC, comment #4: |
Jean Delvare <khali> |
Thu 09 Aug 2018 06:29:58 PM UTC, comment #3: I reworked your patch based on my own comments, and posted the result on the list:
|
Jean Delvare <khali> |
Wed 04 Jul 2018 04:04:43 PM UTC, comment #2: Type 135:
looks wrong to me. This means that oem.data points to the header of the OEM structure. However later in the code you try to access byte at global offset 0x09 as oem.data[0], which would work if oem.data points to the OEM structure payload, not header.
is wrong, you actually want to check oem.rev, not oem.num (which is already checked on the previous line).
seems too strict to me, anything >= 3 is OK, and you have already tested for that earlier.
is testing the wrong bit (MSB), the fingerprint device is bit 0 (LSB).
is pretty harsh. You can easily imagine that these bytes have a meaning. In fact I believe that the structure of type 140 is very close to the structure of type 135:
|
Jean Delvare <khali> |
Wed 04 Jul 2018 02:56:35 PM UTC, comment #1: This is not really the best interface for a patch review, the mailing list is much more convenient for the purpose. I'll still try...
|
Jean Delvare <khali> |
Sat 26 May 2018 10:52:02 PM UTC, original submission:
Hi,
|
Joe <c0d3st0rm> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-09-02 | khali | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2018-07-04 | khali | Priority | 5 - Normal | 4 | |
Status | None | In Progress | |||
Assigned to | None | khali | |||
2018-05-26 | c0d3st0rm | Carbon-Copy | Removed khali | - | |
2018-05-26 | c0d3st0rm | Attached File | - | Added dmidecode_thinkpad_oem_types.patch, #44223 | |
Carbon-Copy | - | Added khali |
Powered by Savane 3.13-02a9.
Corresponding source code
Committed:
http://git.savannah.nongnu.org/cgit/dmidecode.git/commit/?id=d3903d7f8465af6e964b0dc4855673b8f185df68