patchQuilt - Patches: patch #9951, quilt setup will work with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9951: quilt setup will work with openSUSE Build Service multibuild process

Submitter:  Matej Cepl <mcepl>
Submitted:  Tue 07 Jul 2020 09:55:29 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Wont Do Privacy:  Public
Assigned to:  khali Open/Closed:  Closed

Fri 10 Jul 2020 03:10:06 PM UTC, comment #5: 

comment #4:

> Therefore I am not going to apply your patch, sorry.


That’s fair. Could I at least hope for approval of that openSUSE patch as a temporary measure, please? https://build.opensuse.org/request/show/819300

Thank you.

Matej Cepl <mcepl>
Fri 10 Jul 2020 02:38:24 PM UTC, comment #4: 

I discussed this yesterday on #openSUSE-buildservice on IRC. The feedback I got is that @BUILD_FLAVOR@ is considered a hack that should eventually be replaced with a more rpmbuild-compliant solution. Which was pretty much my own feeling on the topic.

Therefore I am not going to apply your patch, sorry.

Jean Delvare <khali>
Group administrator
Wed 08 Jul 2020 04:35:00 PM UTC, comment #3: 

commentaire #2 :

> I don’t think opinions of quilt maintainers will make authors of OBS to decide to back off the change which has been in the system for years. If you want to persuade them to revert that functionality, I wish you good luck, (...)


Did you actually try that? You are the one with the problem, not me.

> quilt missing this functionality makes it almost useless for me


Wouldn't be too hard to write a two-line script to turn your spec template into a standard spec file which quilt would deal with successfully. I understand that it would be even easier for you if this step would be integrated into quilt, but calling quilt "useless" because of this seems a little extreme. Also, just because it would be easier for you doesn't mean it's the right thing to do.

> (otherwise, it is really great tool and I like it very much).


Thank you.

Jean Delvare <khali>
Group administrator
Wed 08 Jul 2020 12:13:18 PM UTC, comment #2: 

comment #1:

> If you need to be able to build multiple flavors out of the same spec file, and rpmbuild doesn't support that, then talk to the rpm maintainers to add support there. That's where it belongs, and if it is done in the right place then every distribution doesn't have to reinvent their own solution on their side.


As the Czech saying goes, you cry well but on the wrong grave. I don’t think opinions of quilt maintainers will make authors of OBS to decide to back off the change which has been in the system for years. If you want to persuade them to revert that functionality, I wish you good luck, but it has not much to do with this patch.

Quilt setup module is a tool for people working with SPEC files, and it currently doesn’t support well environment where people use it. I am maintainer of hundreds of Python and Lua packages, where the multibuild functionality is used, and quilt missing this functionality makes it almost useless for me (otherwise, it is really great tool and I like it very much).

I hoped this option could go to the upstream codebase, if you think your users’ needs are beneath you, I will try to push the patch to the SUSE package, and I would have to (unhappily) use my own fork of the openSUSE package in my own home project.

Matej Cepl <mcepl>
Wed 08 Jul 2020 09:35:11 AM UTC, comment #1: 

Oh my, no, not again please.

We (SUSE) did the same long ago with the release number, and had to carry a SUSE-specific patch to handle it. We got rid of that in spec files of recent products, so upstream quilt finally works on recent SUSE spec files again, but that custom patch is still included in the SUSE quilt package to support the spec files of very old products.

Now you want to do the same hack for something else.

If your spec files contain @FOO@ strings to be substituted before rpm can process them, then they are not spec files. They are spec.in files. Asking all tools (IBS, quilt and certainly others) which rely on spec files to transparently pre-process the spec.in files into valid spec files on their own before they can use them is not the right approach to the problem, as this is duplicating the code across these tools.

If you need to be able to build multiple flavors out of the same spec file, and rpmbuild doesn't support that, then talk to the rpm maintainers to add support there. That's where it belongs, and if it is done in the right place then every distribution doesn't have to reinvent their own solution on their side.

Jean Delvare <khali>
Group administrator
Tue 07 Jul 2020 09:55:29 PM UTC, original submission:  

Present BUILD_FLAVOR is used for processing SPEC file.

openSUSE Build Service uses @BUILD_FLAVOR@ placeholder for variables used during the multibuilds. quilt setup command now supports it, if BUILD_FLAVOR is present in the commands environment.

Matej Cepl <mcepl>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #49447:  second_option.patch added by mcepl (1KiB - text/x-patch - fixed version of #49446 (missing shift 2 in processing options))
file #49446:  second_option.patch added by mcepl (1KiB - text/x-patch - This is alternative version of the patch which instead of the environmental variable uses -M parameter of setup subcommand.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by khali (Posted a comment)
  • -email is unavailable- added by mcepl (Submitted the item)
  • -email is unavailable- added by mcepl
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-10 khali StatusNeed Info Wont Do
        Open/ClosedOpen Closed
    2020-07-08 khali StatusNone Need Info
        Assigned toNone khali
    2020-07-07 mcepl Attached File- Added second_option.patch, #49447
    2020-07-07 mcepl Attached File- Added second_option.patch, #49446
    2020-07-07 mcepl Attached File- Added 0001-Present-BUILD_FLAVOR-is-used-for-processing-SPEC-fil.patch, #49445
        Carbon-Copy- Added mcepl

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code