patchAVR C Runtime Library - Patches: patch #2651, signal and UART reisters name...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #2651: signal and UART reisters name consistency

Submitter:  None
Submitted:  Fri 20 Feb 2004 12:27:30 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Privacy:  Public
Assigned to:  troth Originator Email:  -email is unavailable-
Open/Closed:  Closed

Tue 20 Apr 2004 11:42:06 PM UTC, comment #2: 

The register parts of this patch for the mega169 where done in the fix for bug #8452 (in cvs now).

The SIG_USART[01]_* changes for the mega162 will not be applied (this part is a WONT_FIX).

The SIG_USART_* changes for mega169 will be in cvs by the time  this patch is closed out.

I have posted some patches to the avr-libc dev list which allow gcc to generate an error if a signal name is misspelled which make the "_UART_SIGNAME_ERR +" hack suggested un-needed (assuming my patches go in).

Theodore A. Roth <troth>
Wed 07 Apr 2004 04:58:20 PM UTC, comment #1: 

Actually, more than the m169 use USART. If the data sheet says USART, I've been told to use USART.

The current m169 header uses SIG_UART0_*. That should probably be changed to SIG_USART_*.

The m162 SIG_USART[01]_* probably shouldn't be changed.

Personally, I'd rather see all the signal names for all devices reduced down to common and consistent names. We are already divergent from the datasheets with respect to interrupt vector names and simplification would reduce the chance of using the wrong SIG_* name (which gcc can't even catch and will generate the wrong code).

I'd like to hear some more comments on this patch before we take action.

Theodore A. Roth <troth>
Fri 20 Feb 2004 12:27:30 PM UTC, original submission:  

Beacuse m162 has only one UART then it is a little messy to use 0 in macro names.
In the avr-libc (except of m169.h) there are used UART prefixes not USART.

Maybe it is also worth to prohibit users against using old names of macros, adding something like:

#define _UART_SIGNAME_ERR +
#define SIG_UART0_RECV _UART_SIGNAME_ERR
#define SIG_UART0_DATA _UART_SIGNAME_ERR
#define SIG_UART0_TRANS _UART_SIGNAME_ERR

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #6942:  iom162_169_h.patch added by None (4KiB - application/octet-stream - patch for iom162.h and iom169.h)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-04-20 troth StatusNone Done
    Open/ClosedOpen Closed
2004-04-07 troth Assigned toNone troth
2004-04-07 troth Priority5 - Normal 3 - Low
2004-02-20 None Attached File- Added iom162_169_h.patch, #2755

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code