patchmldonkey, a multi-networks file-sharing client - Patches: patch #4126, Improved log_file handling

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4126: Improved log_file handling

Submitter:  spiralvoice <spiralvoice>
Submitted:  Fri 24 Jun 2005 11:45:13 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sat 03 Sep 2005 11:40:26 AM UTC, comment #10: 

"Core started"
take a look at patch #4392

spiralvoice <spiralvoice>
Group administrator
Sat 03 Sep 2005 03:38:43 AM UTC, comment #9: 

When a core is spawned from a gui, the only way to know the startup has succeeded is the string token "Core started". 

This string is no longer output to stdout after this patch.

Logging in .\mlnet.log is where it stops.

Logging should be turned on after the core has started and the "Core started" string has been sent to stdout to maintain backwards compatibility.

Further, the "NEVER close this window" info on win32 doesn't seem relevant anymore since the close button was deactivated.

z <zet>
Group Member
Thu 01 Sep 2005 04:31:01 PM UTC, comment #8: 

Applied 2005/09/01

spiralvoice <spiralvoice>
Group administrator
Sun 21 Aug 2005 04:12:24 PM UTC, comment #7: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Sat 06 Aug 2005 12:29:19 PM UTC, comment #6: 

Updated patch

  • new command open_log to reopen log after close_log
  • improved "stdout true" support
spiralvoice <spiralvoice>
Group administrator
Fri 22 Jul 2005 10:20:28 PM UTC, comment #5: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Fri 22 Jul 2005 02:41:41 PM UTC, comment #4: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Thu 07 Jul 2005 12:36:50 AM UTC, comment #3: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Wed 29 Jun 2005 01:51:13 PM UTC, comment #2: 

Updated patch for current CVS

spiralvoice <spiralvoice>
Group administrator
Sat 25 Jun 2005 12:31:03 AM UTC, comment #1: 

BTW: Thanks to pango for helping me on this patch

spiralvoice <spiralvoice>
Group administrator
Fri 24 Jun 2005 11:45:13 PM UTC, original submission:  
  • now there is a default log_file: mlnet.log
  • its default size log_file_size is 2MB, this is checked on core

  startup, if log_file is bigger it will be deleted
  A message is printed in this case:
     Logfile mlnet.log resetted, bigger than 2 MB
     Logging in mlnet.log

  • on core start the old log_file will not be removed anymore,

  new logging gets appended

  • new command "clear_log" to reset log_file while the core is working
  • removed command "log_file", same can be achieved through

  "set log_file" which should normally not be used as there is now
  a default log_file

  • some code cleanup


Side effects:

  • when the core is started twice in a new directory both times

  with "-stdout" a zero length file "mlnet.log" is created at
  the second startup

  • when the core is started with "-stdout" and log_file exists

  and is bigger than log_file_size the file is resetted

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9267:  4126.patch added by spiralvoice (10KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 18 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-05 spiralvoice Open/ClosedOpen Closed
2005-09-03 zet Open/ClosedClosed Open
2005-09-01 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-08-21 spiralvoice Attached File#4977 Removed
2005-08-21 spiralvoice Attached File- Added 4126.patch, #5059
2005-08-06 spiralvoice Attached File#4888 Removed
2005-08-06 spiralvoice Attached File- Added 4126_2.patch, #4977
2005-07-22 spiralvoice Attached File#4880 Removed
2005-07-22 spiralvoice Attached File- Added 4126.patch, #4888
2005-07-22 spiralvoice Attached File#4795 Removed
2005-07-22 spiralvoice Attached File- Added 4126.patch, #4880
2005-07-20 spiralvoice StatusNone Ready For Test
2005-07-07 spiralvoice Attached File#4774 Removed
2005-07-07 spiralvoice Attached File- Added 4126.patch, #4795
2005-06-29 spiralvoice Attached File#4763 Removed
2005-06-29 spiralvoice Attached File- Added 4126.patch, #4774
2005-06-24 spiralvoice Attached File- Added logfile2.patch, #4763

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code