patchmldonkey, a multi-networks file-sharing client - Patches: patch #4259, OV: some improvements and bug...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4259: OV: some improvements and bug #11927

Submitter:  bogeyman <bogeyman>
Submitted:  Mon 01 Aug 2005 06:28:21 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Postponed Assigned to:  bogeyman
Open/Closed:  Closed

Jump to the original submission

Tue 13 Sep 2005 07:22:56 PM UTC, comment #6: 

I will code this new and release it in pieces. right now i am looking through emule's,bittorrents mainline's and Azureus' source to see how they do things

bogeyman <bogeyman>
Group Member
Tue 13 Sep 2005 09:53:04 AM UTC, comment #5: 

Any updates yet?

spiralvoice <spiralvoice>
Group administrator
Sat 06 Aug 2005 12:03:01 PM UTC, comment #4: 

Thats not the way to go. I have to change this later as i am going on vacation until 20.Aug. :) See you.

bogeyman <bogeyman>
Group Member
Sat 06 Aug 2005 09:07:50 AM UTC, comment #3: 

Do you consider this patch stable enough to be applied to CVS?

spiralvoice <spiralvoice>
Group administrator
Sat 06 Aug 2005 09:07:17 AM UTC, comment #2: 

2005/08/06 08:34:07 [Kademlia] removed:(sr:0 s:0 r:0 bad:263) known_peers:(sr:6679 s:6438 r:3263 bad:5) omkp:16384
2005/08/06 08:36:24 [Kademlia] removed:(sr:93 s:37 r:34 bad:5) known_peers:(sr:6601 s:6431 r:3238 bad:115) omkp:16384
2005/08/06 08:37:54 [Kademlia] removed:(sr:0 s:0 r:0 bad:115) known_peers:(sr:6629 s:6446 r:3243 bad:67) omkp:16384
2005/08/06 08:43:09 [Kademlia] removed:(sr:0 s:0 r:0 bad:67) known_peers:(sr:6648 s:6472 r:3253 bad:12) omkp:16384
2005/08/06 08:44:12 [Kademlia] removed:(sr:0 s:0 r:0 bad:12) known_peers:(sr:6657 s:6472 r:3245 bad:11) omkp:16384
2005/08/06 08:52:57 [Kademlia] removed:(sr:82 s:73 r:9 bad:432) known_peers:(sr:6639 s:6434 r:3265 bad:47) omkp:16384
2005/08/06 08:55:31 [Kademlia] removed:(sr:1 s:0 r:0 bad:254) known_peers:(sr:6658 s:6470 r:3257 bad:0) omkp:16384
2005/08/06 08:59:00 [Kademlia] removed:(sr:71 s:63 r:29 bad:1) known_peers:(sr:6611 s:6455 r:3223 bad:96) omkp:16384
2005/08/06 09:01:10 [Kademlia] removed:(sr:0 s:0 r:0 bad:185) known_peers:(sr:6620 s:6471 r:3244 bad:50) omkp:16384
2005/08/06 09:04:38 [Kademlia] removed:(sr:0 s:0 r:0 bad:50) known_peers:(sr:6660 s:6480 r:3239 bad:6) omkp:16384
2005/08/06 09:05:42 [Kademlia] removed:(sr:0 s:0 r:0 bad:54) known_peers:(sr:6675 s:6482 r:3227 bad:1) omkp:16384
2005/08/06 09:07:12 [Kademlia] removed:(sr:0 s:0 r:0 bad:6) known_peers:(sr:6684 s:6482 r:3218 bad:1) omkp:16384
2005/08/06 09:09:52 [Kademlia] removed:(sr:66 s:71 r:27 bad:2) known_peers:(sr:6641 s:6491 r:3193 bad:60) omkp:16384
2005/08/06 09:15:01 [Kademlia] removed:(sr:0 s:0 r:0 bad:116) known_peers:(sr:6647 s:6495 r:3203 bad:40) omkp:16384
2005/08/06 09:16:22 [Kademlia] removed:(sr:0 s:0 r:0 bad:112) known_peers:(sr:6662 s:6496 r:3219 bad:8) omkp:16384
2005/08/06 09:22:40 [Kademlia] removed:(sr:82 s:58 r:24 bad:8) known_peers:(sr:6613 s:6522 r:3181 bad:69) omkp:16384
2005/08/06 09:24:08 [Kademlia] removed:(sr:0 s:0 r:0 bad:69) known_peers:(sr:6627 s:6546 r:3188 bad:24) omkp:16384
2005/08/06 09:26:09 [Kademlia] removed:(sr:61 s:91 r:12 bad:27) known_peers:(sr:6575 s:6453 r:3213 bad:144) omkp:16384
2005/08/06 09:30:56 [Kademlia] removed:(sr:0 s:0 r:0 bad:144) known_peers:(sr:6618 s:6490 r:3243 bad:34) omkp:16384
2005/08/06 09:33:29 [Kademlia] removed:(sr:0 s:0 r:0 bad:34) known_peers:(sr:6639 s:6495 r:3236 bad:15) omkp:16384
2005/08/06 09:35:01 [Kademlia] removed:(sr:1 s:0 r:0 bad:213) known_peers:(sr:6649 s:6495 r:3241 bad:0) omkp:16384
2005/08/06 09:38:38 [Kademlia] removed:(sr:87 s:38 r:38 bad:1) known_peers:(sr:6577 s:6558 r:3219 bad:31) omkp:16384
2005/08/06 09:39:45 [Kademlia] removed:(sr:0 s:0 r:0 bad:342) known_peers:(sr:6598 s:6556 r:3230 bad:1) omkp:16384
2005/08/06 09:45:01 [Kademlia] removed:(sr:74 s:34 r:56 bad:19) known_peers:(sr:6536 s:6526 r:3228 bad:95) omkp:16384
2005/08/06 09:46:49 [Kademlia] removed:(sr:0 s:0 r:0 bad:272) known_peers:(sr:6553 s:6531 r:3268 bad:33) omkp:16384
2005/08/06 09:49:07 [Kademlia] removed:(sr:0 s:0 r:0 bad:33) known_peers:(sr:6578 s:6531 r:3268 bad:8) omkp:16384
2005/08/06 09:54:08 [Kademlia] removed:(sr:58 s:59 r:47 bad:293) known_peers:(sr:6554 s:6546 r:3232 bad:53) omkp:16384
2005/08/06 09:55:09 [Kademlia] removed:(sr:0 s:0 r:0 bad:492) known_peers:(sr:6557 s:6546 r:3256 bad:26) omkp:16384
2005/08/06 09:59:10 [Kademlia] removed:(sr:102 s:44 r:18 bad:166) known_peers:(sr:6492 s:6502 r:3294 bad:97) omkp:16384
2005/08/06 10:02:41 [Kademlia] removed:(sr:0 s:0 r:0 bad:177) known_peers:(sr:6508 s:6502 r:3328 bad:47) omkp:16384
2005/08/06 10:04:52 [Kademlia] removed:(sr:0 s:0 r:0 bad:248) known_peers:(sr:6522 s:6509 r:3329 bad:25) omkp:16384
2005/08/06 10:06:31 [Kademlia] removed:(sr:0 s:0 r:0 bad:25) known_peers:(sr:6530 s:6517 r:3323 bad:15) omkp:16384
2005/08/06 10:08:08 [Kademlia] removed:(sr:0 s:0 r:0 bad:66) known_peers:(sr:6554 s:6520 r:3307 bad:4) omkp:16384
2005/08/06 10:09:35 [Kademlia] removed:(sr:69 s:78 r:17 bad:35) known_peers:(sr:6495 s:6524 r:3287 bad:79) omkp:16384
2005/08/06 10:11:00 [Kademlia] removed:(sr:0 s:0 r:0 bad:300) known_peers:(sr:6520 s:6533 r:3300 bad:32) omkp:16384
2005/08/06 10:13:29 [Kademlia] removed:(sr:0 s:1 r:0 bad:31) known_peers:(sr:6539 s:6533 r:3313 bad:0) omkp:16384
2005/08/06 10:16:49 [Kademlia] removed:(sr:74 s:65 r:24 bad:1) known_peers:(sr:6482 s:6467 r:3286 bad:150) omkp:16384
2005/08/06 10:21:19 [Kademlia] removed:(sr:0 s:0 r:0 bad:414) known_peers:(sr:6522 s:6495 r:3349 bad:19) omkp:16384
2005/08/06 10:23:43 [Kademlia] removed:(sr:56 s:59 r:49 bad:189) known_peers:(sr:6472 s:6588 r:3311 bad:14) omkp:16384
2005/08/06 10:26:32 [Kademlia] removed:(sr:57 s:85 r:22 bad:125) known_peers:(sr:6434 s:6514 r:3286 bad:151) omkp:16384
2005/08/06 10:30:24 [Kademlia] removed:(sr:0 s:0 r:0 bad:151) known_peers:(sr:6465 s:6527 r:3291 bad:102) omkp:16384
2005/08/06 10:33:12 [Kademlia] removed:(sr:0 s:0 r:0 bad:198) known_peers:(sr:6474 s:6557 r:3327 bad:27) omkp:16384
2005/08/06 10:34:26 [Kademlia] removed:(sr:0 s:0 r:0 bad:27) known_peers:(sr:6480 s:6556 r:3322 bad:27) omkp:16384
2005/08/06 10:36:19 [Kademlia] removed:(sr:0 s:0 r:0 bad:140) known_peers:(sr:6489 s:6565 r:3324 bad:7) omkp:16384
2005/08/06 10:37:22 [Kademlia] removed:(sr:0 s:0 r:0 bad:65) known_peers:(sr:6499 s:6566 r:3318 bad:2) omkp:16384
2005/08/06 10:38:50 [Kademlia] removed:(sr:1 s:0 r:0 bad:25) known_peers:(sr:6507 s:6567 r:3311 bad:0) omkp:16384
2005/08/06 10:40:58 [Kademlia] removed:(sr:83 s:50 r:30 bad:1) known_peers:(sr:6436 s:6522 r:3289 bad:138) omkp:16384
2005/08/06 10:46:40 [Kademlia] removed:(sr:0 s:0 r:0 bad:270) known_peers:(sr:6473 s:6526 r:3321 bad:65) omkp:16384
2005/08/06 10:47:43 [Kademlia] removed:(sr:0 s:0 r:0 bad:65) known_peers:(sr:6473 s:6529 r:3330 bad:53) omkp:16384
2005/08/06 10:49:38 [Kademlia] removed:(sr:0 s:0 r:0 bad:102) known_peers:(sr:6508 s:6532 r:3322 bad:23) omkp:16384
2005/08/06 10:52:41 [Kademlia] removed:(sr:1 s:0 r:0 bad:56) known_peers:(sr:6542 s:6539 r:3304 bad:0) omkp:16384
2005/08/06 10:55:53 [Kademlia] removed:(sr:61 s:71 r:31 bad:1) known_peers:(sr:6519 s:6490 r:3272 bad:104) omkp:16384
2005/08/06 10:58:44 [Kademlia] removed:(sr:0 s:0 r:0 bad:104) known_peers:(sr:6536 s:6489 r:3294 bad:66) omkp:16384
2005/08/06 11:01:24 [Kademlia] removed:(sr:0 s:0 r:0 bad:129) known_peers:(sr:6553 s:6512 r:3304 bad:16) omkp:16384

spiralvoice <spiralvoice>
Group administrator
Wed 03 Aug 2005 07:38:52 PM UTC, comment #1: 

2005/08/03 18:10:21 [Kademlia]: removed:(sr:0 s:0 r:0 bad:326) known_peers:(sr:4840 s:9187 r:1613 bad:745) omkp:16384
2005/08/03 18:20:30 [Kademlia]: removed:(sr:0 s:0 r:0 bad:326) known_peers:(sr:4879 s:9463 r:1612 bad:431) omkp:16384
2005/08/03 18:22:31 [Kademlia]: removed:(sr:0 s:0 r:0 bad:163) known_peers:(sr:4883 s:9496 r:1618 bad:388) omkp:16384
2005/08/03 18:27:35 [Kademlia]: removed:(sr:0 s:0 r:0 bad:163) known_peers:(sr:4908 s:9597 r:1627 bad:253) omkp:16384
2005/08/03 18:32:36 [Kademlia]: removed:(sr:0 s:0 r:0 bad:326) known_peers:(sr:4971 s:9629 r:1655 bad:130) omkp:16384
2005/08/03 18:37:38 [Kademlia]: removed:(sr:0 s:0 r:0 bad:587) known_peers:(sr:4992 s:9645 r:1684 bad:64) omkp:16384
2005/08/03 18:39:57 [Kademlia]: removed:(sr:0 s:0 r:0 bad:655) known_peers:(sr:4996 s:9648 r:1728 bad:13) omkp:16384
2005/08/03 18:45:21 [Kademlia]: removed:(sr:60 s:83 r:21 bad:13) known_peers:(sr:4952 s:9563 r:1775 bad:95) omkp:16384
2005/08/03 18:51:26 [Kademlia]: removed:(sr:0 s:0 r:0 bad:431) known_peers:(sr:4966 s:9605 r:1787 bad:27) omkp:16384
2005/08/03 18:52:27 [Kademlia]: removed:(sr:0 s:0 r:0 bad:27) known_peers:(sr:4978 s:9602 r:1784 bad:21) omkp:16384
2005/08/03 18:54:17 [Kademlia]: removed:(sr:0 s:0 r:0 bad:21) known_peers:(sr:4990 s:9597 r:1783 bad:15) omkp:16384
2005/08/03 18:55:51 [Kademlia]: removed:(sr:45 s:115 r:4 bad:441) known_peers:(sr:4954 s:9495 r:1820 bad:116) omkp:16384
2005/08/03 19:06:22 [Kademlia]: removed:(sr:0 s:0 r:0 bad:116) known_peers:(sr:5028 s:9474 r:1855 bad:28) omkp:16384
2005/08/03 19:08:28 [Kademlia]: removed:(sr:0 s:0 r:0 bad:145) known_peers:(sr:5040 s:9480 r:1854 bad:11) omkp:16384
2005/08/03 19:11:55 [Kademlia]: removed:(sr:1 s:0 r:0 bad:10) known_peers:(sr:5077 s:9480 r:1828 bad:0) omkp:16384
2005/08/03 19:13:53 [Kademlia]: removed:(sr:77 s:78 r:8 bad:1) known_peers:(sr:5013 s:9407 r:1817 bad:148) omkp:16384
2005/08/03 19:18:35 [Kademlia]: removed:(sr:0 s:0 r:0 bad:148) known_peers:(sr:5041 s:9458 r:1830 bad:56) omkp:16384
2005/08/03 19:21:26 [Kademlia]: removed:(sr:0 s:0 r:0 bad:56) known_peers:(sr:5047 s:9487 r:1826 bad:25) omkp:16384
2005/08/03 19:23:22 [Kademlia]: removed:(sr:0 s:0 r:0 bad:25) known_peers:(sr:5051 s:9500 r:1825 bad:9) omkp:16384
2005/08/03 19:27:53 [Kademlia]: removed:(sr:78 s:63 r:23 bad:166) known_peers:(sr:5027 s:9466 r:1793 bad:99) omkp:16384
2005/08/03 19:29:18 [Kademlia]: removed:(sr:0 s:0 r:0 bad:99) known_peers:(sr:5036 s:9485 r:1798 bad:66) omkp:16384
2005/08/03 19:39:18 [Kademlia]: removed:(sr:0 s:0 r:0 bad:66) known_peers:(sr:5065 s:9484 r:1784 bad:52) omkp:16384
2005/08/03 19:40:39 [Kademlia]: removed:(sr:0 s:0 r:0 bad:469) known_peers:(sr:5065 s:9495 r:1816 bad:9) omkp:16384
2005/08/03 19:48:36 [Kademlia]: removed:(sr:96 s:61 r:7 bad:9) known_peers:(sr:5015 s:9507 r:1814 bad:49) omkp:16384
2005/08/03 19:50:40 [Kademlia]: removed:(sr:0 s:0 r:0 bad:49) known_peers:(sr:5019 s:9539 r:1813 bad:14) omkp:16384
2005/08/03 19:57:14 [Kademlia]: removed:(sr:53 s:102 r:9 bad:126) known_peers:(sr:5012 s:9533 r:1801 bad:39) omkp:16384
2005/08/03 19:59:10 [Kademlia]: removed:(sr:0 s:0 r:0 bad:670) known_peers:(sr:5020 s:9530 r:1828 bad:7) omkp:16384
2005/08/03 20:08:26 [Kademlia]: removed:(sr:54 s:92 r:18 bad:7) known_peers:(sr:4999 s:9435 r:1831 bad:120) omkp:16384
2005/08/03 20:14:15 [Kademlia]: removed:(sr:0 s:0 r:0 bad:336) known_peers:(sr:5042 s:9435 r:1856 bad:52) omkp:16384
2005/08/03 20:16:02 [Kademlia]: removed:(sr:0 s:0 r:0 bad:52) known_peers:(sr:5050 s:9456 r:1868 bad:11) omkp:16384
2005/08/03 20:17:57 [Kademlia]: removed:(sr:1 s:0 r:0 bad:86) known_peers:(sr:5051 s:9456 r:1878 bad:0) omkp:16384
2005/08/03 20:22:14 [Kademlia]: removed:(sr:104 s:50 r:9 bad:1) known_peers:(sr:4968 s:9447 r:1855 bad:115) omkp:16384
2005/08/03 20:26:04 [Kademlia]: removed:(sr:0 s:0 r:0 bad:115) known_peers:(sr:4985 s:9516 r:1861 bad:23) omkp:16384
2005/08/03 20:27:33 [Kademlia]: removed:(sr:0 s:0 r:0 bad:321) known_peers:(sr:4986 s:9517 r:1881 bad:1) omkp:16384
2005/08/03 20:31:29 [Kademlia]: removed:(sr:44 s:112 r:8 bad:1) known_peers:(sr:4965 s:9402 r:1912 bad:106) omkp:16384
2005/08/03 20:35:31 [Kademlia]: removed:(sr:0 s:0 r:0 bad:468) known_peers:(sr:5000 s:9414 r:1934 bad:37) omkp:16384
2005/08/03 20:36:53 [Kademlia]: removed:(sr:0 s:0 r:1 bad:468) known_peers:(sr:5005 s:9434 r:1946 bad:0) omkp:16384
2005/08/03 20:38:21 [Kademlia]: removed:(sr:65 s:74 r:24 bad:1) known_peers:(sr:4951 s:9358 r:1928 bad:148) omkp:16384
2005/08/03 20:42:11 [Kademlia]: removed:(sr:0 s:0 r:0 bad:288) known_peers:(sr:4985 s:9367 r:1929 bad:104) omkp:16384
2005/08/03 20:50:45 [Kademlia]: removed:(sr:0 s:0 r:0 bad:203) known_peers:(sr:5037 s:9398 r:1913 bad:37) omkp:16384
2005/08/03 20:52:15 [Kademlia]: removed:(sr:0 s:0 r:0 bad:98) known_peers:(sr:5042 s:9427 r:1914 bad:2) omkp:16384
2005/08/03 20:56:24 [Kademlia]: removed:(sr:33 s:114 r:17 bad:324) known_peers:(sr:5020 s:9320 r:1979 bad:66) omkp:16384
2005/08/03 20:58:25 [Kademlia]: removed:(sr:0 s:0 r:0 bad:440) known_peers:(sr:5034 s:9322 r:1998 bad:31) omkp:16384
2005/08/03 21:00:09 [Kademlia]: removed:(sr:0 s:0 r:0 bad:31) known_peers:(sr:5046 s:9322 r:1989 bad:28) omkp:16384
2005/08/03 21:02:03 [Kademlia]: removed:(sr:0 s:0 r:0 bad:387) known_peers:(sr:5050 s:9322 r:2009 bad:4) omkp:16384
2005/08/03 21:03:38 [Kademlia]: removed:(sr:0 s:0 r:0 bad:4) known_peers:(sr:5068 s:9322 r:1992 bad:3) omkp:16384
2005/08/03 21:07:57 [Kademlia]: removed:(sr:92 s:36 r:36 bad:8) known_peers:(sr:5016 s:9390 r:1940 bad:39) omkp:16384
2005/08/03 21:10:59 [Kademlia]: removed:(sr:0 s:0 r:0 bad:313) known_peers:(sr:5032 s:9397 r:1951 bad:5) omkp:16384
2005/08/03 21:14:46 [Kademlia]: removed:(sr:39 s:92 r:33 bad:98) known_peers:(sr:5027 s:9322 r:1929 bad:107) omkp:16384
2005/08/03 21:17:36 [Kademlia]: removed:(sr:0 s:0 r:0 bad:304) known_peers:(sr:5028 s:9330 r:1980 bad:47) omkp:16384
2005/08/03 21:20:09 [Kademlia]: removed:(sr:0 s:0 r:0 bad:47) known_peers:(sr:5037 s:9355 r:1992 bad:1) omkp:16384
2005/08/03 21:22:47 [Kademlia]: removed:(sr:31 s:108 r:25 bad:21) known_peers:(sr:5011 s:9313 r:1971 bad:90) omkp:16384
2005/08/03 21:26:20 [Kademlia]: removed:(sr:0 s:0 r:0 bad:90) known_peers:(sr:5071 s:9326 r:1929 bad:59) omkp:16384
2005/08/03 21:28:44 [Kademlia]: removed:(sr:0 s:0 r:0 bad:312) known_peers:(sr:5081 s:9330 r:1956 bad:18) omkp:16384
2005/08/03 21:33:08 [Kademlia]: removed:(sr:53 s:105 r:6 bad:18) known_peers:(sr:5052 s:9223 r:1975 bad:135) omkp:16384
2005/08/03 21:35:07 [Kademlia]: removed:(sr:0 s:0 r:0 bad:385) known_peers:(sr:5058 s:9279 r:1987 bad:61) omkp:16384
2005/08/03 21:38:13 [Kademlia]: removed:(sr:0 s:0 r:0 bad:61) known_peers:(sr:5065 s:9280 r:2008 bad:32) omkp:16384

spiralvoice <spiralvoice>
Group administrator
Mon 01 Aug 2005 06:28:21 PM UTC, original submission:  

This patch will produce logs like:
2005/08/01 20:05:28 [Kademlia]: removed:(sr:0 s:0 r:0 bad:972) known_peers:(sr:1344 s:287 r:515 bad:6047) omkp:8192
sr: a peer we send to and received from
s: a peer we send to
r: a peer we received from
bad: nothing

Please post.

Changelog:

o new option: overnet_max_boot_peers, save max peers to disk. default:500
o boot_peers: save only peers we received from.
solves bug #11927

o replaced boot_peers_copy(List) with unknown_peers(limitedList): peers which should/could ping
o increase default overnet_max_known_peers to 16384 (~500kB).Its better to remember, so we can ping peers we really do not know
o known_peers: remove "bad" peers only if we did not send or received something yet (=bad), orderd by the last time we received them or a message from them (known_peers_fifo)
o known_peers: remove "bad" peers only if we exceed overnet_max_known_peers

o a new peer we received from is put immediately in a bucket rather than a prebucket

o pinging: 1. ping all peers in the buckets, we need them :)
           2. ping two prebucket peer for every missing bucket peer to fill the buckets quickly
           3. if we pinged all buckets/prebuckets already, ping unknown peers to fill the buckets

o LimitedList; implemented "get" and "clear"
o Fifo: implemented "copy"

Left todo: - replace peers in prebuckets clever

bogeyman <bogeyman>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9181:  good_boot_peers-knownhost_improved.patch added by bogeyman (19KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-13 bogeyman Open/ClosedOpen Closed
2005-08-07 spiralvoice StatusReady For Test Postponed
2005-08-01 bogeyman StatusNone Ready For Test
2005-08-01 bogeyman Attached File- Added good_boot_peers-knownhost_improved.patch, #4955

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code