patchmldonkey, a multi-networks file-sharing client - Patches: patch #4297, Create ini file backups on shutdown

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4297: Create ini file backups on shutdown

Submitter:  spiralvoice <spiralvoice>
Submitted:  Thu 11 Aug 2005 01:32:50 AM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Tue 16 Aug 2005 08:55:23 PM UTC, comment #9: 

Fixed with patch #4319

spiralvoice <spiralvoice>
Group administrator
Mon 15 Aug 2005 10:34:15 PM UTC, comment #8: 

This link error will occur if bzip2-devel package isn't installed on the system (BZIP2="no")


ifeq ("$(BZIP2)", "yes")
  LIBS_flags += -cclib -lbz2
  CDK_SRCS +=  $(CDK)/bzlib.ml $(CDK)/bzip2.ml $(CDK)/tar.ml
endif

Anonymous
Mon 15 Aug 2005 10:33:35 PM UTC, comment #7: 

It works here, did you do a CVS checkout into a clean directory?

spiralvoice <spiralvoice>
Group administrator
Mon 15 Aug 2005 09:40:48 PM UTC, comment #6: 

CVS does not compile for me, but when I revert this patch it compiles.

Using linux / Objective Caml version 3.08.4


ocamlopt.opt -inline 10  -a -o build/driver.cmxa       -ccopt " " -cclib "-lcharset  /usr/local/lib/libiconv.so -Wl,-rpath -Wl,/usr/local/lib" -ccopt " " -cclib "" -cclib -lz -cclib -lgd -cclib -lfreetype -cclib -lm -ccopt -W -ccopt -Wall -ccopt -Wno-unused -cclib -ljpeg -cclib -lpng -ccopt -DHAVE_JPEG -ccopt "-pthread"     src/daemon/driver/driverInteractive.cmx    src/daemon/driver/driverCommands.cmx    src/daemon/driver/driverLink.cmx    src/daemon/driver/driverControlers.cmx    src/daemon/driver/driverInterface.cmx    src/daemon/driver/driverMain.cmx 
ocamlopt.opt -inline 10 -linkall  -o mlnet       unix.cmxa str.cmxa -ccopt " " -cclib "-lcharset  /usr/local/lib/libiconv.so -Wl,-rpath -Wl,/usr/local/lib" -ccopt " " -cclib "" -cclib -lz -cclib -lgd -cclib -lfreetype -cclib -lm -ccopt -W -ccopt -Wall -ccopt -Wno-unused -cclib -ljpeg -cclib -lpng -ccopt -DHAVE_JPEG -ccopt "-pthread"   -I build    build/cdk.cmxa    build/common.cmxa    build/client.cmxa    build/core.cmxa    build/driver.cmxa    src/daemon/common/commonMain.cmx 
No implementations provided for the following modules:
  Tar referenced from build/client.cmxa(CommonComplexOptions)
make: * [mlnet] Error 2

Anonymous
Mon 15 Aug 2005 08:22:58 PM UTC, comment #5: 

Applied 2005/08/15

spiralvoice <spiralvoice>
Group administrator
Mon 15 Aug 2005 07:52:41 AM UTC, comment #4: 

i can´t confirm that bug, backing up fasttrack.ini
i had set verbosity to "hid" and try "save all" then "kill"
thats the entry´s in the log:
2005/08/15 09:49:57 [cCO] Options correctly saved
2005/08/15 09:49:57 [cCO] Sources correctly saved
2005/08/15 09:49:57 [cCO] Options backup as .tar.gz correctly saved
Warning: Gd support was not compiled (install libgd-dev to enable it)
2005/08/15 09:53:19 [cCO] Options correctly saved
2005/08/15 09:53:19 [cCO] Sources correctly saved
2005/08/15 09:53:19 [cCO] Options backup as .tar.gz correctly saved
2005/08/15 09:53:19 Core stopped

Schlumpf <schlumpf_>
Group Member
Fri 12 Aug 2005 08:51:38 PM UTC, comment #3: 

Attached you will find a new version for CVS 2.6.2.

It has zip file support, set option backup_options_format to "zip",
other values than "zip" will create a .tar.gz archive.

I stumbled over a weird bug, backing up fasttrack.ini into a .tar.gz
file fails with an exception, but only on Windows/MinGW. But the
file is stored correctly.
So the patch ignores this specific exception for this file on Windows.

spiralvoice <spiralvoice>
Group administrator
Thu 11 Aug 2005 10:37:44 AM UTC, comment #2: 

I will look if I can make zip archives as well, the necessary
functions are present in MLDonkey.

I don´t think zip is a "portable cross platform standard", all
Unix variants can use .tar.gz, and even Windows can ;-)
But zip/unzip is not installed everywhere, for example HP-UX lacks this:
http://www.computing.net/unix/wwwboard/forum/6036.html

spiralvoice <spiralvoice>
Group administrator
Thu 11 Aug 2005 01:38:18 AM UTC, comment #1: 

if there is no compression option, wouldn't .zip be a more portable cross platform standard?

Anonymous
Thu 11 Aug 2005 01:32:50 AM UTC, original submission:  

Note: file_sources.ini is never saved, it makes no sense to keep this file.

New options:

  • backup_options_delay, default 0

How often (in hours) should a backup of the ini files be written into old_config. A value of zero means that a backup is written only when the core shuts down.

  • backup_options_generations, default 10

Define the total number of options archives in old_config.

Command save got two new parameters:

  • "save all" saves options, sources and creates a ini file backup
  • "save backup" speaks for itself;-)
spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9234:  4297.patch added by spiralvoice (10KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-08-15 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-08-13 spiralvoice Attached File- Added 4297.patch, #5019
2005-08-13 spiralvoice Attached File#5014 Removed
2005-08-12 spiralvoice SummaryCreate ini file .tar.gz backups on shutdown Create ini file backups on shutdown
2005-08-12 spiralvoice Attached File#5008 Removed
2005-08-12 spiralvoice Attached File- Added 4297.patch, #5014
2005-08-11 spiralvoice Attached File- Added ini_backup.patch, #5008

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code