patchmldonkey, a multi-networks file-sharing client - Patches: patch #4321, BT : fixed "make_torrent...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4321: BT : fixed "make_torrent produce corrupted files on Windows"

Submitter:  Beedauchon <beedauchon>
Submitted:  Wed 17 Aug 2005 11:09:03 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sun 21 Aug 2005 03:41:47 PM UTC, comment #7: 

Applied 2005/08/21

spiralvoice <spiralvoice>
Group administrator
Sun 21 Aug 2005 01:37:27 PM UTC, comment #6: 

I would like to have some positive feedback about this patch
before it can be applied to CVS as it changes some important
internal functions.

spiralvoice <spiralvoice>
Group administrator
Wed 17 Aug 2005 11:09:03 AM UTC, comment #5: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #14101

Following are the information included in the original report:

[field #0]                  Item ID: 14101
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #5]                 Category: Bittorrent-Plugin
[field #6]             Submitted by: beedauchon
[field #7]              Assigned to: None
[field #8]             Submitted on: Fr 12.08.2005 um 03:19
[field #9]                  Summary: BT : make_torrent produce corrupted torrent files
[field #10]      Original Submission: linux :
space -> 0x20
newline -> 0x0A

windows
space -> 0x00
newline -> 0x0D0A


[field #12]               Item Group: Program malfunction
[field #13]                   Status: Fixed
[field #14]        Component Version: None
[field #15]         Platform Version: MinGW W2K/WinXP
[field #16]          Reproducibility: None
[field #17]               Size (loc): None
[field #18]            Fixed Release: None
[field #19]          Planned Release: None
[field #20]                   Effort: 0.00
[field #24]                 Priority: 5 - Normal
[field #27]         Percent Complete: 0%
[field #29]                  Release: 2.6.2
[field #54]          Binaries Origin: CVS / Self compiled
[field #55]                 CPU type: Intel x86
[field #56]                      CPU: None
[field #57]     Custom Select Box #4: None
[field #58]     Custom Select Box #5: None
[field #59]     Custom Select Box #6: None
[field #60]     Custom Select Box #7: None
[field #61]     Custom Select Box #8: None
[field #62]     Custom Select Box #9: None
[field #63]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Mon 15 Aug 2005 05:32:30 PM UTC, comment #4: 

Please try the attached patch

spiralvoice <spiralvoice>
Group administrator
Mon 15 Aug 2005 02:00:18 PM UTC, comment #3: 

thanks for the tip spiral, fix will be included in a soon to come patch with other stuffs..

Beedauchon <beedauchon>
Fri 12 Aug 2005 01:38:07 PM UTC, comment #2: 

http://caml.inria.fr/pub/docs/manual-ocaml/libref/Pervasives.html

"val set_binary_mode_in : in_channel -> bool -> unit

set_binary_mode_in ic true sets the channel ic to binary mode: no translations take place during input. set_binary_mode_out ic false sets the channel ic to text mode: depending on the operating system, some translations may take place during input. For instance, under Windows, end-of-lines will be translated from \r\n to \n. This function has no effect under operating systems that do not distinguish between text mode and binary mode."

spiralvoice <spiralvoice>
Group administrator
Fri 12 Aug 2005 12:10:24 PM UTC, comment #1: 

sorry i mismatched a bit the datas (was getting tired) so here is the correct table :

linux :
space -> 0x00
newline -> 0x0A

windows
space -> 0x20
newline -> 0x0D0A

Beedauchon <beedauchon>
Wed 17 Aug 2005 11:09:03 AM UTC, original submission:  

linux :
space -> 0x20
newline -> 0x0A

windows
space -> 0x00
newline -> 0x0D0A


Beedauchon <beedauchon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9250:  make_torrent.patch added by spiralvoice (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-08-21 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-08-17 spiralvoice CategoryNone Bug fixes
    SummaryReassigned item: BT : make_torrent produce corrupted torrent files BT : fixed "make_torrent produce corrupted files on Windows"
2005-08-17 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code