patchmldonkey, a multi-networks file-sharing client - Patches: patch #4350, Code cleanup : web interface...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4350: Code cleanup : web interface chunks display

Submitter:  pango <mlpango>
Submitted:  Fri 26 Aug 2005 12:42:53 AM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  spiralvoice
Open/Closed:  Closed

Jump to the original submission

Sat 12 Nov 2005 08:47:51 PM UTC, comment #13: 

Patch confirmed working with Konqueror 3.4.3, Opera 8.5 and Firefox 1.0.7, all on Gentoo x86

spiralvoice <spiralvoice>
Group administrator
Sat 12 Nov 2005 11:30:29 AM UTC, comment #12: 

Applied web_chunks_using_tables_v2.patch 2005/11/12

spiralvoice <spiralvoice>
Group administrator
Sat 12 Nov 2005 09:46:58 AM UTC, comment #11: 

New version, with a maximum of 8 pixels/chunk.
Also lowered html_vd_chunk_graph_max_width to 200 pixels by default.

pango <mlpango>
Group Member
Tue 01 Nov 2005 03:21:50 PM UTC, comment #10: 

The current behaviour doesn't seem to stretch at all in my browser.

The option !!html_vd_chunk_graph_max_width seems to indicate a max width, not a min width as well.

I suppose it should (a) either be renamed (html_vd_chunk_graph_width) and set to a more reasonable default value, or (b) chunk graphs should have a standard chunk width (X pixels, perhaps configurable?), and be displayed in a table with a fixed width of numChunks*X (seems to be the current behaviour), but not exceeding !!html_vd_chunk_graph_width.


z <zet>
Group Member
Tue 01 Nov 2005 06:42:56 AM UTC, comment #9: 

I didn't choose that behavior, nor the default !!html_vd_chunk_graph_max_width value; Personally, I decreased it to 200 pixels.
Maybe the default should also be changed in the patch ?

pango <mlpango>
Group Member
Mon 31 Oct 2005 11:28:52 PM UTC, comment #8: 

Stretching all chunkgraphs to the default of 880 pixels seems a little excessive in the "vd #" chart (especially for a file with just 1 chunk), don't you think?

z <zet>
Group Member
Mon 31 Oct 2005 01:01:12 AM UTC, comment #7: 

Ok, a version using tables.

pango <mlpango>
Group Member
Mon 10 Oct 2005 06:53:23 AM UTC, comment #6: 

The chunk float style wraps on IE, therefore it should not be used.

Perhaps you can try to integrate a fixed-width table into the table cell instead of using spans.  The width of the empty td's can replace the spans.  The fixed-width of the table is the total width of all td's (prevents "squishing" during window resize).

Something like the following seems to work in IE/Moz/Opera in a quick test.

<code>

<table width=20px cellspacing=0><tr><td class="chunk0" style="width:5px"></td><td class="chunk1" style="width:15px"></td></tr></table>

</code>

z <zet>
Group Member
Wed 21 Sep 2005 06:32:53 PM UTC, comment #5: 

Is this patch in a workable state for next the release tag?

spiralvoice <spiralvoice>
Group administrator
Sun 28 Aug 2005 07:51:26 AM UTC, comment #4: 

My mistake, resubmitted the old version.
Hope I got it right this time.

pango <mlpango>
Group Member
Sun 28 Aug 2005 07:49:03 AM UTC, comment #3: 

Small modification, should fix the computation of the number of validated chunks (that is always 0 currently).

pango <mlpango>
Group Member
Sat 27 Aug 2005 10:46:31 AM UTC, comment #2: 

I found one case were display is broken;
When all the chunks column is empty - but the header cell, with your own chunks -, the column may shrink; your chunks diagram then gets wrapped over several lines :/

td.sr and td.srh both have the "white-space: nowrap" style, I don't know what to do...


pango <mlpango>
Group Member
Fri 26 Aug 2005 05:02:00 PM UTC, comment #1: 

Maybe colors should also be changed...
For example, the 2 blue are difficult to tell apart.

pango <mlpango>
Group Member
Fri 26 Aug 2005 12:42:53 AM UTC, original submission:  
  • adds "float: left" to the chunks style so that variable width is rendered correctly (any CSS guru around ?)


  • Fixes rounding errors when scaling to !!html_vd_chunk_graph_max_width width, the chunks graph should always have the correct width


  • improved code


That patch received little testing so far, and should be checked against the different browsers available (Opera ?)


pango <mlpango>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 11 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-12 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-11-12 mlpango Attached File- Added web_chunks_using_tables_v2.patch, #5463
2005-10-31 mlpango Attached File- Added web_chunks_using_tables.patch, #5409
2005-10-31 mlpango CategoryNone Improved interfaces
    StatusNone Ready For Test
    Assigned toNone spiralvoice
2005-08-28 mlpango Attached File- Added web_interface_chunks_display.patch, #5097
2005-08-28 mlpango Attached File#5096 Removed
2005-08-28 mlpango Attached File- Added web_interface_chunks_display.patch, #5096
2005-08-26 mlpango Attached File- Added web_interface_chunks_display.patch, #5074

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code