patchmldonkey, a multi-networks file-sharing client - Patches: patch #4379, Fix compile error when libgd is...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4379: Fix compile error when libgd is not present

Submitter:  Pawel Veselov <vps>
Submitted:  Wed 31 Aug 2005 09:44:52 AM UTC
   
 
Category:  Bug fixes Priority:  9 - Immediate
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 31 Aug 2005 11:54:12 PM UTC, comment #4: 

Applied 2005/09/01

spiralvoice <spiralvoice>
Group administrator
Wed 31 Aug 2005 09:44:52 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #14345

Following are the information included in the original report:

[field #0]                  Item ID: 14345
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #5]                 Category: None
[field #6]             Submitted by: vps
[field #7]              Assigned to: None
[field #8]             Submitted on: Di 30.08.2005 um 20:22
[field #9]                  Summary: Can t compile 2.6.3 without lib-gd
[field #10]      Original Submission: 2.6.3 won t compile if --disable-gd is specified to configure, and no gd libraries are present in the system. The problem is that commonGlobals.ml has references to Gd object that are always compiled.

[vps@sun-001]~/sources/mldonkey-2.6.3$ LC_ALL=C make
ocamlrun ocamlc -linkall -o mlnet.byte       -custom unix.cma str.cma -ccopt "-L/static/lib  -isystem/static/include  -I/static/include" -cclib "-lcharset  /static/lib/libiconv.so -R/static/lib" -ccopt " " -cclib "" -cclib -lbz2 -cclib -lz -ccopt "-D_REENTRANT -pthreads"    -I build    build/cdk.cma    build/common.cma    build/client.cma    build/core.cma    build/driver.cma        src/daemon/common/commonMain.cmo 
Error while linking build/common.cma(CommonGlobals):
Reference to undefined global `Gd
make: * [mlnet.byte] Error 2
[vps@sun-001]~/sources/mldonkey-2.6.3$

[field #12]               Item Group: Compilation problem
[field #13]                   Status: Ready For Test
[field #14]        Component Version: None
[field #15]         Platform Version: Solaris
[field #16]          Reproducibility: None
[field #17]               Size (loc): None
[field #18]            Fixed Release: None
[field #19]          Planned Release: None
[field #20]                   Effort: 0.00
[field #24]                 Priority: 5 - Normal
[field #27]         Percent Complete: 0%
[field #29]                  Release: 2.6.3
[field #54]          Binaries Origin: CVS / Self compiled
[field #55]                 CPU type: Sparc
[field #56]                      CPU: None
[field #57]     Custom Select Box #4: None
[field #58]     Custom Select Box #5: None
[field #59]     Custom Select Box #6: None
[field #60]     Custom Select Box #7: None
[field #61]     Custom Select Box #8: None
[field #62]     Custom Select Box #9: None
[field #63]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Tue 30 Aug 2005 10:47:12 PM UTC, comment #2: 

Applying the attached patch onto 2.6.3 release seems to work.

[vps@sun-001]~/sources/mldonkey-2.6.3$ gpatch -p0 < ~/no_gd_png_ver.patch
patching file ./src/daemon/common/commonComplexOptions.ml
Hunk #1 succeeded at 1056 (offset -1 lines).
patching file ./src/daemon/common/commonComplexOptions.mli
patching file ./src/daemon/common/commonGlobals.ml
patching file ./src/daemon/common/commonGraphics.gd.ml
patching file ./src/daemon/common/commonGraphics.nogd.ml
patching file ./src/daemon/driver/driverCommands.ml
Hunk #1 succeeded at 379 (offset -17 lines).
patching file ./src/utils/cdk/gd.ml

The code compiles now.

Thanks,
  Pawel.

Pawel Veselov <vps>
Tue 30 Aug 2005 09:06:36 PM UTC, comment #1: 

Thanks to pointing to CommonGlobals, please try the attached patch.

spiralvoice <spiralvoice>
Group administrator
Wed 31 Aug 2005 09:44:52 AM UTC, original submission:  

2.6.3 won't compile if --disable-gd is specified to configure, and no gd libraries are present in the system. The problem is that commonGlobals.ml has references to Gd object that are always compiled.

[vps@sun-001]~/sources/mldonkey-2.6.3$ LC_ALL=C make
ocamlrun ocamlc -linkall -o mlnet.byte       -custom unix.cma str.cma -ccopt "-L/static/lib  -isystem/static/include  -I/static/include" -cclib "-lcharset  /static/lib/libiconv.so -R/static/lib" -ccopt " " -cclib "" -cclib -lbz2 -cclib -lz -ccopt "-D_REENTRANT -pthreads"    -I build    build/cdk.cma    build/common.cma    build/client.cma    build/core.cma    build/driver.cma        src/daemon/common/commonMain.cmo 
Error while linking build/common.cma(CommonGlobals):
Reference to undefined global `Gd'
make: * [mlnet.byte] Error 2
[vps@sun-001]~/sources/mldonkey-2.6.3$

Pawel Veselov <vps>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9317:  no_gd_png_ver.patch added by spiralvoice (11KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-08-31 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-08-31 spiralvoice CategoryNone Bug fixes
    Priority5 - Normal 9 - Immediate
    StatusNone Ready For Test
    SummaryReassigned item: Can't compile 2.6.3 without lib-gd Fix compile error when libgd is not present
2005-08-31 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code