patchSkencil - Patches: patch #4396, Align tool

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4396: Align tool

Submitter:  Valentin Ungureanu <vung>
Submitted:  Sun 04 Sep 2005 10:28:36 AM UTC
 
Category:  0.7.x Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Sat 24 Sep 2005 10:13:22 PM UTC, comment #2: 

Applied with minor changes.  The cursors for the HandleAlignTC and HandleAlignLC were the wrong way round.  Some formatting changes.

Thanks for the patch.

Bernhard Herzog <bh>
Project Administrator
Sun 04 Sep 2005 12:36:42 PM UTC, comment #1: 

Two small corrections:
1. AlignToolInstance had (for no reason) two class variables that are now instance variables
2. align_keystrokes in Sketch/Editor/__init__.py had an unneeded entry for selection_tool

The rest seems ok.

Valentin Ungureanu <vung>
Sun 04 Sep 2005 10:28:36 AM UTC, original submission:  

This patch implements the align tool, more info is in the
Changelog.

It includes patch #4307 (Handles for the align operations) which
I hoped would be applied first, but it didn't happen and in the
mean time the repository changed. I can split it again if it
helps.

Two of the tests fail, because currently the editor doesn't
restore the last selected objects. I made a separate patch for
that, see patch #4369

Valentin Ungureanu <vung>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9335:  aligntool_instancevars.diff added by vung (43KiB - text/x-patch - please use this instead of aligntool.diff)
file #9334:  aligntool.diff added by vung (43KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

 

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-24 bh StatusNone Done
    Open/ClosedOpen Closed
2005-09-04 vung Attached File- Added aligntool_instancevars.diff, #5138
2005-09-04 vung Attached File- Added aligntool.diff, #5137

Back to the top


Powered by Savane 3.9