patchmldonkey, a multi-networks file-sharing client - Patches: patch #4405, FileTP: Increase Swarmer range to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4405: FileTP: Increase Swarmer range to file_size to speed up transfers

Submitter:  None
Submitted:  Thu 08 Sep 2005 01:27:35 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Wont Do Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Closed

Jump to the original submission

Tue 18 Oct 2005 09:25:35 AM UTC, comment #13: 

go ahead

kempston <kempston>
Tue 18 Oct 2005 09:03:46 AM UTC, comment #12: 

@bogeyman: Can I close this patch then as it will not be applied judging by the comments here?

spiralvoice <spiralvoice>
Group administrator
Thu 15 Sep 2005 11:16:18 PM UTC, comment #11: 

giving up the multinet idea by increasing the range this way may be the wrong front. The bt/donkey/fileTP modules are asking (find_range) the swarmer for a range to request. This is limited by 180kb. After receiving the requested data, its passed to the swarmer. My idea is that the fileTP module asking the swarmer for multiple ranges and merge them into one request to the source/server. Added on my todo list :)

bogeyman <bogeyman>
Group Member
Tue 13 Sep 2005 07:30:01 PM UTC, comment #10: 


>What about requesting some ranges (maybe 10 or all?) from the swarmer and sending one request to the server? will Swarmer2.receive process multiple ranges? as far as i can tell it will (please correct me if i am wrong)


Have no idea what you're talking about :)

kempston <kempston>
Tue 13 Sep 2005 07:11:45 PM UTC, comment #9: 

bt range is not increased, as it is limited to 16kb by the bt module. no client ask for more.

What about requesting some ranges (maybe 10 or all?) from the swarmer and sending one request to the server? will Swarmer2.receive process multiple ranges? as far as i can tell it will (please correct me if i am wrong)

bogeyman <bogeyman>
Group Member
Thu 08 Sep 2005 06:17:03 PM UTC, comment #8: 

Yes, that's becouse it adds new field to swarmer.
You can avoid it by removing all swarmers from files.ini it will recreate them and no download progress will be broken

kempston <kempston>
Thu 08 Sep 2005 06:14:20 PM UTC, comment #7: 

From IRC channel:
[20:11] <sense12> [16:48:13] @spiralvoice patch #4405 leads on windows to an Exception: Not_found while handling option:swarmers
[20:11] <sense12> [16:48:13]   in files.ini
[20:11] <sense12> [16:48:13] Aborting

spiralvoice <spiralvoice>
Group administrator
Thu 08 Sep 2005 02:11:10 PM UTC, comment #6: 

Heh, i havn't. In fact personally i'm not going to use this feature untill it becomes stable and automatic :P

kempston <kempston>
Thu 08 Sep 2005 02:04:08 PM UTC, comment #5: 

Has the patch been tested on a multinet download? (Same file on ed2k and bt for example?)

The comment in commonSwarming2 says

"If we want to become 'multinet', we should:
...

  • the range_size should be the same for all networks.

"

so I wonder if this patch would break anything?

Anonymous
Thu 08 Sep 2005 01:27:35 PM UTC, comment #4: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #13084

Following are the information included in the original report:

[field #0]                  Item ID: 13084
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: FileTP-Plugin
[field #7]             Submitted by: None
[field #8]              Assigned to: None
[field #9]             Submitted on: Sa 14.05.2005 um 15:57
[field #10]                  Summary: FileTP: Increase Swarmer range to file_size to speed up transfers
[field #11]      Original Submission: Current implementation of swarming set the range_size to edonkey_range_size which is set to 180kb. This limits the FileTP transfers speed as the code request 180kb blocks from the server.
[field #13]               Item Group: Program malfunction
[field #14]                   Status: None
[field #15]        Component Version: None
[field #16]         Platform Version: None
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: None
[field #55]          Binaries Origin: None
[field #56]                 CPU type: None
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Wed 07 Sep 2005 10:25:13 AM UTC, comment #3: 

Sure.
Here is improoved version of patch.
Restarting core now is not harmful.

kempston <kempston>
Fri 02 Sep 2005 11:12:48 PM UTC, comment #2: 

@kempston: I will test your patch later.
Please don´t double-post patches on Savannah´s trackers.
If a topic (task or bug) already exists, please post a patch there
so the discussion which lead to the patch is preserved.
That topic can later be moved to the patch tracker, where the patch
will stay with status closed if it was applied.

spiralvoice <spiralvoice>
Group administrator
Fri 02 Sep 2005 01:27:50 AM UTC, comment #1: 

Here is quick fix telling mldonkey to use 1 chunk for filetp downloads.
It's increasing range for bt downloads as well as a side effect
Restarting core seem to break effect of patch, maybe someone want to improove it

Anonymous
Thu 08 Sep 2005 01:27:35 PM UTC, original submission:  

Current implementation of swarming set the range_size to edonkey_range_size which is set to 180kb. This limits the FileTP transfers speed as the code request 180kb blocks from the server.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9050:  2.6.4-filetp_range.patch added by kempston (2KiB - application/octet-stream)
file #9049:  2.6.3-filetp_range.patch added by None (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-10-18 spiralvoice StatusPostponed Wont Do
    Open/ClosedOpen Closed
2005-09-21 spiralvoice StatusNone Postponed
2005-09-08 spiralvoice CategoryNone Improved interfaces
    SummaryReassigned item: FileTP: Increase Swarmer range to file_size to speed up transfers FileTP: Increase Swarmer range to file_size to speed up transfers
2005-09-08 spiralvoice Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code