patchmldonkey, a multi-networks file-sharing client - Patches: patch #4419, ED2K: Support secure user...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4419: ED2K: Support secure user identification

Submitter:  z <zet>
Submitted:  Wed 14 Sep 2005 08:54:09 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Mon 19 Sep 2005 11:19:29 AM UTC, comment #14: 

Problem is fixed... my fault. g++ was linked to an old non-existing file.
Sorry for the confusion.

White_FrosT
Sun 18 Sep 2005 10:18:14 PM UTC, comment #13: 

@freebsd$ uname -a
FreeBSD freebsd. 5.4-RELEASE FreeBSD 5.4-RELEASE #0: Sun May  8 10:21:06 UTC 2005     root@harlow.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC  i386
@freebsd$ which g++
/usr/bin/g++

and compiling current MLDonkey CVS works out of the box as I already
said in comment #2 and just tested again with a fresh CVS checkout.
The question is, why is FreeBSD-current different to FreeBSD-release?

spiralvoice <spiralvoice>
Group administrator
Sun 18 Sep 2005 09:25:31 PM UTC, comment #12: 

Here compiling doesn't work out of the box (FreeBSD 5-current). There is no g++ on my system, c++ is the way to go.

Current CVS causes a compile error during compiling of cryptokit (g++ instead of c++) and there is also an error when linking because of missing g++.

White_FrosT
Sun 18 Sep 2005 07:00:57 PM UTC, comment #11: 

Applied 2005/09/18

spiralvoice <spiralvoice>
Group administrator
Sun 18 Sep 2005 04:30:45 PM UTC, comment #10: 

This update reports the verified state of a client in the web interface/guiprot.

z <zet>
Group Member
Sun 18 Sep 2005 02:35:15 AM UTC, comment #9: 

Wasn't working without verbosity mc. I threw begin/ends around every verbose_msg_clients block..

z <zet>
Group Member
Sat 17 Sep 2005 11:09:16 PM UTC, comment #8: 

Updated to also send a Sig packet after muleInfo packet is received if certain conditions are met.

.cc already uses $(CXX) so I used that instead of $(CPP).

I was trying to get rid of that hack in commonServer so there would be a central place for the method to id low/high servers, but didn't notice low_id in donkeyGlobals (which obviously isn't accessible from common). Got rid of that hack in another way.

z <zet>
Group Member
Sat 17 Sep 2005 06:58:27 PM UTC, comment #7: 

Attached a patch to check for c++ existance

spiralvoice <spiralvoice>
Group administrator
Sat 17 Sep 2005 02:12:20 PM UTC, comment #6: 

Please don't move "let donkey_low_id ip..." to commonGlobals, that donkey_low_id is an hack. Use donkeyGlobals.low_id . Please use $(CPP) instead of g++. Then please change (diff style)

 if test "$FORCE_MINGW" = "yes"; then                                                                                                                                                
     CC="$CC -mno-cygwin"                                                                                                                                                            
+    CPP="$CPP -mno-cygwin"
 fi                                                                                                                                                                                  

(one line added) in config/configure.in .
I didn't look at the stuff in src/networks/donkey but the rest seems fine.

Amorphous <amorphous>
Fri 16 Sep 2005 05:49:13 PM UTC, comment #5: 

Patch compiles on Solaris/Sparc as well.

spiralvoice <spiralvoice>
Group administrator
Fri 16 Sep 2005 04:39:14 PM UTC, comment #4: 

Updated patch to fix a SecIDv2 bug, and add reset_md4 command (resets md4 and private_key)

z <zet>
Group Member
Thu 15 Sep 2005 11:04:09 PM UTC, comment #3: 

looks good here as far i can tell, downloads ratio normal. How about a switch to disable/enable? a key reset command maybe no good idea, because the clients md4 have to be changed too, or we will be "hash thiefs" :) I am already interested in emule forum reactions. btw, credits collected by our md4 hash will be "lost", when ident by rsa key. Make sense from the credit giving point of view.

bogeyman <bogeyman>
Group Member
Thu 15 Sep 2005 05:34:41 PM UTC, comment #2: 

Compiled this patch on Linux(Gentoo/Debian Sarge), MinGW, FreeBSD, OpenBSD, NetBSD. On all platforms compile works and MLDonkey successfully created a private key.

spiralvoice <spiralvoice>
Group administrator
Wed 14 Sep 2005 11:14:02 PM UTC, comment #1: 

If you use MLDonkey in a chroot jail be sure to create /dev/urandom in that chroot dir:

mknod -m 644 /dev/urandom c 1 9

spiralvoice <spiralvoice>
Group administrator
Wed 14 Sep 2005 08:54:09 PM UTC, original submission:  


Secure User Identification:
http://www.emule-project.net/home/perl/help.cgi?l=1&rm=show_topic&topic_id=135

Ocaml cryptoKit doesn't support DER encoding, and I couldn't
find an ocaml lib that did, so this patch uses CryptoPP
(C++ code) like the other clients.

It adds the C stubs, and donkey protocol code.

It does not save public keys in any type of credit database
(although such a thing would be easier to write now..).

It does save your private key to donkey.ini (client_private_key).
If client_md4 changes, you should regenerate it. (delete it from the .ini)

Logging messages requires verbosity "mc".

The Makefile.in hacks are ... hacks.  Ideally, "make mld_hash"
shouldn't require CryptoPP being compiled/linked, but I don't
have time for makefile games at the moment, so I added the .cc filter to the C libs.

Tested very briefly (verify ident passed)... I'm not sure how to test it thorougly.

z <zet>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8903:  crypto5.diff.bz2 added by zet (94KiB - application/octet-stream)
file #8747:  cpp_configure.patch added by spiralvoice (628B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 12 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-18 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-09-18 zet Attached File- Added crypto5.diff.bz2, #5194
2005-09-18 zet Attached File#5193 Removed
2005-09-18 zet Attached File- Added crypto4.diff.bz2, #5193
2005-09-18 zet Attached File#5192 Removed
2005-09-17 zet Attached File- Added crypto3.diff.bz2, #5192
2005-09-17 zet Attached File#5182 Removed
2005-09-17 spiralvoice Attached File- Added cpp_configure.patch, #5191
2005-09-16 zet Attached File- Added crypto2.diff.bz2, #5182
2005-09-16 zet Attached File#5175 Removed
2005-09-14 zet Attached File- Added crypto.diff.bz2, #5175

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code