patchmldonkey, a multi-networks file-sharing client - Patches: patch #4424, OV: discard peers with ip 1.0.0.0...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4424: OV: discard peers with ip 1.0.0.0 and random port

Submitter:  bogeyman <bogeyman>
Submitted:  Fri 16 Sep 2005 01:29:47 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Sat 17 Sep 2005 06:50:03 PM UTC, comment #6: 

I wonder if 1.0.0.0 is not the IP reported by firewalled peers looking for a "buddy" (what replaces LowID mecanism in Overnet)...

pango <mlpango>
Group Member
Sat 17 Sep 2005 05:59:55 PM UTC, comment #5: 

Applied 2005/09/17

spiralvoice <spiralvoice>
Group administrator
Sat 17 Sep 2005 03:00:16 PM UTC, comment #4: 

Try this patch, it introduces

+let is_overnet_ip ip =
+  Ip.usable ip && Ip.of_string "1.0.0.0" <> ip

and cleans the Ip check functions a bit.

spiralvoice <spiralvoice>
Group administrator
Sat 17 Sep 2005 11:48:33 AM UTC, comment #3: 

1.0.0.0 is an valid ip. it is just marked as reserved by the IANA. so this is an thing for the blocklist...

Amorphous <amorphous>
Fri 16 Sep 2005 01:29:47 AM UTC, comment #2: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #14548

Following are the information included in the original report:

[field #0]                  Item ID: 14548
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #6]                 Category: Core
[field #7]             Submitted by: bogeyman
[field #8]              Assigned to: None
[field #9]             Submitted on: Fri 09/16/05 at 00:16
[field #10]                  Summary: peers with ip 1.0.0.0 and random port
[field #11]      Original Submission: i got some of these in my boot_peers. are they firewalled ones? or did they just fill in the wrong ip?
[field #13]               Item Group: Program malfunction
[field #14]                   Status: None
[field #15]        Component Version: None
[field #16]         Platform Version: Linux
[field #17]          Reproducibility: None
[field #18]               Size (loc): None
[field #19]            Fixed Release: None
[field #20]          Planned Release: None
[field #21]                   Effort: 0.00
[field #25]                 Priority: 5 - Normal
[field #28]         Percent Complete: 0%
[field #30]                  Release: 2.6.4
[field #55]          Binaries Origin: CVS / Self compiled
[field #56]                 CPU type: None
[field #57]                      CPU: None
[field #58]     Custom Select Box #4: None
[field #59]     Custom Select Box #5: None
[field #60]     Custom Select Box #6: None
[field #61]     Custom Select Box #7: None
[field #62]     Custom Select Box #8: None
[field #63]     Custom Select Box #9: None
[field #64]    Custom Select Box #10: None

bogeyman <bogeyman>
Group Member
Fri 16 Sep 2005 01:29:45 AM UTC, comment #1: 

1.0.0.0 is not a valid ip, right? so:

 let valid (j,k,l,i) =
  match (j,k,l,i) with
      1, 0, 0, 0 -> false
    | , , , ->
      j > 0 && j < 224 &&
      k >= 0 && k <= 255 &&
      l >= 0 && l <= 255 &&
      i >= 0 && i <= 255

patch included, ill test this

bogeyman <bogeyman>
Group Member
Fri 16 Sep 2005 01:29:47 AM UTC, original submission:  

i got some of these in my boot_peers. are they firewalled ones? or did they just fill in the wrong ip?

bogeyman <bogeyman>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8746:  ip_check.patch added by spiralvoice (10KiB - application/octet-stream)
file #8756:  ip_valid.patch added by bogeyman (693B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-09-17 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-09-17 spiralvoice Attached File- Added ip_check.patch, #5189
2005-09-17 spiralvoice StatusInvalid Ready For Test
2005-09-17 spiralvoice SummaryReassigned item: peers with ip 1.0.0.0 and random port OV: discard peers with ip 1.0.0.0 and random port
2005-09-17 amorphous StatusNone Invalid
2005-09-16 bogeyman Reassign itemFrom group mldonkey, a multi-networks file-sharing client, bugs tracker To group mldonkey, a multi-networks file-sharing client, patch tracker

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code