patchmldonkey, a multi-networks file-sharing client - Patches: patch #4440, makes the shutdown timeout an...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4440: makes the shutdown timeout an option

Submitter:  Amorphous <amorphous>
Submitted:  Mon 19 Sep 2005 05:32:00 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Assigned to:  None
Open/Closed:  Closed

Mon 21 Nov 2005 09:35:46 PM UTC, comment #5: 

Applied 2005/11/21, default is 3 seconds, which was previously hardcoded.

spiralvoice <spiralvoice>
Group administrator
Thu 06 Oct 2005 01:10:53 PM UTC, comment #4: 

Maybe signal handling should be deactivated during shutdown of MLDonkey
to avoid killing it while it tries to clean itself up before
terminating the process? And of course log messages...

spiralvoice <spiralvoice>
Group administrator
Tue 04 Oct 2005 02:42:42 PM UTC, comment #3: 

If a tracker is down, waiting 15 seconds after pressing ctrl-c to close mldonkey makes it seem frozen and invites a kill. Maybe every 3 seconds an info message can be displayed for such a long delay.

If routing is down between mldonkey and a tracker, perhaps it is better to resend the stop.  Can too many stops be worse than too few?  If reconnecting to a tracker that wasn't previously "stopped", get_sources_from_tracker will add its own ip/port as a source ("peers" key) since the ips/ports are not compared against the self ip (the tracker believes we are still a source since we didn't stop).

Anonymous
Mon 03 Oct 2005 11:46:01 PM UTC, comment #2: 

why should 15 be a bad default?
it's a timeout, so if it finished after 2 seconds the core exits then. it only waits as long as needed (but at most 15s) to correctly stop with trackers.
(oh the stop is sent each execution of the timer, a patch for that is following)

Amorphous <amorphous>
Sat 01 Oct 2005 09:58:31 PM UTC, comment #1: 

15 seems like a bad default. Far too long to wait.  3 is working fine.


Anonymous
Mon 19 Sep 2005 05:32:00 PM UTC, original submission:  


Amorphous <amorphous>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8076:  4440.patch added by spiralvoice (1KiB - application/octet-stream - this version was applied to CVS)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-21 spiralvoice StatusWorks For Me Done
    Open/ClosedOpen Closed
    Attached File- Added 4440.patch, #5502
2005-10-01 amorphous StatusNone Works For Me
2005-09-19 amorphous Attached File- Added shutdown_timeout_option.patch, #5210

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code