mldonkey, a multi-networks file-sharing client - Patches: patch #4450, Remove swarmer data when...
You are not allowed to post comments on this tracker with your current authentication level.
patch #4450: Remove swarmer data when cancelling download
Submitter: | kempston <kempston> | ||
Submitted: | Tue 20 Sep 2005 09:03:56 PM UTC | ||
Category: | Bug fixes | Priority: | 7 - High |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Jump to the original submission
Thu 06 Oct 2005 10:20:24 AM UTC, comment #35: |
spiralvoice <spiralvoice> |
Wed 21 Sep 2005 03:56:41 PM UTC, comment #34: Maybe you can just check for secondaries in the remove_swarmer function.
|
z <zet> |
Tue 20 Sep 2005 09:33:26 PM UTC, comment #33: Heh, who acres about cvs, i'll be quite satisfied to see it in spiralvoice releases :) |
kempston <kempston> |
Tue 20 Sep 2005 09:30:38 PM UTC, comment #32: I don't think this should be added to cvs until it fixes the multinet bug that it introduces. (killing swarmers for multinet downloads) |
z <zet> |
Tue 20 Sep 2005 09:10:30 PM UTC, comment #31: And calling remove_swarmer in Gnutella/G2/Fasttrack? |
spiralvoice <spiralvoice> |
Tue 20 Sep 2005 09:08:22 PM UTC, comment #30: What about calling remove_swarmer during commit? |
spiralvoice <spiralvoice> |
Tue 20 Sep 2005 09:03:56 PM UTC, comment #29: This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker. |
spiralvoice <spiralvoice> |
Fri 09 Sep 2005 08:07:05 AM UTC, comment #28: Here is even more improved version.
|
kempston <kempston> |
Fri 09 Sep 2005 02:54:11 AM UTC, comment #27: Here is improoved version of the patch.
|
kempston <kempston> |
Thu 08 Sep 2005 05:29:08 PM UTC, comment #26: Hmm... code should be rewritten then :)
|
kempston <kempston> |
Thu 08 Sep 2005 04:20:06 PM UTC, comment #25: + if !found = 0 then Int64Swarmer.remove_swarmer file_swarmer
|
Anonymous |
Thu 08 Sep 2005 03:26:31 PM UTC, comment #24: Wrong, wrong, wrong.
Actually it does, that's the point. What do you think this is for?
|
kempston <kempston> |
Thu 08 Sep 2005 03:18:16 PM UTC, comment #23: What if you have two files downloading, using the same swarmer, and you cancel one of them? Won't your patch forcefully remove the swarmer and break the download of the other file? It isn't checking to see that the swarmer isn't in use by some other file.
|
Anonymous |
Wed 07 Sep 2005 10:01:36 PM UTC, comment #22:
Couse my Ocaml knowledge sucks
Yes couse this code won't work from CommonSwarming.
Yes, couse i only care about bt/ed2k/filetp
Well you might want to improove it in some way but it does it's job
|
kempston <kempston> |
Wed 07 Sep 2005 02:15:59 PM UTC, comment #21: @2.6.4-broken-cancel.patch
|
Anonymous |
Wed 07 Sep 2005 08:54:32 AM UTC, comment #20: This one works fine |
kempston <kempston> |
Wed 07 Sep 2005 07:56:15 AM UTC, comment #19: Oh, well it's broken |
kempston <kempston> |
Wed 07 Sep 2005 04:08:27 AM UTC, comment #18: This patch finnaly solves the problem
|
kempston <kempston> |
Tue 06 Sep 2005 10:27:50 PM UTC, comment #17: Seems like with large number of downloads patch not doing it's job at all |
kempston <kempston> |
Sun 21 Aug 2005 12:28:40 PM UTC, comment #16: Applied your patch to CVS |
spiralvoice <spiralvoice> |
Sun 21 Aug 2005 12:23:54 PM UTC, comment #15: Copied your patch to patch #4334 |
spiralvoice <spiralvoice> |
Sun 21 Aug 2005 10:58:35 AM UTC, comment #14: Well here is same patch for bt and filetp. |
kempston <kempston> |
Wed 17 Aug 2005 12:45:51 AM UTC, comment #13: Not sure if it can be closed, i just checked last 2.6.2 and "fast readding" problem is still there, and from what i remember it's just a symptom of several important problems |
kempston <kempston> |
Sat 11 Jun 2005 07:53:10 PM UTC, comment #12: Opened patch #4091 with the file cancel.patch from here. |
spiralvoice <spiralvoice> |
Fri 10 Jun 2005 03:19:30 PM UTC, comment #11: Did some tests, I donĀ“t think "file.file_swarmer <- None;" will
|
spiralvoice <spiralvoice> |
Fri 10 Jun 2005 03:03:05 PM UTC, comment #10: Well, i'm not sure about that - thing is, if you do manual save (even ten times), it won't clear the list.
|
kempston <kempston> |
Fri 10 Jun 2005 02:56:10 PM UTC, comment #9: You may be right about "file.file_swarmer <- None;"
|
spiralvoice <spiralvoice> |
Fri 10 Jun 2005 10:16:49 AM UTC, comment #8: Hmm, i remember myself checking commit code before, didn't find there anyhting userfull, but thnx for the great tip - i've checked some traces and found out, that in donkeyOneFile.ml in declare_completed_file function there is a code "file.file_swarmer <- None;" that can be used as i kind of solution.
|
kempston <kempston> |
Wed 08 Jun 2005 12:11:38 AM UTC, comment #7: Note for devs: The swarmers section is removed when a file is committed. Maybe the necessary code section to be added to the
|
spiralvoice <spiralvoice> |
Fri 03 Jun 2005 04:50:04 PM UTC, comment #6: Ok, i've discovered following: after starting download and then canceling it i can see this in files.ini
|
kempston <kempston> |
Sun 29 May 2005 06:40:03 PM UTC, comment #5: duplicate of savannah bug #12372 |
Amorphous <amorphous> |
Fri 29 Apr 2005 10:05:15 AM UTC, comment #4: or does it actually start a new download?
|
Amorphous <amorphous> |
Fri 29 Apr 2005 09:18:02 AM UTC, comment #3: afaik it's not a dublicate. this one is about that there remain traces of removed downloads and canceled downloads in mldonkey (until it is restarted). the other one is about exceptions when iterating networks, so the common code thinks that network (that didn't return false because of an exception) accepted the download and only starts the download as a non-primary in any following networks. |
Amorphous <amorphous> |
Thu 28 Apr 2005 12:35:32 PM UTC, comment #2: Continuing in bug #12841 which is a somehow a duplicate. |
spiralvoice <spiralvoice> |
Thu 28 Apr 2005 12:10:09 PM UTC, comment #1: I could reproduce that bug:
|
spiralvoice <spiralvoice> |
Tue 20 Sep 2005 09:03:56 PM UTC, original submission:
If you add ed2k download, then cancel it and then add again, you will get
|
kempston <kempston> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 16 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2005-10-06 | spiralvoice | Category | None | Bug fixes | |
Status | None | Done | |||
Open/Closed | Open | Closed | |||
Summary | Fix cancel command | Remove swarmer data when cancelling download | |||
2005-09-23 | zet | Status | Postponed | None | |
2005-09-21 | zet | Attached File | - | Added cancel.diff, #5231 | |
2005-09-21 | spiralvoice | Priority | 5 - Normal | 7 - High | |
Status | None | Postponed | |||
2005-09-20 | spiralvoice | Attached File | - | Added 4450.patch, #5222 | |
2005-09-20 | spiralvoice | Attached File | #5221 | Removed | |
2005-09-20 | spiralvoice | Attached File | #5220 | Removed | |
2005-09-20 | spiralvoice | Attached File | #5219 | Removed | |
2005-09-20 | spiralvoice | Attached File | #5216 | Removed | |
2005-09-20 | spiralvoice | Attached File | #5218 | Removed | |
2005-09-20 | spiralvoice | Summary | Reassigned item: Cancel is broken | Fix cancel command | |
2005-09-20 | spiralvoice | Reassign item | From group mldonkey, a multi-networks file-sharing client, bugs tracker | To group mldonkey, a multi-networks file-sharing client, patch tracker |
Powered by Savane 3.13-4b48.
Corresponding source code
Applied cancel.diff by zet, 2005/10/06