patchmldonkey, a multi-networks file-sharing client - Patches: patch #4558, OV/KAD: fix patch #4551

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4558: OV/KAD: fix patch #4551

Submitter:  bogeyman <bogeyman>
Submitted:  Thu 27 Oct 2005 05:17:27 PM UTC
   
 
Category:  Bug fixes Priority:  7 - High
Status:  Done Assigned to:  None
Open/Closed:  Closed

Jump to the original submission

Fri 11 Nov 2005 08:53:43 AM UTC, comment #13: 

eDonkey Session Uptime: 1 days, 15h:38m
Client Brand|    seen      |     Downloads      |      Uploads       |   Banned   |  Requests
------------+--------------+--------------------+--------------------+------------+--------------
Overnet     |     1172   0%|      9.9   0.1   0%|      0.0   0.0   0%|      0   0%|       76   0%

Overnet
Overnet statistics:
  unknown_peers: 0
  boot_peers: 0
  42 buckets with 0 peers and 0 prebucket peers
  Search hits: 0
  Source hits: 93
  known_peers stats: 1023 21 2901 0 3 6
  to_ping: 0
  n_search_waiting_peers: 0
  n_search_asked_peers: 0
  n_search_ok_peers: 0
  n_search_results: 0
  n_overnet_searches: 0

spiralvoice <spiralvoice>
Group administrator
Wed 09 Nov 2005 08:48:10 PM UTC, comment #12: 

eDonkey Session Uptime: 0 days, 03h:31m

only some download:
Client Brand|    seen      |     Downloads      |      Uploads       |   Banned   |  Requests
------------+--------------+--------------------+--------------------+------------+--------------
Overnet     |      488   1%|      1.8   0.1   0%|      0.0   0.0   0%|      0   0%|       56   0%

Boot peers are zero now, although
2005/11/09 18:14:09 [Overnet] contact.dat loaded from http://download.overnet.org/contact.dat, added 500 peers

mem_stats:
Overnet
Overnet statistics:
  unknown_peers: 0
  boot_peers: 0
  42 buckets with 1 peers and 0 prebucket peers
  Search hits: 0
  Source hits: 93
  known_peers stats: 1023 23 2889 0 3 6
  to_ping: 0
  n_search_waiting_peers: 0
  n_search_asked_peers: 29
  n_search_ok_peers: 0
  n_search_results: 0
  n_overnet_searches: 103

spiralvoice <spiralvoice>
Group administrator
Wed 09 Nov 2005 04:53:19 PM UTC, comment #11: 

Why would n_used_buckets be initialized to 42?

z <zet>
Group Member
Wed 09 Nov 2005 04:42:33 PM UTC, comment #10: 

Applied 2005/11/09

spiralvoice <spiralvoice>
Group administrator
Wed 09 Nov 2005 04:36:15 PM UTC, comment #9: 

ok, this patch take take of not flooding search peers.
we do no longer send two queries for every search at once every five seconds, and a request for results every ten seconds. we do not send queries/request to peers we send something within five seconds. Short term test looks as expected, please help me testing it on long term. mem_stats on this modules and uptimes are welcome.

bogeyman <bogeyman>
Group Member
Sat 05 Nov 2005 01:47:56 PM UTC, comment #8: 


>  14 buckets with 0 peers and 0 prebucket peers

damn, this indicates overnet is dead :/ Thats the main problem. We are asking too quickly the same peer, maybe get caught by a flood-protection? The old code asks many dead peers too, so there is more time between the request. I am working on reducing the requests without hurting ours results.

btw: patch #4597 is indepentent and fix a bug for the old and new code. please apply asap

bogeyman <bogeyman>
Group Member
Fri 04 Nov 2005 03:38:08 PM UTC, comment #7: 

I will try patch #4597 and report the results in the next days.

spiralvoice <spiralvoice>
Group administrator
Fri 04 Nov 2005 03:36:21 PM UTC, comment #6: 

Since my last posting I restarted MLDonkey and got some download:
eDonkey - Session Uptime: 0 days, 18h:32m (= 66756 seconds)

Brand : Seen % | Reqs % | B % | UL % KB/s | DL % KB/s | U:DL
Overnet : 2562 (1%) | 77 (0%) | 0 (0%) | 70.0k (0%) 0.0 | 7.3M (1%) 0.1 | 1:107.24

Kademlia
Kademlia statistics:
  unknown_peers: 979
  boot_peers: 26
  13 buckets with 43 peers and 47 prebucket peers
  Search hits: 0
  Source hits: 10982
  known_peers stats: 1537 109 4947 3 3 6
  to_ping: 0
  n_search_waiting_peers: 2842
  n_search_asked_peers: 1372
  n_search_ok_peers: 0
  n_search_results: 0
  n_overnet_searches: 98

Overnet
Overnet statistics:
  unknown_peers: 0
  boot_peers: 0
  14 buckets with 0 peers and 0 prebucket peers
  Search hits: 0
  Source hits: 86
  known_peers stats: 1537 25 3942 0 3 6
  to_ping: 0
  n_search_waiting_peers: 0
  n_search_asked_peers: 0
  n_search_ok_peers: 0
  n_search_results: 0
  n_overnet_searches: 98

spiralvoice <spiralvoice>
Group administrator
Fri 04 Nov 2005 12:18:11 PM UTC, comment #5: 

i quite have problems with peers not responding after we send them several request within seconds. Working on it. Can you please post your kad/ov mem_stats? as long as you got source_hits and search_hits > 0 and active peers > 50 you should be fine.

bogeyman <bogeyman>
Group Member
Thu 03 Nov 2005 12:38:20 PM UTC, comment #4: 

Uptime 2d, 16h - not a single byte DL from Overnet...
Do you have the same experience?

spiralvoice <spiralvoice>
Group administrator
Mon 31 Oct 2005 06:07:24 PM UTC, comment #3: 

Applied 2005/10/31

spiralvoice <spiralvoice>
Group administrator
Thu 27 Oct 2005 09:34:46 PM UTC, comment #2: 

patch #4551 was removed from CVS, please post a new patch which includes the stuff from 4551 and works.

"can the bandwidthlimiter eat udp pakets"
I don“t know, maybe pango can help.

spiralvoice <spiralvoice>
Group administrator
Thu 27 Oct 2005 05:24:20 PM UTC, comment #1: 

Do you already have a patch? Otherwise I will remove patch 4551 from CVS because I want to release 2.6.7 asap.

spiralvoice <spiralvoice>
Group administrator
Thu 27 Oct 2005 05:17:27 PM UTC, original submission:  

i found i sometime loose many up to all peers from the buckets. I am testing a patch and looking trough logs, hopefully fix this behavior since patch #4551. More tomorrow.

PS: can the bandwidthlimiter eat udp pakets? this would be bad, since we now remove peers quicklier.

bogeyman <bogeyman>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #6666:  query_next_peers3.patch added by bogeyman (12KiB - text/x-patch - apply other patch first. changes queries and requesting)
file #7143:  4558.patch added by bogeyman (36KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 13 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-09 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-11-09 bogeyman StatusDone Ready For Test
    Open/ClosedClosed Open
2005-11-09 bogeyman Attached File- Added query_next_peers3.patch, #5450
2005-10-31 spiralvoice StatusReady For Test Done
    Open/ClosedOpen Closed
2005-10-31 spiralvoice StatusDone Ready For Test
    Open/ClosedClosed Open
2005-10-31 bogeyman Attached File- Added 4558.patch, #5412
2005-10-31 bogeyman SummaryOV/KAD: saner update on peer OV/KAD: fix patch #4551
2005-10-27 spiralvoice StatusNone Done
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.15-17aa.
Corresponding source code