patchmldonkey, a multi-networks file-sharing client - Patches: patch #4687, Compile with OCaml 3.09.0

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4687: Compile with OCaml 3.09.0

Submitter:  Sylvain Le Gall <gildor>
Submitted:  Thu 08 Dec 2005 12:32:42 AM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 10 Dec 2005 07:45:49 PM UTC, comment #4: 

4687_min2.patch applied to CVS 2005/12/10

spiralvoice <spiralvoice>
Group administrator
Sat 10 Dec 2005 07:42:16 PM UTC, comment #3: 

thanks Sylvian, attached you will find a new version of the minimal patch, tested with both Ocaml versions.

spiralvoice <spiralvoice>
Group administrator
Sat 10 Dec 2005 03:03:39 PM UTC, comment #2: 

Hello,

Well, yes, you could replace "camlp4"  by "camlp4 -loc loc" in the compilation. I think it should be enough.

Regard
Sylvain Le Gall

Sylvain Le Gall <gildor>
Fri 09 Dec 2005 11:42:02 PM UTC, comment #1: 

Using the minimum patch with Ocaml 3.08.4 procudes this:

mldonkey # make depend
/usr/local/bin/ocamlc.opt -I tools/zoggy -I +camlp4 -pp "camlp4 pa_o.cmo pr_dump.cmo" -a -o pa_zog.cma  tools/zoggy/zog_types.ml tools/zoggy/zog_messages.ml tools/zoggy/zog_misc.ml tools/zoggy/pa_zog.ml
File "tools/zoggy/pa_zog.ml", line 755, characters 18-46:
use of antiquotation syntax deprecated since version 3.05
File "tools/zoggy/pa_zog.ml", line 58, characters 0-1:
Unbound value loc
make: * [pa_zog.cma] Fehler 2

Is there a way to let MLdonkey use both Ocaml 3.08.x and 3.09.x?

spiralvoice <spiralvoice>
Group administrator
Thu 08 Dec 2005 12:32:42 AM UTC, original submission:  

Hello,

Is here 2 patches to compile with OCaml 3.09.0. The "_min" is the minimum set of changes to compile. You can apply also the other which try to correct some warnings.

The second seems to work but need a careful review, to see if it doesn't break anything. I have removed the most obviously useless unused variable, as suggested by the warning. Some remaining "let _ =" should also been removed (it is up to the upstream dev to see what should/could be removed). The work is not finished, i just have done what was needed to compile mldonkey on a Debian/OCaml 3.09.0 platform.

Kind regard
Sylvain Le Gall

Sylvain Le Gall <gildor>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #4138:  4687_min2.patch added by spiralvoice (2KiB - application/octet-stream - new minimal version, works both with 3.08.x and 3.09.x)
file #4170:  25_ocaml3.09.0.dpatch added by gildor (69KiB - application/octet-stream)
file #4169:  24_ocaml3.09.0_min.dpatch added by gildor (24KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 6 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-12-11 spiralvoice Open/ClosedOpen Closed
2005-12-11 spiralvoice StatusIn Progress Done
2005-12-10 spiralvoice StatusNone In Progress
2005-12-10 spiralvoice Attached File- Added 4687_min2.patch, #5573
2005-12-08 gildor Attached File- Added 25_ocaml3.09.0.dpatch, #5566
2005-12-08 gildor Attached File- Added 24_ocaml3.09.0_min.dpatch, #5565

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code