patchmldonkey, a multi-networks file-sharing client - Patches: patch #4709, Fix zip file extract broken due to...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4709: Fix zip file extract broken due to patch 4694 (Ocaml 3.09)

Submitter:  spiralvoice <spiralvoice>
Submitted:  Thu 15 Dec 2005 06:22:12 PM UTC
   
 
Category:  Bug fixes Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Thu 15 Dec 2005 07:40:02 PM UTC, comment #3: 

The theory is to remove compiler warnings which clutter the screen.
I made patch #4710 which re-implements the removed protocol informations, I hope I found everything. You are right, removing
them was no good idea, but they were not lost due to CVS;-)

spiralvoice <spiralvoice>
Group administrator
Thu 15 Dec 2005 06:46:43 PM UTC, comment #2: 

What is the theory behind this patch and patch 4694 that you think makes the code better rather than worse?

They seem to remove pertinent information from the source.   For example, lines like:

-      let version_made_by = read2 ic in
-      let version_needed = read2 ic in

are now

let _ = read2 ic in
let _ = read2 ic in

One used to be able to figure out what the bytes were based on variable names in the code.  This identified/documented file formats. Now they are not knowable.

Patch 4694 removed many lines like "let kind = get_uint8 s 22 in" which helped identify what the bytes in the buffer were ("kind") even if not currently used, which documented the various protocols, but now that information is lost.


z <zet>
Group Member
Thu 15 Dec 2005 06:39:24 PM UTC, comment #1: 

Applied 2005/12/15

spiralvoice <spiralvoice>
Group administrator
Thu 15 Dec 2005 06:22:12 PM UTC, original submission:  


spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #4054:  zip_fix.patch added by spiralvoice (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-12-15 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-12-15 zet StatusDone None
    Open/ClosedClosed Open
2005-12-15 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-12-15 spiralvoice Attached File- Added zip_fix.patch, #5609

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code