patchmldonkey, a multi-networks file-sharing client - Patches: patch #4728, fix date format

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4728: fix date format

Submitter:  z <zet>
Submitted:  Mon 19 Dec 2005 04:55:46 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Wed 21 Dec 2005 08:43:29 PM UTC, comment #5: 

Applied datefix.diff, 2005/12/21
@zet: forget what I´ve wrote, I mixed up some patches here

spiralvoice <spiralvoice>
Group administrator
Tue 20 Dec 2005 12:45:56 AM UTC, comment #4: 

Which patch are you reading? Doesn't look like my patch:

- if days > 0 then
-   Printf.sprintf " %dd " days
- else
-   if hours > 0 then
-     Printf.sprintf " %dh:%02d " hours minutes
-   else
-     Printf.sprintf " %dm:%02d " minutes seconds
+
+  if days > 0
+    then Printf.sprintf " %dd " days
+  else if hours > 0
+    then Printf.sprintf " %d:%02d:%02d " hours minutes seconds
+    else Printf.sprintf " %d:%02d " minutes seconds
+

z <zet>
Group Member
Tue 20 Dec 2005 12:39:21 AM UTC, comment #3: 

from your patch:

+  if days > 0
+    then Printf.sprintf " %dd " days
+  else if hours > 0
+    then Printf.sprintf " %d:%02d " hours minutes
+    else Printf.sprintf " %d:%02d " minutes seconds

There is no place where hours, minutes and seconds,
like 1:45:54, are printed together.

spiralvoice <spiralvoice>
Group administrator
Tue 20 Dec 2005 12:31:06 AM UTC, comment #2: 

45:54

forty five minutes, fifty four seconds

1:45:54

one hour, forty five minutes, fifty four seconds

Looks different to me, just like a standard clock.

z <zet>
Group Member
Mon 19 Dec 2005 11:09:53 PM UTC, comment #1: 

Values < 1 hour can´t be distinguished from values > 1 hour < 1 day.
Thats the reaons I introduced "h" and "m" in the display.
I can see what you mean that the display in HTML vd is bad.
What about dropping display of seconds? See my patch.

spiralvoice <spiralvoice>
Group administrator
Mon 19 Dec 2005 04:55:46 PM UTC, original submission:  

4702 breaks the standard age/last seen format in web interface.

Xm:ss isn't a standard readable format.

This reverts it to the way it was.

z <zet>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #9362:  datefix.diff added by zet (912B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-12-21 spiralvoice StatusNone Done
    Open/ClosedOpen Closed
2005-12-21 spiralvoice Attached File#5650 Removed
2005-12-19 spiralvoice Attached File- Added 4728_2.patch, #5650
2005-12-19 zet Attached File- Added datefix.diff, #5649

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code