patchmldonkey, a multi-networks file-sharing client - Patches: patch #4905, missing -fno-fomit-frame-pointer...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4905: missing -fno-fomit-frame-pointer from config/Makefile.in breaks CryptoCC

Submitter:  mike <mikex>
Submitted:  Fri 10 Feb 2006 07:30:40 PM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Done Assigned to:  None
Open/Closed:  Closed

Sat 11 Feb 2006 02:49:55 PM UTC, comment #1: 

Applied 2006/02/11

spiralvoice <spiralvoice>
Group administrator
Fri 10 Feb 2006 07:30:40 PM UTC, original submission:  

ronin [local/src/mldonkey]% grep -n CXX config/Makefile.in
301:  CRYPTOPP_LIBS_flags += -cc '$(CXX) $(CXXFLAGS)' -ccopt -fno-omit-frame-pointer
2047:   $(CXX) $(CXXFLAGS) -o $*.o "-I$(OCAMLLIB)" -c $<

If CXXFLAGS contains -fomit-frame-pointer, mldonkey hangs using 99% cpu. Adding -fno-fomit-frame-pointer to line 2047 after $(CXXFLAGS) resolves the issue, but this behaviour is not guaranteed by gcc (g++).

***** from #gcc on freenode:
20:53 < mikeX> if both -fomit-frame-pointer and -fno-fomit-frame-pointer are present on the command line, which one is used?
21:03 < UziMonkey> perhaps the latest one specified?
21:04 < mikeX> indeed, just came to the same conclusion
21:05 < UziMonkey> no, it's not right
21:05 < UziMonkey> -fno-omit-frame-pointer always forces the frame pointer
21:05 < UziMonkey> objdump doesn't lie, no matter what the docs say
21:05 < mikeX> nope, my tests indicate otherwise (gcc-3.3.5)
21:06 < UziMonkey> hmm..  then you'd better not rely on either behavior
21:06 < UziMonkey> I'm using 4.0.3, and no matter which order I put the switches, the frame pointer is always there

************** my tests:

ronin [local/src/void]% ./build -c libmd5crc.c
gcc-3.3 -c libmd5crc.c -o "test_[gcc-3.3]"
gcc-3.3 -c libmd5crc.c -fomit-frame-pointer -o "test_[gcc-3.3]_[-fomit-frame-pointer]"
gcc-3.3 -c libmd5crc.c -fno-omit-frame-pointer -o "test_[gcc-3.3]_[-fno-omit-frame-pointer]"
gcc-3.3 -c libmd5crc.c -fomit-frame-pointer -fno-omit-frame-pointer -o "test_[gcc-3.3]_[-fomit-frame-pointer -fno-omit-frame-pointer]"
gcc-3.3 -c libmd5crc.c -fno-omit-frame-pointer -fomit-frame-pointer -o "test_[gcc-3.3]_[-fno-omit-frame-pointer -fomit-frame-pointer]"
gcc-3.4 -c libmd5crc.c -o "test_[gcc-3.4]"
gcc-3.4 -c libmd5crc.c -fomit-frame-pointer -o "test_[gcc-3.4]_[-fomit-frame-pointer]"
gcc-3.4 -c libmd5crc.c -fno-omit-frame-pointer -o "test_[gcc-3.4]_[-fno-omit-frame-pointer]"
gcc-3.4 -c libmd5crc.c -fomit-frame-pointer -fno-omit-frame-pointer -o "test_[gcc-3.4]_[-fomit-frame-pointer -fno-omit-frame-pointer]"
gcc-3.4 -c libmd5crc.c -fno-omit-frame-pointer -fomit-frame-pointer -o "test_[gcc-3.4]_[-fno-omit-frame-pointer -fomit-frame-pointer]"
ronin [local/src/void]% md5sum test_\[gcc-3.*
eb106b45ea8f58d31dd50166c1effaf6  test_[gcc-3.3]
eb106b45ea8f58d31dd50166c1effaf6  test_[gcc-3.3]_[-fno-omit-frame-pointer]
76eee4a8de696b520325b3a2328654f0  test_[gcc-3.3]_[-fno-omit-frame-pointer -fomit-frame-pointer]
76eee4a8de696b520325b3a2328654f0  test_[gcc-3.3]_[-fomit-frame-pointer]
eb106b45ea8f58d31dd50166c1effaf6  test_[gcc-3.3]_[-fomit-frame-pointer -fno-omit-frame-pointer]
ea6665c77e03fc224e1945d86c886281  test_[gcc-3.4]
ea6665c77e03fc224e1945d86c886281  test_[gcc-3.4]_[-fno-omit-frame-pointer]
3bf55a0846ee15bcbc29123dc456e36b  test_[gcc-3.4]_[-fno-omit-frame-pointer -fomit-frame-pointer]
3bf55a0846ee15bcbc29123dc456e36b  test_[gcc-3.4]_[-fomit-frame-pointer]
ea6665c77e03fc224e1945d86c886281  test_[gcc-3.4]_[-fomit-frame-pointer -fno-omit-frame-pointer]


mike <mikex>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-02-11 spiralvoice StatusNone Done
    Open/ClosedOpen Closed

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code